From: Santosh Shilimkar <santosh.shilimkar@ti.com> To: linux-omap@vger.kernel.org Cc: khilman@ti.com, linux-arm-kernel@lists.infradead.org, tony@atomide.com, Santosh Shilimkar <santosh.shilimkar@ti.com> Subject: [PATCH 5/5] omap4: Remove 'FIXME: omap44xx_sram_init not implemented' Date: Sat, 12 Feb 2011 16:59:47 +0530 [thread overview] Message-ID: <1297510187-31547-6-git-send-email-santosh.shilimkar@ti.com> (raw) In-Reply-To: <1297510187-31547-1-git-send-email-santosh.shilimkar@ti.com> The omap44xx_sram_init() implements functionality to push some code on SRAM whenever the code can't be executed from external memory. The low power and DVFS code can be executed from external DDR itself thanks to OMAP4 memory controller hardware support. So on OMAP4, sram_push kind of functionality isn't needed. Hence remove the FIXME warning added for implementing sram push feature on OMAP4. Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/plat-omap/sram.c | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c index e26e504..2d7bded 100644 --- a/arch/arm/plat-omap/sram.c +++ b/arch/arm/plat-omap/sram.c @@ -405,20 +405,6 @@ static inline int omap34xx_sram_init(void) } #endif -#ifdef CONFIG_ARCH_OMAP4 -static int __init omap44xx_sram_init(void) -{ - printk(KERN_ERR "FIXME: %s not implemented\n", __func__); - - return -ENODEV; -} -#else -static inline int omap44xx_sram_init(void) -{ - return 0; -} -#endif - int __init omap_sram_init(void) { omap_detect_sram(); @@ -432,8 +418,6 @@ int __init omap_sram_init(void) omap243x_sram_init(); else if (cpu_is_omap34xx()) omap34xx_sram_init(); - else if (cpu_is_omap44xx()) - omap44xx_sram_init(); return 0; } -- 1.6.0.4
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/5] omap4: Remove 'FIXME: omap44xx_sram_init not implemented' Date: Sat, 12 Feb 2011 16:59:47 +0530 [thread overview] Message-ID: <1297510187-31547-6-git-send-email-santosh.shilimkar@ti.com> (raw) In-Reply-To: <1297510187-31547-1-git-send-email-santosh.shilimkar@ti.com> The omap44xx_sram_init() implements functionality to push some code on SRAM whenever the code can't be executed from external memory. The low power and DVFS code can be executed from external DDR itself thanks to OMAP4 memory controller hardware support. So on OMAP4, sram_push kind of functionality isn't needed. Hence remove the FIXME warning added for implementing sram push feature on OMAP4. Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/plat-omap/sram.c | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c index e26e504..2d7bded 100644 --- a/arch/arm/plat-omap/sram.c +++ b/arch/arm/plat-omap/sram.c @@ -405,20 +405,6 @@ static inline int omap34xx_sram_init(void) } #endif -#ifdef CONFIG_ARCH_OMAP4 -static int __init omap44xx_sram_init(void) -{ - printk(KERN_ERR "FIXME: %s not implemented\n", __func__); - - return -ENODEV; -} -#else -static inline int omap44xx_sram_init(void) -{ - return 0; -} -#endif - int __init omap_sram_init(void) { omap_detect_sram(); @@ -432,8 +418,6 @@ int __init omap_sram_init(void) omap243x_sram_init(); else if (cpu_is_omap34xx()) omap34xx_sram_init(); - else if (cpu_is_omap44xx()) - omap44xx_sram_init(); return 0; } -- 1.6.0.4
next prev parent reply other threads:[~2011-02-12 11:30 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-12 11:29 [PATCH 0/5] ARM: omap4 related fixes for 2.6.39 Santosh Shilimkar 2011-02-12 11:29 ` Santosh Shilimkar 2011-02-12 11:29 ` [PATCH 1/5] ARM: smp: Select local timers vs dummy timer support runtime Santosh Shilimkar 2011-02-12 11:29 ` Santosh Shilimkar 2011-02-15 4:13 ` David Brown 2011-02-15 4:13 ` David Brown 2011-02-15 4:15 ` David Brown 2011-02-15 4:15 ` David Brown 2011-02-16 12:45 ` Santosh Shilimkar 2011-02-16 12:45 ` Santosh Shilimkar 2011-02-20 11:03 ` Russell King - ARM Linux 2011-02-20 11:03 ` Russell King - ARM Linux 2011-02-20 11:07 ` [PATCH 1/5] ARM: smp: Select local timers vs dummy timersupport runtime Santosh Shilimkar 2011-02-20 11:07 ` Santosh Shilimkar 2011-02-23 16:36 ` Russell King - ARM Linux 2011-02-23 16:36 ` Russell King - ARM Linux 2011-02-23 16:38 ` [PATCH 1/5] ARM: smp: Select local timers vs dummytimersupport runtime Santosh Shilimkar 2011-02-23 16:38 ` Santosh Shilimkar 2011-02-23 17:58 ` Santosh Shilimkar 2011-02-23 17:58 ` Santosh Shilimkar 2011-02-23 19:03 ` Russell King - ARM Linux 2011-02-23 19:03 ` Russell King - ARM Linux 2011-02-23 19:11 ` [PATCH 1/5] ARM: smp: Select local timers vs dummytimersupportruntime Santosh Shilimkar 2011-02-23 19:11 ` Santosh Shilimkar 2011-02-23 19:55 ` Russell King - ARM Linux 2011-02-23 19:55 ` Russell King - ARM Linux 2011-02-23 20:04 ` [PATCH 1/5] ARM: smp: Select local timers vsdummytimersupportruntime Santosh Shilimkar 2011-02-23 20:04 ` Santosh Shilimkar 2011-02-12 11:29 ` [PATCH 2/5] omap4: Enable ARM local timers with OMAP4430 es1.0 exception Santosh Shilimkar 2011-02-12 11:29 ` Santosh Shilimkar 2011-02-14 21:08 ` Tony Lindgren 2011-02-14 21:08 ` Tony Lindgren 2011-02-18 18:11 ` Santosh Shilimkar 2011-02-18 18:11 ` Santosh Shilimkar 2011-02-12 11:29 ` [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way operation can cause data corruption Santosh Shilimkar 2011-02-12 11:29 ` Santosh Shilimkar 2011-02-12 17:50 ` Andrei Warkentin 2011-02-12 17:50 ` Andrei Warkentin 2011-02-12 17:59 ` Santosh Shilimkar 2011-02-12 17:59 ` Santosh Shilimkar 2011-02-12 23:17 ` Andrei Warkentin 2011-02-12 23:17 ` Andrei Warkentin 2011-02-14 5:08 ` Santosh Shilimkar 2011-02-14 5:08 ` Santosh Shilimkar 2011-02-14 19:33 ` Andrei Warkentin 2011-02-14 19:33 ` Andrei Warkentin 2011-02-14 21:06 ` Andrei Warkentin 2011-02-14 21:06 ` Andrei Warkentin 2011-02-15 7:14 ` Santosh Shilimkar 2011-02-15 7:14 ` Santosh Shilimkar 2011-02-15 9:10 ` Andrei Warkentin 2011-02-15 9:10 ` Andrei Warkentin 2011-02-15 9:30 ` Santosh Shilimkar 2011-02-15 9:30 ` Santosh Shilimkar 2011-02-16 12:32 ` Santosh Shilimkar 2011-02-16 12:32 ` Santosh Shilimkar 2011-02-16 15:53 ` Catalin Marinas 2011-02-16 15:53 ` Catalin Marinas 2011-02-16 15:58 ` Santosh Shilimkar 2011-02-16 15:58 ` Santosh Shilimkar 2011-02-18 12:02 ` Santosh Shilimkar 2011-02-18 12:02 ` Santosh Shilimkar 2011-02-12 11:29 ` [PATCH 4/5] omap2plus: omap4: Set NR_CPU to 2 instead of default 4 Santosh Shilimkar 2011-02-12 11:29 ` Santosh Shilimkar 2011-02-14 21:09 ` Tony Lindgren 2011-02-14 21:09 ` Tony Lindgren 2011-02-12 11:29 ` Santosh Shilimkar [this message] 2011-02-12 11:29 ` [PATCH 5/5] omap4: Remove 'FIXME: omap44xx_sram_init not implemented' Santosh Shilimkar 2011-02-14 21:09 ` Tony Lindgren 2011-02-14 21:09 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1297510187-31547-6-git-send-email-santosh.shilimkar@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.