All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Andrei Warkentin <andreiw@motorola.com>,
	Kevin Hilman <khilman@ti.com>,
	tony@atomide.com, linux-omap@vger.kernel.org
Subject: RE: [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way operation can cause data corruption
Date: Fri, 18 Feb 2011 17:32:32 +0530	[thread overview]
Message-ID: <a52fd2d3aaca5ad999974fe3f886d90d@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikEjTgisftQV46djrOP8iWMFV267v-efHsVf_Nd@mail.gmail.com>

> -----Original Message-----
> From: catalin.marinas@gmail.com [mailto:catalin.marinas@gmail.com]
> On Behalf Of Catalin Marinas
> Sent: Wednesday, February 16, 2011 9:24 PM
> To: Santosh Shilimkar
> Cc: linux-arm-kernel@lists.infradead.org; Andrei Warkentin; Kevin
> Hilman; tony@atomide.com; linux-omap@vger.kernel.org
> Subject: Re: [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way
> operation can cause data corruption
>
> On 15 February 2011 07:14, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1140,7 +1140,7 @@ config ARM_ERRATA_742231
> >
> >  config PL310_ERRATA_588369
> >        bool "Clean & Invalidate maintenance operations do not
> invalidate
> > clean lines"
> > -       depends on CACHE_L2X0 && ARCH_OMAP4
> > +       depends on CACHE_L2X0 && CACHE_PL310
>
> It can just depend on CACHE_PL310 as this depends on CACHE_L2X0.
>
With CACHE_PL310 alone, I get below warning.

warning: (ARCH_OMAP4) selects PL310_ERRATA_588369 which has unmet direct
dependencies (CACHE_PL310)

This is coming because Pl310 can't be selected on V6 and OMAP
common build has V6 and V7 both enabled.

So to avoid the warning and also able to select the errata in
OMAP build, I am making the errata's depends on CACHE_L2X0
with comment.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way operation can cause data corruption
Date: Fri, 18 Feb 2011 17:32:32 +0530	[thread overview]
Message-ID: <a52fd2d3aaca5ad999974fe3f886d90d@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikEjTgisftQV46djrOP8iWMFV267v-efHsVf_Nd@mail.gmail.com>

> -----Original Message-----
> From: catalin.marinas at gmail.com [mailto:catalin.marinas at gmail.com]
> On Behalf Of Catalin Marinas
> Sent: Wednesday, February 16, 2011 9:24 PM
> To: Santosh Shilimkar
> Cc: linux-arm-kernel at lists.infradead.org; Andrei Warkentin; Kevin
> Hilman; tony at atomide.com; linux-omap at vger.kernel.org
> Subject: Re: [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way
> operation can cause data corruption
>
> On 15 February 2011 07:14, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1140,7 +1140,7 @@ config ARM_ERRATA_742231
> >
> > ?config PL310_ERRATA_588369
> > ? ? ? ?bool "Clean & Invalidate maintenance operations do not
> invalidate
> > clean lines"
> > - ? ? ? depends on CACHE_L2X0 && ARCH_OMAP4
> > + ? ? ? depends on CACHE_L2X0 && CACHE_PL310
>
> It can just depend on CACHE_PL310 as this depends on CACHE_L2X0.
>
With CACHE_PL310 alone, I get below warning.

warning: (ARCH_OMAP4) selects PL310_ERRATA_588369 which has unmet direct
dependencies (CACHE_PL310)

This is coming because Pl310 can't be selected on V6 and OMAP
common build has V6 and V7 both enabled.

So to avoid the warning and also able to select the errata in
OMAP build, I am making the errata's depends on CACHE_L2X0
with comment.

Regards,
Santosh

  parent reply	other threads:[~2011-02-18 12:02 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-12 11:29 [PATCH 0/5] ARM: omap4 related fixes for 2.6.39 Santosh Shilimkar
2011-02-12 11:29 ` Santosh Shilimkar
2011-02-12 11:29 ` [PATCH 1/5] ARM: smp: Select local timers vs dummy timer support runtime Santosh Shilimkar
2011-02-12 11:29   ` Santosh Shilimkar
2011-02-15  4:13   ` David Brown
2011-02-15  4:13     ` David Brown
2011-02-15  4:15   ` David Brown
2011-02-15  4:15     ` David Brown
2011-02-16 12:45   ` Santosh Shilimkar
2011-02-16 12:45     ` Santosh Shilimkar
2011-02-20 11:03   ` Russell King - ARM Linux
2011-02-20 11:03     ` Russell King - ARM Linux
2011-02-20 11:07     ` [PATCH 1/5] ARM: smp: Select local timers vs dummy timersupport runtime Santosh Shilimkar
2011-02-20 11:07       ` Santosh Shilimkar
2011-02-23 16:36       ` Russell King - ARM Linux
2011-02-23 16:36         ` Russell King - ARM Linux
2011-02-23 16:38         ` [PATCH 1/5] ARM: smp: Select local timers vs dummytimersupport runtime Santosh Shilimkar
2011-02-23 16:38           ` Santosh Shilimkar
2011-02-23 17:58           ` Santosh Shilimkar
2011-02-23 17:58             ` Santosh Shilimkar
2011-02-23 19:03             ` Russell King - ARM Linux
2011-02-23 19:03               ` Russell King - ARM Linux
2011-02-23 19:11               ` [PATCH 1/5] ARM: smp: Select local timers vs dummytimersupportruntime Santosh Shilimkar
2011-02-23 19:11                 ` Santosh Shilimkar
2011-02-23 19:55                 ` Russell King - ARM Linux
2011-02-23 19:55                   ` Russell King - ARM Linux
2011-02-23 20:04                   ` [PATCH 1/5] ARM: smp: Select local timers vsdummytimersupportruntime Santosh Shilimkar
2011-02-23 20:04                     ` Santosh Shilimkar
2011-02-12 11:29 ` [PATCH 2/5] omap4: Enable ARM local timers with OMAP4430 es1.0 exception Santosh Shilimkar
2011-02-12 11:29   ` Santosh Shilimkar
2011-02-14 21:08   ` Tony Lindgren
2011-02-14 21:08     ` Tony Lindgren
2011-02-18 18:11   ` Santosh Shilimkar
2011-02-18 18:11     ` Santosh Shilimkar
2011-02-12 11:29 ` [PATCH 3/5] ARM: l2x0: Errata fix for flush by Way operation can cause data corruption Santosh Shilimkar
2011-02-12 11:29   ` Santosh Shilimkar
2011-02-12 17:50   ` Andrei Warkentin
2011-02-12 17:50     ` Andrei Warkentin
2011-02-12 17:59     ` Santosh Shilimkar
2011-02-12 17:59       ` Santosh Shilimkar
2011-02-12 23:17       ` Andrei Warkentin
2011-02-12 23:17         ` Andrei Warkentin
2011-02-14  5:08         ` Santosh Shilimkar
2011-02-14  5:08           ` Santosh Shilimkar
2011-02-14 19:33           ` Andrei Warkentin
2011-02-14 19:33             ` Andrei Warkentin
2011-02-14 21:06             ` Andrei Warkentin
2011-02-14 21:06               ` Andrei Warkentin
2011-02-15  7:14           ` Santosh Shilimkar
2011-02-15  7:14             ` Santosh Shilimkar
2011-02-15  9:10             ` Andrei Warkentin
2011-02-15  9:10               ` Andrei Warkentin
2011-02-15  9:30               ` Santosh Shilimkar
2011-02-15  9:30                 ` Santosh Shilimkar
2011-02-16 12:32             ` Santosh Shilimkar
2011-02-16 12:32               ` Santosh Shilimkar
2011-02-16 15:53             ` Catalin Marinas
2011-02-16 15:53               ` Catalin Marinas
2011-02-16 15:58               ` Santosh Shilimkar
2011-02-16 15:58                 ` Santosh Shilimkar
2011-02-18 12:02               ` Santosh Shilimkar [this message]
2011-02-18 12:02                 ` Santosh Shilimkar
2011-02-12 11:29 ` [PATCH 4/5] omap2plus: omap4: Set NR_CPU to 2 instead of default 4 Santosh Shilimkar
2011-02-12 11:29   ` Santosh Shilimkar
2011-02-14 21:09   ` Tony Lindgren
2011-02-14 21:09     ` Tony Lindgren
2011-02-12 11:29 ` [PATCH 5/5] omap4: Remove 'FIXME: omap44xx_sram_init not implemented' Santosh Shilimkar
2011-02-12 11:29   ` Santosh Shilimkar
2011-02-14 21:09   ` Tony Lindgren
2011-02-14 21:09     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a52fd2d3aaca5ad999974fe3f886d90d@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=andreiw@motorola.com \
    --cc=catalin.marinas@arm.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.