All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
	Derek Kiernan <derek.kiernan@xilinx.com>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Olof Johansson <olof@lixom.net>,
	dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
	Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>,
	Tomasz Jankowski <tomasz1.jankowski@intel.com>,
	Jianxun Zhang <jianxun.zhang@linux.intel.com>
Subject: Re: [PATCH v5 01/10] gna: add PCI driver module
Date: Fri, 21 Oct 2022 15:10:06 +0700	[thread overview]
Message-ID: <12aeed77-081c-ac40-4b6e-0415d551804e@gmail.com> (raw)
In-Reply-To: <Y1IeJplXNHM+VvCJ@kroah.com>

On 10/21/22 11:20, Greg Kroah-Hartman wrote:
> On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote:
>> Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator
> 
> Please drop all of the (R) stuff in here, and in the Kconfig file and in
> the .c files.  If your lawyers insist on it, please point them at me and
> I will be glad to discuss it with them.
> 
>>  Documentation/gpu/drivers.rst    |  1 +
>>  Documentation/gpu/gna.rst        | 64 ++++++++++++++++++++++++++++++++
> 
> Why not just put the tiny documentation file in the .c code itself?
> That way it stays up to date and might actually be noticed?
> 

I think the documentation should be on separate patch.

-- 
An old man doll... just what I always wanted! - Clara


WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
	Dragan Cvetic <dragan.cvetic@xilinx.com>,
	linux-doc@vger.kernel.org,
	Tomasz Jankowski <tomasz1.jankowski@intel.com>,
	Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Derek Kiernan <derek.kiernan@xilinx.com>,
	Jianxun Zhang <jianxun.zhang@linux.intel.com>
Subject: Re: [PATCH v5 01/10] gna: add PCI driver module
Date: Fri, 21 Oct 2022 15:10:06 +0700	[thread overview]
Message-ID: <12aeed77-081c-ac40-4b6e-0415d551804e@gmail.com> (raw)
In-Reply-To: <Y1IeJplXNHM+VvCJ@kroah.com>

On 10/21/22 11:20, Greg Kroah-Hartman wrote:
> On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote:
>> Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator
> 
> Please drop all of the (R) stuff in here, and in the Kconfig file and in
> the .c files.  If your lawyers insist on it, please point them at me and
> I will be glad to discuss it with them.
> 
>>  Documentation/gpu/drivers.rst    |  1 +
>>  Documentation/gpu/gna.rst        | 64 ++++++++++++++++++++++++++++++++
> 
> Why not just put the tiny documentation file in the .c code itself?
> That way it stays up to date and might actually be noticed?
> 

I think the documentation should be on separate patch.

-- 
An old man doll... just what I always wanted! - Clara


  reply	other threads:[~2022-10-21  8:10 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 17:53 [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 01/10] gna: add PCI driver module Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-20 18:49   ` Andy Shevchenko
2022-10-20 18:49     ` Andy Shevchenko
2022-10-21  4:02   ` Bagas Sanjaya
2022-10-21  4:02     ` Bagas Sanjaya
2022-10-21  4:20   ` Greg Kroah-Hartman
2022-10-21  4:20     ` Greg Kroah-Hartman
2022-10-21  8:10     ` Bagas Sanjaya [this message]
2022-10-21  8:10       ` Bagas Sanjaya
2022-10-21  8:27       ` Greg Kroah-Hartman
2022-10-21  8:27         ` Greg Kroah-Hartman
2022-10-24 13:40     ` Maciej Kwapulinski
2022-10-24 13:40       ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 02/10] gna: add GNA DRM device Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-20 18:52   ` Andy Shevchenko
2022-10-20 18:52     ` Andy Shevchenko
2022-10-21  4:25   ` Greg Kroah-Hartman
2022-10-21  4:25     ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 03/10] gna: read hardware info Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-21  4:21   ` Greg Kroah-Hartman
2022-10-21  4:21     ` Greg Kroah-Hartman
2022-10-21  9:19   ` Linus Walleij
2022-10-21  9:19     ` Linus Walleij
2022-10-20 17:53 ` [PATCH v5 04/10] gna: initialize MMU Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-20 19:00   ` Andy Shevchenko
2022-10-20 19:00     ` Andy Shevchenko
2022-10-20 19:01     ` Andy Shevchenko
2022-10-20 19:01       ` Andy Shevchenko
2022-10-20 17:53 ` [PATCH v5 05/10] gna: add GNA_GET_PARAMETER ioctl Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-21  4:23   ` Greg Kroah-Hartman
2022-10-21  4:23     ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 06/10] gna: add GNA_GEM_NEW and GNA_GEM_FREE ioctls Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-20 19:06   ` Andy Shevchenko
2022-10-20 19:06     ` Andy Shevchenko
2022-10-20 17:53 ` [PATCH v5 07/10] gna: add GNA_COMPUTE ioctl Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-21  9:30   ` Linus Walleij
2022-10-21  9:30     ` Linus Walleij
2022-10-21 11:52     ` Maciej Kwapulinski
2022-10-21 11:52       ` Maciej Kwapulinski
2022-10-21 11:57       ` Maciej Kwapulinski
2022-10-21 11:57         ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 08/10] gna: add GNA_WAIT ioctl Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-21  4:25   ` Greg Kroah-Hartman
2022-10-21  4:25     ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 09/10] gna: add power management Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-21  9:37   ` Linus Walleij
2022-10-21  9:37     ` Linus Walleij
2022-10-20 17:53 ` [PATCH v5 10/10] gna: add open and close operations on GNA device Maciej Kwapulinski
2022-10-20 17:53   ` Maciej Kwapulinski
2022-10-21  4:27   ` Greg Kroah-Hartman
2022-10-21  4:27     ` Greg Kroah-Hartman
2022-10-21  9:23     ` Daniel Vetter
2022-10-21  9:23       ` Daniel Vetter
2022-10-20 19:08 ` [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator Andy Shevchenko
2022-10-20 19:08   ` Andy Shevchenko
2022-10-21  4:17 ` Greg Kroah-Hartman
2022-10-21  4:17   ` Greg Kroah-Hartman
2022-10-24 13:21   ` Maciej Kwapulinski
2022-10-24 13:21     ` Maciej Kwapulinski
2022-10-24 11:29 ` Thomas Zimmermann
2023-01-24  8:25   ` Oded Gabbay
2023-01-24  8:25     ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12aeed77-081c-ac40-4b6e-0415d551804e@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=derek.kiernan@xilinx.com \
    --cc=dragan.cvetic@xilinx.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jianxun.zhang@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=maciej.kwapulinski@linux.intel.com \
    --cc=mikolajx.grzybowski@intel.com \
    --cc=mripard@kernel.org \
    --cc=olof@lixom.net \
    --cc=tomasz1.jankowski@intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.