From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Linus Walleij <linus.walleij@linaro.org>,
Olof Johansson <olof@lixom.net>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>
Subject: Re: [PATCH v5 02/10] gna: add GNA DRM device
Date: Thu, 20 Oct 2022 21:52:50 +0300 [thread overview]
Message-ID: <CAHp75Vdb-bCR+E2zzrSULCoxhWqfJTzF38FCxCfKFx3D3vddVg@mail.gmail.com> (raw)
In-Reply-To: <20221020175334.1820519-3-maciej.kwapulinski@linux.intel.com>
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski
<maciej.kwapulinski@linux.intel.com> wrote:
Missed commit message.
> Signed-off-by: Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
> Tested-by: Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>
...
> + if (!(sizeof(dma_addr_t) > 4) ||
Do you really need this?
> + dma_set_mask(parent, DMA_BIT_MASK(64))) {
> + err = dma_set_mask(parent, DMA_BIT_MASK(32));
> + if (err)
> + return err;
IIRC if the 64-bit dma_set_mask() fails, there is no need to check
32-bit, i.e. it will fail.
> + }
...
> +#define DRIVER_DATE "20211201"
Really?
...
> +#include <linux/mm_types.h>
Are you sure?
> +struct gna_dev_info {
> + u32 hwid;
> + u32 num_pagetables;
> + u32 num_page_entries;
> + u32 max_layer_count;
> + u64 max_hw_mem;
> +};
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
linux-doc@vger.kernel.org,
Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Derek Kiernan <derek.kiernan@xilinx.com>
Subject: Re: [PATCH v5 02/10] gna: add GNA DRM device
Date: Thu, 20 Oct 2022 21:52:50 +0300 [thread overview]
Message-ID: <CAHp75Vdb-bCR+E2zzrSULCoxhWqfJTzF38FCxCfKFx3D3vddVg@mail.gmail.com> (raw)
In-Reply-To: <20221020175334.1820519-3-maciej.kwapulinski@linux.intel.com>
On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski
<maciej.kwapulinski@linux.intel.com> wrote:
Missed commit message.
> Signed-off-by: Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
> Tested-by: Mikolaj Grzybowski <mikolajx.grzybowski@intel.com>
...
> + if (!(sizeof(dma_addr_t) > 4) ||
Do you really need this?
> + dma_set_mask(parent, DMA_BIT_MASK(64))) {
> + err = dma_set_mask(parent, DMA_BIT_MASK(32));
> + if (err)
> + return err;
IIRC if the 64-bit dma_set_mask() fails, there is no need to check
32-bit, i.e. it will fail.
> + }
...
> +#define DRIVER_DATE "20211201"
Really?
...
> +#include <linux/mm_types.h>
Are you sure?
> +struct gna_dev_info {
> + u32 hwid;
> + u32 num_pagetables;
> + u32 num_page_entries;
> + u32 max_layer_count;
> + u64 max_hw_mem;
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-10-20 18:53 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 17:53 [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 01/10] gna: add PCI driver module Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-20 18:49 ` Andy Shevchenko
2022-10-20 18:49 ` Andy Shevchenko
2022-10-21 4:02 ` Bagas Sanjaya
2022-10-21 4:02 ` Bagas Sanjaya
2022-10-21 4:20 ` Greg Kroah-Hartman
2022-10-21 4:20 ` Greg Kroah-Hartman
2022-10-21 8:10 ` Bagas Sanjaya
2022-10-21 8:10 ` Bagas Sanjaya
2022-10-21 8:27 ` Greg Kroah-Hartman
2022-10-21 8:27 ` Greg Kroah-Hartman
2022-10-24 13:40 ` Maciej Kwapulinski
2022-10-24 13:40 ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 02/10] gna: add GNA DRM device Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-20 18:52 ` Andy Shevchenko [this message]
2022-10-20 18:52 ` Andy Shevchenko
2022-10-21 4:25 ` Greg Kroah-Hartman
2022-10-21 4:25 ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 03/10] gna: read hardware info Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-21 4:21 ` Greg Kroah-Hartman
2022-10-21 4:21 ` Greg Kroah-Hartman
2022-10-21 9:19 ` Linus Walleij
2022-10-21 9:19 ` Linus Walleij
2022-10-20 17:53 ` [PATCH v5 04/10] gna: initialize MMU Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-20 19:00 ` Andy Shevchenko
2022-10-20 19:00 ` Andy Shevchenko
2022-10-20 19:01 ` Andy Shevchenko
2022-10-20 19:01 ` Andy Shevchenko
2022-10-20 17:53 ` [PATCH v5 05/10] gna: add GNA_GET_PARAMETER ioctl Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-21 4:23 ` Greg Kroah-Hartman
2022-10-21 4:23 ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 06/10] gna: add GNA_GEM_NEW and GNA_GEM_FREE ioctls Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-20 19:06 ` Andy Shevchenko
2022-10-20 19:06 ` Andy Shevchenko
2022-10-20 17:53 ` [PATCH v5 07/10] gna: add GNA_COMPUTE ioctl Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-21 9:30 ` Linus Walleij
2022-10-21 9:30 ` Linus Walleij
2022-10-21 11:52 ` Maciej Kwapulinski
2022-10-21 11:52 ` Maciej Kwapulinski
2022-10-21 11:57 ` Maciej Kwapulinski
2022-10-21 11:57 ` Maciej Kwapulinski
2022-10-20 17:53 ` [PATCH v5 08/10] gna: add GNA_WAIT ioctl Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-21 4:25 ` Greg Kroah-Hartman
2022-10-21 4:25 ` Greg Kroah-Hartman
2022-10-20 17:53 ` [PATCH v5 09/10] gna: add power management Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-21 9:37 ` Linus Walleij
2022-10-21 9:37 ` Linus Walleij
2022-10-20 17:53 ` [PATCH v5 10/10] gna: add open and close operations on GNA device Maciej Kwapulinski
2022-10-20 17:53 ` Maciej Kwapulinski
2022-10-21 4:27 ` Greg Kroah-Hartman
2022-10-21 4:27 ` Greg Kroah-Hartman
2022-10-21 9:23 ` Daniel Vetter
2022-10-21 9:23 ` Daniel Vetter
2022-10-20 19:08 ` [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator Andy Shevchenko
2022-10-20 19:08 ` Andy Shevchenko
2022-10-21 4:17 ` Greg Kroah-Hartman
2022-10-21 4:17 ` Greg Kroah-Hartman
2022-10-24 13:21 ` Maciej Kwapulinski
2022-10-24 13:21 ` Maciej Kwapulinski
2022-10-24 11:29 ` Thomas Zimmermann
2023-01-24 8:25 ` Oded Gabbay
2023-01-24 8:25 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vdb-bCR+E2zzrSULCoxhWqfJTzF38FCxCfKFx3D3vddVg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maciej.kwapulinski@linux.intel.com \
--cc=mikolajx.grzybowski@intel.com \
--cc=mripard@kernel.org \
--cc=olof@lixom.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.