From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
vimal.newwork@gmail.com, bdefaria@adeneo-embedded.com
Subject: Re: [PATCH] omap : nand : fix subpage ecc issue with prefetch
Date: Thu, 05 May 2011 21:48:58 +0300 [thread overview]
Message-ID: <1304621338.7222.55.camel@localhost> (raw)
In-Reply-To: <1304334638-2198-1-git-send-email-kishore.kadiyala@ti.com>
On Mon, 2011-05-02 at 16:40 +0530, Kishore Kadiyala wrote:
> For prefetch engine, read and write got broken in commit '2c01946c'.
> We never hit a scenario of not getting 'gpmc_prefetch_enable'
> call success.
> When reading/writing a subpage with a non divisible by 4 ecc number
> of bytes, the mis-aligned bytes gets handled first before enabling
> the Prefetch engine, then it reads/writes rest of the bytes.
>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> Signed-off-by: Vimal Singh <vimal.newwork@gmail.com>
> Reported-by: Bryan DE FARIA <bdefaria@adeneo-embedded.com>
This needs a better commit message with more explanation and analysis of
the problem and how it was fixed.This commit message is not very
understandable. And then it needs also:
Cc: stable@kernel.org [2.6.36+]
Right? And then we could send it upstream.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: bdefaria@adeneo-embedded.com, vimal.newwork@gmail.com,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] omap : nand : fix subpage ecc issue with prefetch
Date: Thu, 05 May 2011 21:48:58 +0300 [thread overview]
Message-ID: <1304621338.7222.55.camel@localhost> (raw)
In-Reply-To: <1304334638-2198-1-git-send-email-kishore.kadiyala@ti.com>
On Mon, 2011-05-02 at 16:40 +0530, Kishore Kadiyala wrote:
> For prefetch engine, read and write got broken in commit '2c01946c'.
> We never hit a scenario of not getting 'gpmc_prefetch_enable'
> call success.
> When reading/writing a subpage with a non divisible by 4 ecc number
> of bytes, the mis-aligned bytes gets handled first before enabling
> the Prefetch engine, then it reads/writes rest of the bytes.
>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> Signed-off-by: Vimal Singh <vimal.newwork@gmail.com>
> Reported-by: Bryan DE FARIA <bdefaria@adeneo-embedded.com>
This needs a better commit message with more explanation and analysis of
the problem and how it was fixed.This commit message is not very
understandable. And then it needs also:
Cc: stable@kernel.org [2.6.36+]
Right? And then we could send it upstream.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-05-05 18:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 11:10 [PATCH] omap : nand : fix subpage ecc issue with prefetch Kishore Kadiyala
2011-05-02 11:10 ` Kishore Kadiyala
2011-05-05 14:20 ` Vimal Singh
2011-05-05 14:20 ` Vimal Singh
2011-05-05 18:48 ` Artem Bityutskiy [this message]
2011-05-05 18:48 ` Artem Bityutskiy
2011-05-06 7:30 ` Vimal Singh
2011-05-06 7:30 ` Vimal Singh
2011-05-06 18:56 ` Artem Bityutskiy
2011-05-06 18:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304621338.7222.55.camel@localhost \
--to=dedekind1@gmail.com \
--cc=bdefaria@adeneo-embedded.com \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.