All of lore.kernel.org
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)
@ 2011-05-20 23:33 Antonio Quartulli
  2011-05-21  7:00 ` Sven Eckelmann
  2011-05-22  9:17 ` Marek Lindner
  0 siblings, 2 replies; 3+ messages in thread
From: Antonio Quartulli @ 2011-05-20 23:33 UTC (permalink / raw)
  To: B.A.T.M.A.N

Instead of comparing mac addresses with the broadcast address by means
of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
used.

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 routing.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/routing.c b/routing.c
index 07f23ba..90ae6f0 100644
--- a/routing.c
+++ b/routing.c
@@ -661,7 +661,7 @@ void receive_bat_packet(const struct ethhdr *ethhdr,
 				hard_iface->net_dev->dev_addr))
 			is_my_oldorig = 1;
 
-		if (compare_eth(ethhdr->h_source, broadcast_addr))
+		if (is_broadcast_ether_addr(ethhdr->h_source))
 			is_broadcast = 1;
 	}
 	rcu_read_unlock();
-- 
1.7.3.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)
  2011-05-20 23:33 [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr) Antonio Quartulli
@ 2011-05-21  7:00 ` Sven Eckelmann
  2011-05-22  9:17 ` Marek Lindner
  1 sibling, 0 replies; 3+ messages in thread
From: Sven Eckelmann @ 2011-05-21  7:00 UTC (permalink / raw)
  To: b.a.t.m.a.n

[-- Attachment #1: Type: Text/Plain, Size: 808 bytes --]

Antonio Quartulli wrote:
> Instead of comparing mac addresses with the broadcast address by means
> of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
> used.
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>

Acked-by: Sven Eckelmann <sven@narfation.org>

> ---
>  routing.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/routing.c b/routing.c
> index 07f23ba..90ae6f0 100644
> --- a/routing.c
> +++ b/routing.c
> @@ -661,7 +661,7 @@ void receive_bat_packet(const struct ethhdr *ethhdr,
>  				hard_iface->net_dev->dev_addr))
>  			is_my_oldorig = 1;
> 
> -		if (compare_eth(ethhdr->h_source, broadcast_addr))
> +		if (is_broadcast_ether_addr(ethhdr->h_source))
>  			is_broadcast = 1;
>  	}
>  	rcu_read_unlock();

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)
  2011-05-20 23:33 [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr) Antonio Quartulli
  2011-05-21  7:00 ` Sven Eckelmann
@ 2011-05-22  9:17 ` Marek Lindner
  1 sibling, 0 replies; 3+ messages in thread
From: Marek Lindner @ 2011-05-22  9:17 UTC (permalink / raw)
  To: The list for a Better Approach To Mobile Ad-hoc Networking

On Saturday 21 May 2011 01:33:07 Antonio Quartulli wrote:
> Instead of comparing mac addresses with the broadcast address by means
> of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
> used.

Applied in revision fe2a2e4.

Thanks,
Marek

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-22  9:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-20 23:33 [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr) Antonio Quartulli
2011-05-21  7:00 ` Sven Eckelmann
2011-05-22  9:17 ` Marek Lindner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.