[B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)

[B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)

[Antonio Quartulli]

Instead of comparing mac addresses with the broadcast address by means
of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
used.

Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 routing.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/routing.c b/routing.c
index 07f23ba..90ae6f0 100644
--- a/routing.c
+++ b/routing.c
@@ -661,7 +661,7 @@ void receive_bat_packet(const struct ethhdr *ethhdr,
 				hard_iface->net_dev->dev_addr))
 			is_my_oldorig = 1;
 
-		if (compare_eth(ethhdr->h_source, broadcast_addr))
+		if (is_broadcast_ether_addr(ethhdr->h_source))
 			is_broadcast = 1;
 	}
 	rcu_read_unlock();
-- 
1.7.3.4

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)

[Sven Eckelmann]

[-- Attachment #1: Type: Text/Plain, Size: 808 bytes --]

Antonio Quartulli wrote:
> Instead of comparing mac addresses with the broadcast address by means
> of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
> used.
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>

Acked-by: Sven Eckelmann <sven@narfation.org>

> ---
>  routing.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/routing.c b/routing.c
> index 07f23ba..90ae6f0 100644
> --- a/routing.c
> +++ b/routing.c
> @@ -661,7 +661,7 @@ void receive_bat_packet(const struct ethhdr *ethhdr,
>  				hard_iface->net_dev->dev_addr))
>  			is_my_oldorig = 1;
> 
> -		if (compare_eth(ethhdr->h_source, broadcast_addr))
> +		if (is_broadcast_ether_addr(ethhdr->h_source))
>  			is_broadcast = 1;
>  	}
>  	rcu_read_unlock();

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use is_broadcast_ether_addr() instead of compare_eth(.., brd_addr)

[Marek Lindner]

On Saturday 21 May 2011 01:33:07 Antonio Quartulli wrote:
> Instead of comparing mac addresses with the broadcast address by means
> of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
> used.

Applied in revision fe2a2e4.

Thanks,
Marek