Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]

From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Jens Axboe <jaxboe@fusionio.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Linux SCSI List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]
Date: Wed, 25 May 2011 15:29:47 -0500	[thread overview]
Message-ID: <1306355387.1641.58.camel@mulgrave.site> (raw)
In-Reply-To: <alpine.DEB.2.02.1105251622040.8972@ubuntu-natty>

On Wed, 2011-05-25 at 16:22 -0400, Parag Warudkar wrote:
> 
> On Wed, 25 May 2011, James Bottomley wrote:
> 
> > On Wed, 2011-05-25 at 13:03 -0700, Linus Torvalds wrote:
> > > On Wed, May 25, 2011 at 12:52 PM, Parag Warudkar <parag.lkml@gmail.com> wrote:
> > > >
> > > > +static inline int sdev_early_check(struct scsi_device *sdev)
> > > > +{
> > > > +       if (!sdev || sdev->sdev_state == SDEV_DEL
> > > > +               || sdev->sdev_state > SDEV_QUIESCE)
> > > > +               return -ENXIO;
> > > > +       return 0;
> > > > +}
> > > 
> > > Can somebody explain why it's those states, and nothing else?
> > 
> > The states are definitely wrong.  QUIESCE shouldn't cause an error.
> > 
> QUIESCE is not causing an error above - > QUIESCE is which per the 
> documentation is correct.

BLOCK means a similar thing.

James