All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Parag Warudkar <parag.lkml@gmail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	Jens Axboe <jaxboe@fusionio.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Linux SCSI List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]
Date: Wed, 25 May 2011 16:14:52 -0700	[thread overview]
Message-ID: <BANLkTik+BDbex5-LTjBzhUXf34WuyM0Jmw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimuomu=_JuMr7SWrMVvboMX4BX0fA@mail.gmail.com>

On Wed, May 25, 2011 at 4:00 PM, Parag Warudkar <parag.lkml@gmail.com> wrote:
>
> It doesn't seem to help. Machine locked up and I was dropped to text
> console. I could only capture the oops by a camera.

Hmm. That's a different oops. It is now in scsi_prep_state_check().

At the beginning of it too. You can't see the "Code: " line in the
pictures, but the only dereference I see there is "sdev" itself being
NULL. And %cr2 is 0x640, which would seem to agree (the 'sdev'
structure is absolutely disgustingly big, and sdev->sdev_state is
indeed at an offset in that region.

That 'sdev' comes from scsi_prep_fn() doing

    struct scsi_device *sdev = q->queuedata;

is that queuedata perhaps cleared even if the queue itself stays
around due to refcounts?

                       Linus

  reply	other threads:[~2011-05-25 23:15 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24  4:29 __elv_add_request OOPS Parag Warudkar
2011-05-24 10:44 ` Jens Axboe
2011-05-24 10:44   ` Jens Axboe
2011-05-25  1:41   ` [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] Parag Warudkar
2011-05-25  1:41     ` Parag Warudkar
2011-05-25  7:37     ` Jens Axboe
2011-05-25  7:37       ` Jens Axboe
2011-05-25 18:44       ` Parag Warudkar
2011-05-25 18:44         ` Parag Warudkar
2011-05-25 18:55         ` Linus Torvalds
2011-05-25 18:55           ` Linus Torvalds
2011-05-25 19:02           ` Jens Axboe
2011-05-25 19:02             ` Jens Axboe
2011-05-25 19:13             ` Linus Torvalds
2011-05-25 19:13               ` Linus Torvalds
2011-05-25 19:17               ` Jens Axboe
2011-05-25 19:17                 ` Jens Axboe
2011-05-25 19:52                 ` Parag Warudkar
2011-05-25 19:52                   ` Parag Warudkar
2011-05-25 20:03                   ` Linus Torvalds
2011-05-25 20:03                     ` Linus Torvalds
2011-05-25 20:18                     ` Parag Warudkar
2011-05-25 20:18                       ` Parag Warudkar
2011-05-25 20:26                       ` Linus Torvalds
2011-05-25 20:26                         ` Linus Torvalds
2011-05-25 20:42                         ` Parag Warudkar
2011-05-25 20:42                           ` Parag Warudkar
2011-05-25 20:52                           ` James Bottomley
2011-05-25 23:00                             ` Parag Warudkar
2011-05-25 23:14                               ` Linus Torvalds [this message]
2011-05-25 23:45                                 ` Parag Warudkar
2011-05-25 23:52                                   ` Linus Torvalds
     [not found]                               ` <1306370123.1641.76.camel@mulgrave.site>
2011-05-26  1:01                                 ` Linus Torvalds
2011-05-26  1:06                                   ` James Bottomley
2011-05-26  1:43                                 ` Parag Warudkar
2011-05-27  3:53                             ` James Bottomley
2011-05-27  5:43                               ` Jens Axboe
2011-05-27 20:21                                 ` James Bottomley
2011-05-27 20:21                                   ` James Bottomley
2011-05-28 12:42                                   ` Jens Axboe
2011-05-28 12:42                                     ` Jens Axboe
2011-06-08  6:50                                   ` Torsten Hilbrich
2011-06-08  6:50                                     ` Torsten Hilbrich
2011-05-25 20:20                     ` James Bottomley
2011-05-25 20:22                       ` Parag Warudkar
2011-05-25 20:29                         ` James Bottomley
2011-05-25 20:26   ` __elv_add_request OOPS James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTik+BDbex5-LTjBzhUXf34WuyM0Jmw@mail.gmail.com \
    --to=torvalds@linux-foundation.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=parag.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.