* Re: PATCH] patch to generate warning when signed-of line in patch in not proper
@ 2011-05-21 19:38 anish
2011-05-21 19:52 ` Joe Perches
2011-05-22 10:18 ` [patch v2] checkpatch: Signature format verification anish
0 siblings, 2 replies; 33+ messages in thread
From: anish @ 2011-05-21 19:38 UTC (permalink / raw)
To: joe; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
On Sat, May 21, 2011 at 9:33 PM, Joe Perches <joe@perches.com> wrote:
On Sat, 2011-05-21 at 20:14 +0530, anish singh wrote:
> Re-sending to get some comments on this.
>
> On Thu, May 19, 2011 at 10:53 PM, anish <anish198519851985@gmail.com>
> wrote:
> From: anish kumar <anish198519851985@gmail.com>
>
> This patch generates warning when there is no space between
> the
> patch submitter name and successive mail-id.
>>If you do this, why not do it for all signature types?
>>our $Valid_Signatures "(?:Signed-off-by:|Reviewed-by:|Acked-by:)"
Definitely.Please check below modified patch.
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
> ---
> scripts/checkpatch.pl | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d867081..437c6d4 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1373,10 +1373,16 @@ sub process {
> WARN("Signed-off-by: is the
> preferred form\n" .
> $herecurr);
> }
> - if ($line =~ /^\s*signed-off-by:\S/i)
> {
> - WARN("space required after
> Signed-off-by:\n" .
>> if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) {
>> my $space_before = $1;
>> my $sign_off = $2;
>> my $space_after = $3;
>> my $email = $4;
>> if (defined $space_before && $space_before ne "") {
>> warning (no space before...)
>> }
>> if ($sign_off !~ /$Valid_Signature/) {
>> warning (signature case...)
>> }
>> if (!defined $space_after || $space_after ne " ") {
>> warning (need only one space after colon...)
>> }
>> if (!validate_email($4)) {
>> warning (bad email...)
Please check the below patch.
--------------------------------------------------------------------------
From: anish kumar <anish198519851985@gmail.com>
This patch generates warning when there is no space betweenthe patch
submitter name and successive mail-id.As suggested by
Joe Perches(joe@perches.com) that we can do this for
all signature types.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
scripts/checkpatch.pl | 38 ++++++++++++++++++++++++--------------
1 files changed, 24 insertions(+), 14 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..6d67a17 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -29,6 +29,8 @@ my $summary_file = 0;
my $root;
my %debug;
my $help = 0;
+my $sign;
+my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
sub help {
my ($exitcode) = @_;
@@ -1365,20 +1367,27 @@ sub process {
}
}
-#check the patch for a signoff:
- if ($line =~ /^\s*signed-off-by:/i) {
- # This is a signoff, if ugly, so do not double report.
- $signoff++;
- if (!($line =~ /^\s*Signed-off-by:/)) {
- WARN("Signed-off-by: is the preferred form\n" .
- $herecurr);
- }
- if ($line =~ /^\s*signed-off-by:\S/i) {
- WARN("space required after Signed-off-by:\n" .
- $herecurr);
- }
- }
-
+#check the patch for a signoff/Reviewed/Acked/Tested:
+ foreach $sign (@signs) {
+ if ($line =~ /^\s*$sign/i) {
+ # This is a signoff, if ugly, so do not double report.
+ $signoff++;
+ if (!($line =~ /^\s*$sign/)) {
+ WARN("$sign is the preferred form\n" .
+ $herecurr);
+ }
+ if ($line =~ /^\s*$sign(.*)/i) {
+ if($1 !~ /^\s*(\s[a-zA-Z]*.*)/i) {
+ WARN("Space required after $sign\n" .
+ $herecurr);
+ }
+ if($1 !~ /[\sa-zA-Z]+\s<.*>/i) {
+ WARN("Space required b/w Full Name & Mail-id:\n" .
+ $herecurr);
+ }
+ }
+ }
+}
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("patch seems to be corrupt (line wrapped?)\n" .
@@ -2964,3 +2973,4 @@ sub process {
return $clean;
}
+
--
1.7.0.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: PATCH] patch to generate warning when signed-of line in patch in not proper
2011-05-21 19:38 PATCH] patch to generate warning when signed-of line in patch in not proper anish
@ 2011-05-21 19:52 ` Joe Perches
2011-05-22 10:18 ` [patch v2] checkpatch: Signature format verification anish
1 sibling, 0 replies; 33+ messages in thread
From: Joe Perches @ 2011-05-21 19:52 UTC (permalink / raw)
To: anish; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
On Sun, 2011-05-22 at 01:08 +0530, anish wrote:
> On Sat, May 21, 2011 at 9:33 PM, Joe Perches <joe@perches.com> wrote:
> >>If you do this, why not do it for all signature types?
> >>our $Valid_Signatures "(?:Signed-off-by:|Reviewed-by:|Acked-by:)"
> Definitely.Please check below modified patch.
[]
> This patch generates warning when there is no space betweenthe patch
> submitter name and successive mail-id.As suggested by
> Joe Perches(joe@perches.com) that we can do this for
> all signature types.
Typos and spacing issues in commit message.
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +my $sign;
> +my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
[]
> +#check the patch for a signoff/Reviewed/Acked/Tested:
> + foreach $sign (@signs) {
It's inefficient to loop for this.
I think what I suggested is neater,
but what you're doing is OK.
Your email subject line should be more like:
[PATCH] checkpatch: More signature format verification
And when you revise patches, use some version number
in the [PATCH] block like:
[PATCH v2] checkpatch: etc...
cheers, Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* [patch v2] checkpatch: Signature format verification
2011-05-21 19:38 PATCH] patch to generate warning when signed-of line in patch in not proper anish
2011-05-21 19:52 ` Joe Perches
@ 2011-05-22 10:18 ` anish
2011-05-22 14:16 ` Joe Perches
2011-05-23 15:21 ` [patch v3] " anish
1 sibling, 2 replies; 33+ messages in thread
From: anish @ 2011-05-22 10:18 UTC (permalink / raw)
To: joe; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
From: anish kumar <anish198519851985@gmail.com>
This patch generates warning when there is no space between
the patch submitter and successive mail-id.
Modification:Suggested by Joe Perches(joe@perches.com) that
we can add this check for all signature types so added that
change and added logic to remove the inefficent looping so
that it can come out as soon as signature type is matched.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
scripts/checkpatch.pl | 30 +++++++++++++++++++++---------
1 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..0622f41 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -29,6 +29,8 @@ my $summary_file = 0;
my $root;
my %debug;
my $help = 0;
+my ($sign,$loop_brk);
+my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
sub help {
my ($exitcode) = @_;
@@ -1365,20 +1367,30 @@ sub process {
}
}
-#check the patch for a signoff:
- if ($line =~ /^\s*signed-off-by:/i) {
- # This is a signoff, if ugly, so do not double report.
- $signoff++;
- if (!($line =~ /^\s*Signed-off-by:/)) {
- WARN("Signed-off-by: is the preferred form\n" .
+#check the patch for a signoff/Reviewed/Acked/Tested:
+foreach $sign (@signs) {
+ $loop_brk=0;
+ if ($line =~ /^\s*$sign/i) {
+ # This is a signoff, if ugly, so do not double report.
+ $signoff++;
+ $loop_brk++;
+ if (!($line =~ /^\s*$sign/)) {
+ WARN("$sign is the preferred form\n" .
+ $herecurr);
+ }
+ if ($line =~ /^\s*$sign(.*)/i) {
+ if($1 !~ /^\s*(\s[a-zA-Z]*.*)/i) {
+ WARN("Space required after $sign\n" .
$herecurr);
}
- if ($line =~ /^\s*signed-off-by:\S/i) {
- WARN("space required after Signed-off-by:\n" .
+ if($1 !~ /[\sa-zA-Z]+\s<.*>/i) {
+ WARN("Space required b/w Full Name & Mail-id:\n" .
$herecurr);
}
}
-
+ }
+last if ($loop_brk == 1);
+}
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("patch seems to be corrupt (line wrapped?)\n" .
--
1.7.0.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [patch v2] checkpatch: Signature format verification
2011-05-22 10:18 ` [patch v2] checkpatch: Signature format verification anish
@ 2011-05-22 14:16 ` Joe Perches
[not found] ` <BANLkTimMPvn87E0EEqT4vhox4_8nQ4pMug@mail.gmail.com>
2011-05-23 15:21 ` [patch v3] " anish
1 sibling, 1 reply; 33+ messages in thread
From: Joe Perches @ 2011-05-22 14:16 UTC (permalink / raw)
To: anish; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
On Sun, 2011-05-22 at 15:48 +0530, anish wrote:
> This patch generates warning when there is no space between
> the patch submitter and successive mail-id.
[]
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d867081..0622f41 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -29,6 +29,8 @@ my $summary_file = 0;
> my $root;
> my %debug;
> my $help = 0;
> +my ($sign,$loop_brk);
These 2 variables don't need to be at this scope.
> @@ -1365,20 +1367,30 @@ sub process {
[]
> +#check the patch for a signoff/Reviewed/Acked/Tested:
> +foreach $sign (@signs) {
Please use the appropriate indentation or add a new function.
^ permalink raw reply [flat|nested] 33+ messages in thread
* [patch v3] checkpatch: Signature format verification
2011-05-22 10:18 ` [patch v2] checkpatch: Signature format verification anish
2011-05-22 14:16 ` Joe Perches
@ 2011-05-23 15:21 ` anish
2011-05-23 16:11 ` Joe Perches
2011-05-27 18:01 ` [patch v4] " anish
1 sibling, 2 replies; 33+ messages in thread
From: anish @ 2011-05-23 15:21 UTC (permalink / raw)
To: joe; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
From: anish kumar <anish198519851985@gmail.com>
This patch generates warning when there is no space between
the patch submitter and successive mail-id.
V2 Modification:Suggested by Joe Perches(joe@perches.com) that
we can add this check for all signature types so added that
change and added logic to remove the inefficent looping so
that it can come out as soon as signature type is matched.
V3 Modification:Moved the variable from global to local scope.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
scripts/checkpatch.pl | 36 ++++++++++++++++++++++++------------
1 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..fbc0e62 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1365,20 +1365,32 @@ sub process {
}
}
-#check the patch for a signoff:
- if ($line =~ /^\s*signed-off-by:/i) {
- # This is a signoff, if ugly, so do not double report.
- $signoff++;
- if (!($line =~ /^\s*Signed-off-by:/)) {
- WARN("Signed-off-by: is the preferred form\n" .
- $herecurr);
- }
- if ($line =~ /^\s*signed-off-by:\S/i) {
- WARN("space required after Signed-off-by:\n" .
- $herecurr);
+#check the patch for a signoff/Reviewed/Acked/Tested:
+ my ($sign,$loop_brk);
+ my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
+ foreach $sign (@signs) {
+ $loop_brk=0;
+ if ($line =~ /^\s*$sign/i) {
+ # This is a signoff, if ugly, so do not double report.
+ $signoff++;
+ $loop_brk++;
+ if (!($line =~ /^\s*$sign/)) {
+ WARN("$sign is the preferred form\n" .
+ $herecurr);
+ }
+ if ($line =~ /^\s*$sign(.*)/i) {
+ if($1 !~ /^\s*(\s[a-zA-Z]*.*)/i) {
+ WARN("Space required after $sign\n" .
+ $herecurr);
+ }
+ if($1 !~ /[\sa-zA-Z]+\s<.*>/i) {
+ WARN("Space required b/w Full Name & Mail-id:\n" .
+ $herecurr);
+ }
+ }
}
+ last if ($loop_brk == 1);
}
-
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("patch seems to be corrupt (line wrapped?)\n" .
--
1.7.0.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [patch v3] checkpatch: Signature format verification
2011-05-23 15:21 ` [patch v3] " anish
@ 2011-05-23 16:11 ` Joe Perches
[not found] ` <BANLkTi=9nzMbxU0=P+pOaHcebqhL=bd2HQ@mail.gmail.com>
2011-05-27 18:01 ` [patch v4] " anish
1 sibling, 1 reply; 33+ messages in thread
From: Joe Perches @ 2011-05-23 16:11 UTC (permalink / raw)
To: anish; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
On Mon, 2011-05-23 at 20:51 +0530, anish wrote:
> From: anish kumar <anish198519851985@gmail.com>
> This patch generates warning when there is no space between
> the patch submitter and successive mail-id.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> + if (!($line =~ /^\s*$sign/)) {
if ($line !~ /etc...)
> + WARN("$sign is the preferred form\n" .
> + $herecurr);
> + }
> + if ($line =~ /^\s*$sign(.*)/i) {
> + if($1 !~ /^\s*(\s[a-zA-Z]*.*)/i) {
Email addresses may start with a quote (") or a digit.
Space between if and (
> + WARN("Space required after $sign\n" .
> + $herecurr);
> + }
> + if($1 !~ /[\sa-zA-Z]+\s<.*>/i) {
Space between if and (
^ permalink raw reply [flat|nested] 33+ messages in thread
* [patch v4] checkpatch: Signature format verification
2011-05-23 15:21 ` [patch v3] " anish
2011-05-23 16:11 ` Joe Perches
@ 2011-05-27 18:01 ` anish
2011-05-27 18:16 ` Steven Rostedt
` (2 more replies)
1 sibling, 3 replies; 33+ messages in thread
From: anish @ 2011-05-27 18:01 UTC (permalink / raw)
To: joe; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
From: anish kumar <anish198519851985@gmail.com>
This patch generates warning when there is no space between
the patch submitter and successive mail-id.
V2 Modification:Suggested by Joe Perches(joe@perches.com) that
we can add this check for all signature types so added that
change and added logic to remove the inefficent looping so
that it can come out as soon as signature type is matched.
V3 Modification:Moved the variable from global to local scope.
v4 Suggested by Joe Perches(joe@perches.com) that names can
have many forms.8 bit chars,commas,quotes,apostrphes,all sort
of things.This is now taken care of.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
scripts/checkpatch.pl | 36 ++++++++++++++++++++++++------------
1 files changed, 24 insertions(+), 12 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..bf724c9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1365,20 +1365,32 @@ sub process {
}
}
-#check the patch for a signoff:
- if ($line =~ /^\s*signed-off-by:/i) {
- # This is a signoff, if ugly, so do not double report.
- $signoff++;
- if (!($line =~ /^\s*Signed-off-by:/)) {
- WARN("Signed-off-by: is the preferred form\n" .
- $herecurr);
- }
- if ($line =~ /^\s*signed-off-by:\S/i) {
- WARN("space required after Signed-off-by:\n" .
- $herecurr);
+#check the patch for a signoff/Reviewed/Acked/Tested:
+ my ($sign,$loop_brk);
+ my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
+ foreach $sign (@signs) {
+ $loop_brk=0;
+ if ($line =~ /^\s*$sign/i) {
+ # This is a signoff, if ugly, so do not double report.
+ $signoff++;
+ $loop_brk++;
+ if (!($line =~ /^\s*$sign/)) {
+ WARN("$sign is the preferred form\n" .
+ $herecurr);
+ }
+ if ($line =~ /^\s*$sign(.*)/i) {
+ if ($1 !~ /^\s+([a-zA-Z\s\"\.\-\'\,]*.*)/i) {
+ WARN("Space required after $sign\n" .
+ $herecurr);
+ }
+ if ($1 !~ /([\sa-zA-Z\"\.\-\'\,]*)\s<.*>/i) {
+ WARN("Space required b/w Full Name & Mail-id:\n" .
+ $herecurr);
+ }
+ }
}
+ last if ($loop_brk == 1);
}
-
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("patch seems to be corrupt (line wrapped?)\n" .
--
1.7.0.4
^ permalink raw reply related [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:01 ` [patch v4] " anish
@ 2011-05-27 18:16 ` Steven Rostedt
2011-05-27 18:18 ` Randy Dunlap
2011-05-27 18:45 ` Joe Perches
2011-05-27 18:29 ` Joe Perches
2011-05-27 22:14 ` Andrew Morton
2 siblings, 2 replies; 33+ messages in thread
From: Steven Rostedt @ 2011-05-27 18:16 UTC (permalink / raw)
To: anish; +Cc: joe, davej, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 2011-05-27 at 23:31 +0530, anish wrote:
> From: anish kumar <anish198519851985@gmail.com>
>
> + my ($sign,$loop_brk);
> + my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
> + foreach $sign (@signs) {
> + $loop_brk=0;
> + if ($line =~ /^\s*$sign/i) {
> + # This is a signoff, if ugly, so do not double report.
> + $signoff++;
> + $loop_brk++;
> + if (!($line =~ /^\s*$sign/)) {
> + WARN("$sign is the preferred form\n" .
> + $herecurr);
> + }
> + if ($line =~ /^\s*$sign(.*)/i) {
> + if ($1 !~ /^\s+([a-zA-Z\s\"\.\-\'\,]*.*)/i) {
> + WARN("Space required after $sign\n" .
> + $herecurr);
> + }
> + if ($1 !~ /([\sa-zA-Z\"\.\-\'\,]*)\s<.*>/i) {
> + WARN("Space required b/w Full Name & Mail-id:\n" .
What's "b/w" black and white?
Also do we check for <>. As the above will trigger for missing <> and
give a warning about spaces.
I once had my quilt mail send crap to LKML because one of the Cc's in a
patch I pulled was missing the ending ">".
-- Steve
> + $herecurr);
> + }
> + }
> }
> + last if ($loop_brk == 1);
> }
> -
> # Check for wrappage within a valid hunk of the file
> if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
> ERROR("patch seems to be corrupt (line wrapped?)\n" .
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:16 ` Steven Rostedt
@ 2011-05-27 18:18 ` Randy Dunlap
2011-05-27 18:45 ` Joe Perches
1 sibling, 0 replies; 33+ messages in thread
From: Randy Dunlap @ 2011-05-27 18:18 UTC (permalink / raw)
To: Steven Rostedt
Cc: anish, joe, davej, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 27 May 2011 14:16:57 -0400 Steven Rostedt wrote:
> On Fri, 2011-05-27 at 23:31 +0530, anish wrote:
> > From: anish kumar <anish198519851985@gmail.com>
> >
>
> > + my ($sign,$loop_brk);
> > + my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
> > + foreach $sign (@signs) {
> > + $loop_brk=0;
> > + if ($line =~ /^\s*$sign/i) {
> > + # This is a signoff, if ugly, so do not double report.
> > + $signoff++;
> > + $loop_brk++;
> > + if (!($line =~ /^\s*$sign/)) {
> > + WARN("$sign is the preferred form\n" .
> > + $herecurr);
> > + }
> > + if ($line =~ /^\s*$sign(.*)/i) {
> > + if ($1 !~ /^\s+([a-zA-Z\s\"\.\-\'\,]*.*)/i) {
> > + WARN("Space required after $sign\n" .
> > + $herecurr);
> > + }
> > + if ($1 !~ /([\sa-zA-Z\"\.\-\'\,]*)\s<.*>/i) {
> > + WARN("Space required b/w Full Name & Mail-id:\n" .
>
> What's "b/w" black and white?
I _think_ that it's "between", but I already requested that it
be changed. It's not good. :(
> Also do we check for <>. As the above will trigger for missing <> and
> give a warning about spaces.
>
> I once had my quilt mail send crap to LKML because one of the Cc's in a
> patch I pulled was missing the ending ">".
>
> -- Steve
>
> > + $herecurr);
> > + }
> > + }
> > }
> > + last if ($loop_brk == 1);
> > }
> > -
> > # Check for wrappage within a valid hunk of the file
> > if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
> > ERROR("patch seems to be corrupt (line wrapped?)\n" .
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:16 ` Steven Rostedt
2011-05-27 18:18 ` Randy Dunlap
@ 2011-05-27 18:45 ` Joe Perches
2011-05-27 18:58 ` Joe Perches
2011-05-27 19:22 ` Steven Rostedt
1 sibling, 2 replies; 33+ messages in thread
From: Joe Perches @ 2011-05-27 18:45 UTC (permalink / raw)
To: Steven Rostedt; +Cc: anish, davej, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 2011-05-27 at 14:16 -0400, Steven Rostedt wrote:
> I once had my quilt mail send crap to LKML because one of the Cc's in a
> patch I pulled was missing the ending ">".
I'm pretty sure I've done that using git-send-email
via bad copy/paste.
Actually, that one's been done a few times.
$ git log --pretty=oneline -E -i --grep "-by:.*<[^>]+$" | wc -l
129
But that's out of ~3.5 million non-merge commits.
cheers, Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:45 ` Joe Perches
@ 2011-05-27 18:58 ` Joe Perches
2011-05-27 19:22 ` Steven Rostedt
1 sibling, 0 replies; 33+ messages in thread
From: Joe Perches @ 2011-05-27 18:58 UTC (permalink / raw)
To: Steven Rostedt; +Cc: anish, davej, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 2011-05-27 at 11:45 -0700, Joe Perches wrote:
> But that's out of ~3.5 million non-merge commits.
Oops. Off by an order magnitude, stupid fingers.
$ git log --pretty=oneline --no-merges | wc -l
232816
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:45 ` Joe Perches
2011-05-27 18:58 ` Joe Perches
@ 2011-05-27 19:22 ` Steven Rostedt
2011-05-27 19:33 ` Joe Perches
1 sibling, 1 reply; 33+ messages in thread
From: Steven Rostedt @ 2011-05-27 19:22 UTC (permalink / raw)
To: Joe Perches; +Cc: anish, davej, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 2011-05-27 at 11:45 -0700, Joe Perches wrote:
> On Fri, 2011-05-27 at 14:16 -0400, Steven Rostedt wrote:
> > I once had my quilt mail send crap to LKML because one of the Cc's in a
> > patch I pulled was missing the ending ">".
>
> I'm pretty sure I've done that using git-send-email
> via bad copy/paste.
>
> Actually, that one's been done a few times.
>
> $ git log --pretty=oneline -E -i --grep "-by:.*<[^>]+$" | wc -l
> 129
>
> But that's out of 232816 non-merge commits.
Even so, it would have been nice, because I ended up sending a crap load
of emails to LKML without any content. I still use quilt as I like to
verify what I send. But it took a dump on the missing ">" and caused all
patches to be sent out as crap.
-- Steve
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 19:22 ` Steven Rostedt
@ 2011-05-27 19:33 ` Joe Perches
0 siblings, 0 replies; 33+ messages in thread
From: Joe Perches @ 2011-05-27 19:33 UTC (permalink / raw)
To: Steven Rostedt; +Cc: anish, davej, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 2011-05-27 at 15:22 -0400, Steven Rostedt wrote:
> On Fri, 2011-05-27 at 11:45 -0700, Joe Perches wrote:
> > On Fri, 2011-05-27 at 14:16 -0400, Steven Rostedt wrote:
> > > I once had my quilt mail send crap to LKML because one of the Cc's in a
> > > patch I pulled was missing the ending ">".
> > $ git log --pretty=oneline -E -i --grep "-by:.*<[^>]+$" | wc -l
> > 129
> > But that's out of 232816 non-merge commits.
> Even so, it would have been nice, because I ended up sending a crap load
> of emails to LKML without any content. I still use quilt as I like to
> verify what I send. But it took a dump on the missing ">" and caused all
> patches to be sent out as crap.
No doubt.
This concept should also verify the "To: " and "cc: " tag lines.
cheers, Joe
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:01 ` [patch v4] " anish
2011-05-27 18:16 ` Steven Rostedt
@ 2011-05-27 18:29 ` Joe Perches
[not found] ` <BANLkTikfh_ABGomn-Lm9Ugc7MzeRodwiEQ@mail.gmail.com>
2011-05-27 22:14 ` Andrew Morton
2 siblings, 1 reply; 33+ messages in thread
From: Joe Perches @ 2011-05-27 18:29 UTC (permalink / raw)
To: anish; +Cc: davej, rostedt, apw, akpm, vapier, linux-kernel, man.k1983
On Fri, 2011-05-27 at 23:31 +0530, anish wrote:
> From: anish kumar <anish198519851985@gmail.com>
[]
> v4 Suggested by Joe Perches(joe@perches.com) that names can
> have many forms.8 bit chars,commas,quotes,apostrphes,all sort
> of things.This is now taken care of.
NAK. No it's not.
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
[]
> + if ($line =~ /^\s*$sign(.*)/i) {
> + if ($1 !~ /^\s+([a-zA-Z\s\"\.\-\'\,]*.*)/i) {
> + WARN("Space required after $sign\n" .
> + $herecurr);
8 bit chars, digits?
> + }
> + if ($1 !~ /([\sa-zA-Z\"\.\-\'\,]*)\s<.*>/i) {
> + WARN("Space required b/w Full Name & Mail-id:\n" .
> + $herecurr);
For the 3rd time, please use this form:
if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) {
and if you really want email format validation,
use a separate function.
^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [patch v4] checkpatch: Signature format verification
2011-05-27 18:01 ` [patch v4] " anish
2011-05-27 18:16 ` Steven Rostedt
2011-05-27 18:29 ` Joe Perches
@ 2011-05-27 22:14 ` Andrew Morton
2 siblings, 0 replies; 33+ messages in thread
From: Andrew Morton @ 2011-05-27 22:14 UTC (permalink / raw)
To: anish; +Cc: joe, davej, rostedt, apw, vapier, linux-kernel, man.k1983
On Fri, 27 May 2011 23:31:51 +0530
anish <anish198519851985@gmail.com> wrote:
> This patch generates warning when there is no space between
> the patch submitter and successive mail-id.
I don't even know what this means :( Please modify the changelog to
include a complete example of the offending input and of the generated
warning.
^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2011-05-28 1:42 UTC | newest]
Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-21 19:38 PATCH] patch to generate warning when signed-of line in patch in not proper anish
2011-05-21 19:52 ` Joe Perches
2011-05-22 10:18 ` [patch v2] checkpatch: Signature format verification anish
2011-05-22 14:16 ` Joe Perches
[not found] ` <BANLkTimMPvn87E0EEqT4vhox4_8nQ4pMug@mail.gmail.com>
2011-05-23 4:14 ` Joe Perches
2011-05-23 16:22 ` Steven Rostedt
2011-05-23 16:30 ` Joe Perches
2011-05-23 15:21 ` [patch v3] " anish
2011-05-23 16:11 ` Joe Perches
[not found] ` <BANLkTi=9nzMbxU0=P+pOaHcebqhL=bd2HQ@mail.gmail.com>
2011-05-23 16:36 ` Joe Perches
2011-05-23 16:39 ` Randy Dunlap
2011-05-23 16:42 ` Joe Perches
[not found] ` <BANLkTik8coVxt=Z92NQBNH_=4yRhTtexzA@mail.gmail.com>
2011-05-23 17:07 ` Randy Dunlap
2011-05-23 17:18 ` Joe Perches
[not found] ` <BANLkTikqezyJMy1_i-woTVM9bvVL750iew@mail.gmail.com>
2011-05-23 18:09 ` Joe Perches
2011-05-23 22:51 ` Mike Frysinger
2011-05-24 1:24 ` Valdis.Kletnieks
2011-05-24 1:31 ` Mike Frysinger
2011-05-24 4:44 ` Randy Dunlap
2011-05-27 18:01 ` [patch v4] " anish
2011-05-27 18:16 ` Steven Rostedt
2011-05-27 18:18 ` Randy Dunlap
2011-05-27 18:45 ` Joe Perches
2011-05-27 18:58 ` Joe Perches
2011-05-27 19:22 ` Steven Rostedt
2011-05-27 19:33 ` Joe Perches
2011-05-27 18:29 ` Joe Perches
[not found] ` <BANLkTikfh_ABGomn-Lm9Ugc7MzeRodwiEQ@mail.gmail.com>
2011-05-27 19:08 ` Joe Perches
[not found] ` <BANLkTi=JK+XS2D0exj=unjpjGCsnVncCzQ@mail.gmail.com>
2011-05-27 19:33 ` Joe Perches
[not found] ` <BANLkTi=dsYi3ViZdpGdagxzhzDRuRVL_+A@mail.gmail.com>
2011-05-27 20:18 ` Steven Rostedt
2011-05-27 20:37 ` Joe Perches
[not found] ` <BANLkTi=VuLpdAf3Qo3mo_nQ03yHazeHf+g@mail.gmail.com>
2011-05-28 1:42 ` Joe Perches
2011-05-27 22:14 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.