From: Artem Bityutskiy <dedekind1@gmail.com> To: david.wagner@free-electrons.com Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] UBI: new module ubiblk: block layer on top of UBI Date: Mon, 27 Jun 2011 22:26:08 +0300 [thread overview] Message-ID: <1309202771.24805.11.camel@koala> (raw) In-Reply-To: <1308922482-14967-2-git-send-email-david.wagner@free-electrons.com> On Fri, 2011-06-24 at 15:34 +0200, david.wagner@free-electrons.com wrote: > + /* Stolen from mtd_blkdevs.c */ > + /* Create processing thread */ > + dev->thread = kthread_run(ubi_ubiblk_thread, dev, "%s%d_%d", > + "kubiblkd", dev->ubi_num, dev->vol_id); > + if (IS_ERR(dev->thread)) { > + ret = PTR_ERR(dev->thread); > + goto out_thread; > + } Why we need a kernel thread? Could you please describe when exactly it is needed and why we cannot avoid having it? > + ret = register_blkdev(0, "ubiblk"); > + if (ret <= 0) { > + pr_err("UBIBLK: could not register_blkdev\n"); > + return -ENODEV; > + } > + major = ret; > + pr_info("UBIBLK: device's major: %d\n", major); > + > + mutex_init(&devtable_lock); > + ret = ubi_register_volume_notifier(&ubiblk_notifier, 0); > + if (ret < 0) > + return ret; You should probably de-register the blkdev when you fail here. -- Best Regards, Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com> To: david.wagner@free-electrons.com Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] UBI: new module ubiblk: block layer on top of UBI Date: Mon, 27 Jun 2011 22:26:08 +0300 [thread overview] Message-ID: <1309202771.24805.11.camel@koala> (raw) In-Reply-To: <1308922482-14967-2-git-send-email-david.wagner@free-electrons.com> On Fri, 2011-06-24 at 15:34 +0200, david.wagner@free-electrons.com wrote: > + /* Stolen from mtd_blkdevs.c */ > + /* Create processing thread */ > + dev->thread = kthread_run(ubi_ubiblk_thread, dev, "%s%d_%d", > + "kubiblkd", dev->ubi_num, dev->vol_id); > + if (IS_ERR(dev->thread)) { > + ret = PTR_ERR(dev->thread); > + goto out_thread; > + } Why we need a kernel thread? Could you please describe when exactly it is needed and why we cannot avoid having it? > + ret = register_blkdev(0, "ubiblk"); > + if (ret <= 0) { > + pr_err("UBIBLK: could not register_blkdev\n"); > + return -ENODEV; > + } > + major = ret; > + pr_info("UBIBLK: device's major: %d\n", major); > + > + mutex_init(&devtable_lock); > + ret = ubi_register_volume_notifier(&ubiblk_notifier, 0); > + if (ret < 0) > + return ret; You should probably de-register the blkdev when you fail here. -- Best Regards, Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2011-06-27 19:26 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-24 13:34 [RFC] ubiblk: read-only block layer on top of UBI david.wagner 2011-06-24 13:34 ` david.wagner 2011-06-24 13:34 ` [PATCH] UBI: new module ubiblk: " david.wagner 2011-06-24 13:34 ` david.wagner 2011-06-27 19:26 ` Artem Bityutskiy [this message] 2011-06-27 19:26 ` Artem Bityutskiy 2011-06-28 11:35 ` David Wagner 2011-06-28 11:35 ` David Wagner 2011-06-29 6:52 ` Artem Bityutskiy 2011-06-29 6:52 ` Artem Bityutskiy 2011-06-28 14:50 ` Matthieu CASTET 2011-06-28 14:50 ` Matthieu CASTET 2011-06-28 15:32 ` David Wagner 2011-06-28 15:32 ` David Wagner 2011-06-29 6:25 ` Artem Bityutskiy 2011-06-29 6:25 ` Artem Bityutskiy 2011-06-24 13:45 ` [Addendum][RFC] ubiblk: read-only " David Wagner 2011-06-27 19:14 ` [RFC] " Artem Bityutskiy 2011-06-27 19:14 ` Artem Bityutskiy 2011-06-28 15:24 ` [RFC PATCHv2] UBI: new module ubiblk: " david.wagner 2011-06-28 15:24 ` david.wagner 2011-06-28 15:24 ` david.wagner 2011-06-29 6:54 ` Artem Bityutskiy 2011-06-29 6:54 ` Artem Bityutskiy 2011-07-26 12:27 ` [PATCH] " David Wagner 2011-07-26 12:27 ` David Wagner 2011-07-26 12:34 ` Christoph Hellwig 2011-07-26 12:34 ` Christoph Hellwig 2011-07-26 12:34 ` Christoph Hellwig 2011-07-26 12:58 ` David Wagner 2011-07-26 12:58 ` David Wagner 2011-07-28 6:14 ` Artem Bityutskiy 2011-07-28 6:14 ` Artem Bityutskiy 2011-08-15 11:56 ` Artem Bityutskiy 2011-08-15 11:56 ` Artem Bityutskiy 2011-08-17 13:17 ` [PATCHv3] " david.wagner 2011-08-17 13:17 ` david.wagner 2011-08-17 14:20 ` [PATCH] Tools for controling ubiblk David Wagner 2011-08-17 14:20 ` David Wagner 2011-08-22 8:17 ` Artem Bityutskiy 2011-08-22 8:17 ` Artem Bityutskiy 2011-08-22 7:39 ` [PATCHv3] UBI: new module ubiblk: block layer on top of UBI Artem Bityutskiy 2011-08-22 7:39 ` Artem Bityutskiy 2011-08-22 7:42 ` Artem Bityutskiy 2011-08-22 7:42 ` Artem Bityutskiy 2011-08-24 16:23 ` Arnd Bergmann 2011-08-24 16:23 ` Arnd Bergmann 2011-08-25 7:06 ` Artem Bityutskiy 2011-08-25 7:06 ` Artem Bityutskiy 2011-08-25 15:12 ` Arnd Bergmann 2011-08-25 15:12 ` Arnd Bergmann 2011-08-25 15:12 ` Arnd Bergmann 2011-09-01 12:55 ` David Wagner 2011-09-01 12:55 ` David Wagner 2011-09-01 12:55 ` David Wagner 2011-09-06 3:44 ` Artem Bityutskiy 2011-09-06 3:44 ` Artem Bityutskiy 2011-09-06 4:10 ` Artem Bityutskiy 2011-09-06 4:10 ` Artem Bityutskiy 2011-09-06 4:10 ` Artem Bityutskiy 2011-09-06 4:29 ` Artem Bityutskiy 2011-09-06 4:29 ` Artem Bityutskiy 2011-09-08 15:26 ` Arnd Bergmann 2011-09-08 15:26 ` Arnd Bergmann 2011-09-08 15:26 ` Arnd Bergmann 2011-09-09 11:53 ` Artem Bityutskiy 2011-09-09 11:53 ` Artem Bityutskiy 2011-09-09 12:02 ` Artem Bityutskiy 2011-09-09 12:02 ` Artem Bityutskiy 2011-09-09 14:25 ` Arnd Bergmann 2011-09-09 14:25 ` Arnd Bergmann 2011-09-09 15:27 ` Artem Bityutskiy 2011-09-09 15:27 ` Artem Bityutskiy 2011-09-09 14:41 ` David Wagner 2011-09-09 14:41 ` David Wagner 2011-09-09 14:41 ` David Wagner 2011-09-09 14:51 ` Arnd Bergmann 2011-09-09 14:51 ` Arnd Bergmann 2011-09-11 10:18 ` Artem Bityutskiy 2011-09-11 10:18 ` Artem Bityutskiy 2011-09-11 10:18 ` Artem Bityutskiy 2011-09-11 10:35 ` David Wagner 2011-09-11 10:35 ` David Wagner 2011-08-24 16:15 ` [PATCHv4] " david.wagner 2011-08-24 16:15 ` david.wagner 2011-08-24 16:21 ` [PATCH] document ubiblk's usage of the same ioctl magic as a part " David Wagner 2011-08-24 16:21 ` David Wagner 2011-09-06 4:58 ` Artem Bityutskiy 2011-09-06 4:58 ` Artem Bityutskiy 2011-09-06 4:55 ` [PATCHv4] UBI: new module ubiblk: block layer on top " Artem Bityutskiy 2011-09-06 4:55 ` Artem Bityutskiy 2011-09-12 9:51 ` [PATCHv5] " David Wagner 2011-09-12 9:51 ` David Wagner 2011-09-12 9:51 ` David Wagner 2011-09-19 4:50 ` Artem Bityutskiy 2011-09-19 4:50 ` Artem Bityutskiy 2011-09-22 7:58 ` [PATCHv6] " David Wagner 2011-09-22 7:58 ` David Wagner 2011-09-23 10:58 ` Artem Bityutskiy 2011-09-23 10:58 ` Artem Bityutskiy 2011-09-26 12:58 ` David Wagner 2011-09-26 12:58 ` David Wagner 2011-09-26 9:17 ` Ricard Wanderlof 2011-09-26 9:17 ` Ricard Wanderlof 2011-09-26 9:17 ` Ricard Wanderlof 2011-09-26 12:11 ` Ricard Wanderlof 2011-09-26 12:38 ` [PATCHv7] " David Wagner 2011-09-26 12:38 ` David Wagner 2011-09-26 13:20 ` Artem Bityutskiy 2011-09-26 13:20 ` Artem Bityutskiy 2011-09-26 14:25 ` [PATCHv8] " David Wagner 2011-09-26 14:25 ` David Wagner 2011-09-26 14:36 ` Artem Bityutskiy 2011-09-26 14:36 ` Artem Bityutskiy 2011-09-26 14:40 ` [PATCHv9] " David Wagner 2011-09-26 14:40 ` David Wagner 2011-10-01 14:08 ` Artem Bityutskiy 2011-10-01 14:08 ` Artem Bityutskiy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1309202771.24805.11.camel@koala \ --to=dedekind1@gmail.com \ --cc=david.wagner@free-electrons.com \ --cc=dwmw2@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.