From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 09/10] x86 tune inc files: add x32 abi tune parameters
Date: Thu, 04 Aug 2011 22:57:12 +0100 [thread overview]
Message-ID: <1312495032.3169.6.camel@lenovo.internal.reciva.com> (raw)
In-Reply-To: <2c351319afd13acfca1283104172729925cfb696.1312469790.git.nitin.a.kamble@intel.com>
On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> # ELF32 ABI
> TUNEVALID[m32] = "IA32 ELF32 standard ABI"
> -TUNECONFLICTS[m32] = "m64"
> +TUNECONFLICTS[m32] = "m64 mx32"
> TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m32", "${X86ARCH32}", "" ,d)}"
> +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m32", "32", "" ,d)}"
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m32", "-m32", "", d)}"
This is going to cause TARGET_OS to change for everyone using the i586
ABI, right? That doesn't seem like it is either necessary or desirable,
and it isn't mentioned in the checkin comment either.
> # ELF64 ABI
> TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI"
> -TUNECONFLICT[m64] = "m32"
> +TUNECONFLICT[m64] = "m32 mx32"
> TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m64", "${X86ARCH64}", "" ,d)}"
> +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m64", "64", "" ,d)}"
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m64", "-m64", "", d)}"
... and likewise this for anybody using the x86-64 ABI.
> -PACKAGE_EXTRA_ARCHS_tune-x86-64 = "x86_64"
> +PACKAGE_EXTRA_ARCHS_tune-x86-64 = "x86-64"
That change might well be fine, but again it isn't mentioned in the
checkin message.
> diff --git a/meta/conf/machine/include/tune-x86_64.inc b/meta/conf/machine/include/tune-x86_64.inc
> index 04b0f96..50f20ba 100644
> --- a/meta/conf/machine/include/tune-x86_64.inc
> +++ b/meta/conf/machine/include/tune-x86_64.inc
> @@ -1,3 +1,3 @@
> require conf/machine/include/ia32/arch-ia32.inc
>
> -DEFAULTTUNE = "x86-64"
> +DEFAULTTUNE ?= "x86-64"
This one is also not mentioned in the checkin message and looks a bit
more dubious to me. Why is this required?
p.
next prev parent reply other threads:[~2011-08-04 22:01 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 15:01 [PATCH 00/10] Commits to enable x32 infrastructure nitin.a.kamble
2011-08-04 15:01 ` [PATCH 01/10] kern-tools: extend arbitrary repository support nitin.a.kamble
2011-08-05 4:09 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 02/10] linux-yocto: process the existing branch for configuration nitin.a.kamble
2011-08-05 4:11 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 03/10] linux-yocto: pass KMACHINE to updateme, not MACHINE nitin.a.kamble
2011-08-05 4:10 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 04/10] glibc: bring back the needed support for glibc recipes nitin.a.kamble
2011-08-04 21:50 ` Phil Blundell
2011-08-04 22:04 ` Kamble, Nitin A
2011-08-04 22:10 ` Phil Blundell
2011-08-04 22:47 ` Kamble, Nitin A
2011-08-04 22:49 ` Tom Rini
2011-08-04 22:57 ` Kamble, Nitin A
2011-08-05 15:49 ` Richard Purdie
2011-08-04 23:33 ` Khem Raj
2011-08-04 22:48 ` Tom Rini
2011-08-04 22:58 ` Kamble, Nitin A
2011-08-04 23:39 ` Khem Raj
2011-08-04 23:18 ` Khem Raj
2011-08-05 1:09 ` Kamble, Nitin A
2011-08-05 15:52 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 05/10] toolchain-scripts & other classes: add TARGET_LD_ARCH & TARGET_AS_ARCH vars nitin.a.kamble
2011-08-05 16:09 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 06/10] kernel, module-base.bbclass: fix KERNEL_LD & KERNEL_AR vars nitin.a.kamble
2011-08-04 21:50 ` Phil Blundell
2011-08-04 22:03 ` Kamble, Nitin A
2011-08-05 7:52 ` Phil Blundell
2011-08-05 15:41 ` Kamble, Nitin A
2011-08-05 16:16 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 07/10] siteinfo.bbclass: add entries for new x86_64 ABI targets nitin.a.kamble
2011-08-04 22:51 ` Tom Rini
2011-08-04 22:54 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 08/10] insane.bbclass: add entries for linux-gnu<ABI> nitin.a.kamble
2011-08-05 16:06 ` Richard Purdie
2011-08-05 16:56 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 09/10] x86 tune inc files: add x32 abi tune parameters nitin.a.kamble
2011-08-04 21:57 ` Phil Blundell [this message]
2011-08-04 22:18 ` Kamble, Nitin A
2011-08-04 22:29 ` Kamble, Nitin A
2011-08-05 7:50 ` Phil Blundell
2011-08-05 15:37 ` Kamble, Nitin A
2011-08-05 15:41 ` Phil Blundell
2011-08-05 15:44 ` Richard Purdie
2011-08-05 15:49 ` Phil Blundell
2011-08-05 16:04 ` Richard Purdie
2011-08-05 18:07 ` Kamble, Nitin A
2011-08-05 21:23 ` Saul Wold
2011-08-05 23:25 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 10/10] local.conf.sample: make BBMASK assignment weak nitin.a.kamble
2011-08-04 22:52 ` Tom Rini
2011-08-04 22:54 ` Kamble, Nitin A
2011-08-05 16:07 ` Richard Purdie
2011-08-05 16:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312495032.3169.6.camel@lenovo.internal.reciva.com \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.