From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 09/10] x86 tune inc files: add x32 abi tune parameters
Date: Fri, 05 Aug 2011 08:50:54 +0100 [thread overview]
Message-ID: <1312530654.3169.12.camel@lenovo.internal.reciva.com> (raw)
In-Reply-To: <9DA5872FEF993D41B7173F58FCF6BE94DE85F4F7@orsmsx504.amr.corp.intel.com>
On Thu, 2011-08-04 at 15:18 -0700, Kamble, Nitin A wrote:
>
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Phil Blundell
> > Sent: Thursday, August 04, 2011 2:57 PM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 09/10] x86 tune inc files: add x32 abi
> > tune parameters
> >
> > On Thu, 2011-08-04 at 08:01 -0700, nitin.a.kamble@intel.com wrote:
> > > # ELF32 ABI
> > > TUNEVALID[m32] = "IA32 ELF32 standard ABI"
> > > -TUNECONFLICTS[m32] = "m64"
> > > +TUNECONFLICTS[m32] = "m64 mx32"
> > > TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m32",
> > "${X86ARCH32}", "" ,d)}"
> > > +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m32", "32",
> > "" ,d)}"
> > > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m32", "-m32",
> > "", d)}"
> >
> > This is going to cause TARGET_OS to change for everyone using the i586
> > ABI, right? That doesn't seem like it is either necessary or
> > desirable,
> > and it isn't mentioned in the checkin comment either.
>
> Correct, this will change the TARGET_OS from linux_gnu to linux_gnu32. And it is also applicable for x86-64 machine set with x86 tune. This change is be needed if multiple tunes are built from the same build directory. If such situation is not important then the ABIEXTENSION part can be dropped.
Well, if you build i686 and x32 in the same tree they will already be
disambiguated through TARGET_ARCH. Likewise i686 and x86-64 already
works for the same reason. So, the only possible conflict is between
x86-64 and x32, and setting ABIEXTENSION for x32 (only) would be
sufficient to avoid that.
Though, I do wonder whether x32 ought to just have its own TARGET_ARCH
value rather than trying to disambiguate it through TARGET_OS hackery.
p.
next prev parent reply other threads:[~2011-08-05 7:55 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 15:01 [PATCH 00/10] Commits to enable x32 infrastructure nitin.a.kamble
2011-08-04 15:01 ` [PATCH 01/10] kern-tools: extend arbitrary repository support nitin.a.kamble
2011-08-05 4:09 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 02/10] linux-yocto: process the existing branch for configuration nitin.a.kamble
2011-08-05 4:11 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 03/10] linux-yocto: pass KMACHINE to updateme, not MACHINE nitin.a.kamble
2011-08-05 4:10 ` Bruce Ashfield
2011-08-04 15:01 ` [PATCH 04/10] glibc: bring back the needed support for glibc recipes nitin.a.kamble
2011-08-04 21:50 ` Phil Blundell
2011-08-04 22:04 ` Kamble, Nitin A
2011-08-04 22:10 ` Phil Blundell
2011-08-04 22:47 ` Kamble, Nitin A
2011-08-04 22:49 ` Tom Rini
2011-08-04 22:57 ` Kamble, Nitin A
2011-08-05 15:49 ` Richard Purdie
2011-08-04 23:33 ` Khem Raj
2011-08-04 22:48 ` Tom Rini
2011-08-04 22:58 ` Kamble, Nitin A
2011-08-04 23:39 ` Khem Raj
2011-08-04 23:18 ` Khem Raj
2011-08-05 1:09 ` Kamble, Nitin A
2011-08-05 15:52 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 05/10] toolchain-scripts & other classes: add TARGET_LD_ARCH & TARGET_AS_ARCH vars nitin.a.kamble
2011-08-05 16:09 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 06/10] kernel, module-base.bbclass: fix KERNEL_LD & KERNEL_AR vars nitin.a.kamble
2011-08-04 21:50 ` Phil Blundell
2011-08-04 22:03 ` Kamble, Nitin A
2011-08-05 7:52 ` Phil Blundell
2011-08-05 15:41 ` Kamble, Nitin A
2011-08-05 16:16 ` Richard Purdie
2011-08-04 15:01 ` [PATCH 07/10] siteinfo.bbclass: add entries for new x86_64 ABI targets nitin.a.kamble
2011-08-04 22:51 ` Tom Rini
2011-08-04 22:54 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 08/10] insane.bbclass: add entries for linux-gnu<ABI> nitin.a.kamble
2011-08-05 16:06 ` Richard Purdie
2011-08-05 16:56 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 09/10] x86 tune inc files: add x32 abi tune parameters nitin.a.kamble
2011-08-04 21:57 ` Phil Blundell
2011-08-04 22:18 ` Kamble, Nitin A
2011-08-04 22:29 ` Kamble, Nitin A
2011-08-05 7:50 ` Phil Blundell [this message]
2011-08-05 15:37 ` Kamble, Nitin A
2011-08-05 15:41 ` Phil Blundell
2011-08-05 15:44 ` Richard Purdie
2011-08-05 15:49 ` Phil Blundell
2011-08-05 16:04 ` Richard Purdie
2011-08-05 18:07 ` Kamble, Nitin A
2011-08-05 21:23 ` Saul Wold
2011-08-05 23:25 ` Kamble, Nitin A
2011-08-04 15:01 ` [PATCH 10/10] local.conf.sample: make BBMASK assignment weak nitin.a.kamble
2011-08-04 22:52 ` Tom Rini
2011-08-04 22:54 ` Kamble, Nitin A
2011-08-05 16:07 ` Richard Purdie
2011-08-05 16:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312530654.3169.12.camel@lenovo.internal.reciva.com \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.