From: Johannes Berg <johannes@sipsolutions.net>
To: Thomas Pedersen <thomas@cozybit.com>
Cc: linux-wireless@vger.kernel.org, jirislaby@gmail.com,
mickflemm@gmail.com, lrodriguez@atheros.com, me@bobcopeland.com,
Javier Cardona <javier@cozybit.com>
Subject: Re: [PATCH] ath5k: Invoke irqsafe version of ieee80211_tx_status() to avoid deadlock
Date: Tue, 30 Aug 2011 14:21:07 +0200 [thread overview]
Message-ID: <1314706867.4011.25.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1314236064-6339-1-git-send-email-thomas@cozybit.com> (sfid-20110825_033444_439163_B9A65422)
On Wed, 2011-08-24 at 18:34 -0700, Thomas Pedersen wrote:
> From: Javier Cardona <javier@cozybit.com>
>
> This driver reports transmission status to the upper layer
> (ath5k_tx_frame_completed()) while holding the lock on the transmission
> queue (txq->lock). Under failure conditions, the mesh stack will
> attempt to send PERR messages to the previous sender of the failed
> frame.
I'd feel a lot more comfortable if the mesh stack didn't do that. I
suppose it could use ieee80211_add_pending_skb() instead?
johannes
next prev parent reply other threads:[~2011-08-30 12:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 1:34 [PATCH] ath5k: Invoke irqsafe version of ieee80211_tx_status() to avoid deadlock Thomas Pedersen
2011-08-25 9:48 ` Bob Copeland
2011-08-26 14:22 ` John W. Linville
2011-08-29 2:07 ` Thomas Pedersen
2011-08-29 14:09 ` Bob Copeland
2011-08-29 18:13 ` Thomas Pedersen
2011-08-30 11:50 ` Bob Copeland
2011-08-30 12:18 ` Johannes Berg
2011-08-30 12:21 ` Johannes Berg [this message]
2011-08-30 16:22 ` Javier Cardona
2011-08-30 18:29 ` [PATCH] mac80211: Defer tranmission of mesh path errors Javier Cardona
2011-08-30 18:43 ` Johannes Berg
2011-08-30 21:38 ` Javier Cardona
2011-08-31 1:50 ` Javier Cardona
2011-08-31 5:11 ` Johannes Berg
2011-09-01 17:04 ` Javier Cardona
2011-09-01 17:04 ` [PATCH v2] " Javier Cardona
2011-09-02 10:59 ` Johannes Berg
2011-09-06 19:10 ` [PATCH v3] " Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314706867.4011.25.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=javier@cozybit.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.