From: Javier Cardona <javier@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Thomas Pedersen <thomas@cozybit.com>,
devel@lists.open80211s.org, linux-wireless@vger.kernel.org,
jlopex@gmail.com
Subject: Re: [PATCH] mac80211: Defer tranmission of mesh path errors
Date: Tue, 30 Aug 2011 18:50:25 -0700 [thread overview]
Message-ID: <CAPjQAd-CLvvn_1efsC_FjgoPSkyxiXC3c9yDGFzgPC4ts9Ay3w@mail.gmail.com> (raw)
In-Reply-To: <CAPjQAd9Fyu-MQSvi+aa4VwwWBTo_Brf=jCvAEnLdQZaJvjvu=Q@mail.gmail.com>
On Tue, Aug 30, 2011 at 2:38 PM, Javier Cardona <javier@cozybit.com> wrote:
> On Tue, Aug 30, 2011 at 11:43 AM, Johannes Berg
>> But that's not a big thing. Have you tested it? I'm wondering if because
>> we take a lock here we might run into lock dependencies issues (lockdep
>> would say) but I don't think so because stop_queue etc. all take the
>> same lock from an arbitrary driver context already.
>
> We don't have a test specific for that particular perr. Other tests
> run fine and lockdep does not complain.
> I can resubmit the patch with the clearer comment once we've run our
> whole test suite if that gives you peace of mind.
The stress tests do trigger perrs and, with this change, we see a
warning due to missing info->control.vif
[14202.988077] ------------[ cut here ]------------
[14202.988351] WARNING: at net/mac80211/util.c:358
ieee80211_add_pending_skb+0x97/0xa0()
[14202.988353] Hardware name: Bochs
[14202.988355] Modules linked in: mac80211_hwsim [last unloaded: mac80211_hwsim]
[14202.988359] Pid: 15051, comm: iperf Tainted: G W 3.1.0-rc4-wl+ #47
[14202.988361] Call Trace:
[14202.988364] [<c103ad2d>] warn_slowpath_common+0x6d/0xa0
[14202.988367] [<c15fbca7>] ? ieee80211_add_pending_skb+0x97/0xa0
[14202.988370] [<c15fbca7>] ? ieee80211_add_pending_skb+0x97/0xa0
[14202.988373] [<c103ad7d>] warn_slowpath_null+0x1d/0x20
[14202.988376] [<c15fbca7>] ieee80211_add_pending_skb+0x97/0xa0
[14202.988379] [<c1605ab1>] mesh_path_error_tx+0x151/0x190
[14202.988382] [<c160362b>] mesh_path_discard_frame+0xfb/0x100
[14202.988385] [<c1603580>] ? mesh_path_discard_frame+0x50/0x100
[14202.988387] [<c1605dd7>] mesh_nexthop_lookup+0x157/0x1d0
[14202.988390] [<c1605c80>] ? mesh_queue_preq+0x190/0x190
[14202.988393] [<c15f826a>] ieee80211_xmit+0x10a/0x240
[14202.988395] [<c15f8160>] ? ieee80211_tx+0xe0/0xe0
[14202.988398] [<c15f5c3a>] ? ieee80211_skb_resize+0x7a/0x100
[14202.988401] [<c15f8ba7>] ieee80211_subif_start_xmit+0x307/0x810
[14202.988404] [<c15f8cf8>] ? ieee80211_subif_start_xmit+0x458/0x810
I'll look into it tomorrow.
Cheers,
j
--
Javier Cardona
cozybit Inc.
http://www.cozybit.com
next prev parent reply other threads:[~2011-08-31 1:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 1:34 [PATCH] ath5k: Invoke irqsafe version of ieee80211_tx_status() to avoid deadlock Thomas Pedersen
2011-08-25 9:48 ` Bob Copeland
2011-08-26 14:22 ` John W. Linville
2011-08-29 2:07 ` Thomas Pedersen
2011-08-29 14:09 ` Bob Copeland
2011-08-29 18:13 ` Thomas Pedersen
2011-08-30 11:50 ` Bob Copeland
2011-08-30 12:18 ` Johannes Berg
2011-08-30 12:21 ` Johannes Berg
2011-08-30 16:22 ` Javier Cardona
2011-08-30 18:29 ` [PATCH] mac80211: Defer tranmission of mesh path errors Javier Cardona
2011-08-30 18:43 ` Johannes Berg
2011-08-30 21:38 ` Javier Cardona
2011-08-31 1:50 ` Javier Cardona [this message]
2011-08-31 5:11 ` Johannes Berg
2011-09-01 17:04 ` Javier Cardona
2011-09-01 17:04 ` [PATCH v2] " Javier Cardona
2011-09-02 10:59 ` Johannes Berg
2011-09-06 19:10 ` [PATCH v3] " Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPjQAd-CLvvn_1efsC_FjgoPSkyxiXC3c9yDGFzgPC4ts9Ay3w@mail.gmail.com \
--to=javier@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=jlopex@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.