From: Javier Cardona <javier@cozybit.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Javier Cardona <javier@cozybit.com>,
Thomas Pedersen <thomas@cozybit.com>,
devel@lists.open80211s.org,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, jlopex@gmail.com
Subject: Re: [PATCH] mac80211: Defer tranmission of mesh path errors
Date: Thu, 1 Sep 2011 10:04:44 -0700 [thread overview]
Message-ID: <1314896685-2932-1-git-send-email-javier@cozybit.com> (raw)
In-Reply-To: <1314767494.4161.2.camel@jlt3.sipsolutions.net>
On Tue, Aug 30, 2011 at 10:11 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2011-08-30 at 18:50 -0700, Javier Cardona wrote:
>
>> The stress tests do trigger perrs and, with this change, we see a
>> warning due to missing info->control.vif
>>
>> [14202.988077] ------------[ cut here ]------------
>> [14202.988351] WARNING: at net/mac80211/util.c:358
>> ieee80211_add_pending_skb+0x97/0xa0()
>
> Interesting. Ok, that means we can't just use add_pending_skb(), we need
> to do some setup before, all the setup that ieee80211_tx_skb() and
> ieee80211_xmit() would do up to ieee80211_tx()...
>
> I guess we need a little bit of helper code to enable this.
The patch that follows seems to do it. Passes our stress test without
warnings. I increased the headroom on allocation to avoid a resize. Does it
look correct to you?
Cheers,
Javier
--
1.7.6
next prev parent reply other threads:[~2011-09-01 17:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 1:34 [PATCH] ath5k: Invoke irqsafe version of ieee80211_tx_status() to avoid deadlock Thomas Pedersen
2011-08-25 9:48 ` Bob Copeland
2011-08-26 14:22 ` John W. Linville
2011-08-29 2:07 ` Thomas Pedersen
2011-08-29 14:09 ` Bob Copeland
2011-08-29 18:13 ` Thomas Pedersen
2011-08-30 11:50 ` Bob Copeland
2011-08-30 12:18 ` Johannes Berg
2011-08-30 12:21 ` Johannes Berg
2011-08-30 16:22 ` Javier Cardona
2011-08-30 18:29 ` [PATCH] mac80211: Defer tranmission of mesh path errors Javier Cardona
2011-08-30 18:43 ` Johannes Berg
2011-08-30 21:38 ` Javier Cardona
2011-08-31 1:50 ` Javier Cardona
2011-08-31 5:11 ` Johannes Berg
2011-09-01 17:04 ` Javier Cardona [this message]
2011-09-01 17:04 ` [PATCH v2] " Javier Cardona
2011-09-02 10:59 ` Johannes Berg
2011-09-06 19:10 ` [PATCH v3] " Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314896685-2932-1-git-send-email-javier@cozybit.com \
--to=javier@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=jlopex@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.