All of lore.kernel.org
 help / color / mirror / Atom feed
From: bifferos <bifferos@yahoo.co.uk>
To: Anthony Liguori <anthony@codemonkey.ws>, malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
Date: Wed, 31 Aug 2011 14:35:45 +0100 (BST)	[thread overview]
Message-ID: <1314797745.51403.YahooMailClassic@web27005.mail.ukl.yahoo.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1108311716530.1522@linmac>


--- On Wed, 31/8/11, malc <av1474@comtv.ru> wrote:

> From: malc <av1474@comtv.ru>
> Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
> To: "Anthony Liguori" <anthony@codemonkey.ws>
> Cc: qemu-devel@nongnu.org, "bifferos" <bifferos@yahoo.co.uk>
> Date: Wednesday, 31 August, 2011, 14:17
> On Tue, 30 Aug 2011, Anthony Liguori
> wrote:
> 
> > On 08/30/2011 08:30 PM, malc wrote:
> > > On Tue, 30 Aug 2011, Anthony Liguori wrote:
> > > 
> > > > This won't even come close to passing
> checkpatch.pl
> > > 
> > > Have you actually tried?
> > 
> > Sigh.  I was hoping checkpatch.pl was more useful
> than it appears to be.
> > 
> > At any rate, the patch doesn't follow CODING_STYLE.
> > 
> 
> Where?

My apologies, actually I had a half-hearted look for the coding style, came to this link:

http://git.qemu.org/qemu.git/plain/CODING_STYLE

Which was dead, and then fell back on the checkpatch.pl script, thinking nobody cared so much about coding styles.  I should have looked a bit more carefully.  Since then I found this:

http://git.savannah.gnu.org/cgit/qemu.git/tree/CODING_STYLE

AFAICS the problem is with the naming (part 3), which I can correct tonight (along with the other issues raised)



  parent reply	other threads:[~2011-08-31 13:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  1:05 [Qemu-devel] [PATCH] Add support for r6040 NIC bifferos
2011-08-31  1:17 ` Anthony Liguori
2011-08-31  1:30   ` malc
2011-08-31  1:59     ` Anthony Liguori
2011-08-31 13:17       ` malc
2011-08-31 13:30         ` Anthony Liguori
2011-08-31 13:39           ` malc
2011-08-31 13:40             ` Anthony Liguori
2011-08-31 13:51               ` malc
2011-08-31 14:29                 ` Anthony Liguori
2011-08-31 14:35                   ` malc
2011-08-31 16:06                     ` Anthony Liguori
2011-08-31 16:24                       ` malc
2011-08-31 18:35                         ` Blue Swirl
2011-08-31 18:37                           ` malc
2011-08-31 17:59                       ` Edgar E. Iglesias
2011-08-31 18:46                         ` Blue Swirl
2011-08-31 18:58                           ` Edgar E. Iglesias
2011-08-31 18:48                         ` Anthony Liguori
2011-08-31 19:12                           ` Edgar E. Iglesias
2011-08-31 19:18                             ` Edgar E. Iglesias
2011-08-31 19:23                             ` Anthony Liguori
2011-08-31 19:52                               ` Blue Swirl
2011-08-31 18:30                       ` Blue Swirl
2011-08-31 21:23                         ` bifferos
2011-09-01  7:39                         ` Markus Armbruster
2011-09-01 21:49                           ` Anthony Liguori
2011-09-03  9:44                             ` Blue Swirl
2011-09-01 10:42                       ` Gerd Hoffmann
2011-08-31 13:35         ` bifferos [this message]
2011-08-31 20:03     ` [Qemu-devel] [PATCH v2] " bifferos
2011-09-01  8:43 ` [Qemu-devel] [PATCH] " Avi Kivity
2011-09-01 20:02   ` bifferos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314797745.51403.YahooMailClassic@web27005.mail.ukl.yahoo.com \
    --to=bifferos@yahoo.co.uk \
    --cc=anthony@codemonkey.ws \
    --cc=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.