All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org, bifferos <bifferos@yahoo.co.uk>
Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
Date: Wed, 31 Aug 2011 11:06:11 -0500	[thread overview]
Message-ID: <4E5E5BF3.50801@codemonkey.ws> (raw)
In-Reply-To: <alpine.LNX.2.00.1108311830270.2400@linmac>

On 08/31/2011 09:35 AM, malc wrote:
> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>
>> Upper case field names are not okay.  If you think coding style isn't clear,
>> that's a bug in coding style.
>
> Sez hu? Coding style is garbage that should be thrown out of the window.
> As for looking, yeah, i'm looking at usb with it's lovely hungarian
> fields, should we stampede to "fix" it?
>
> If the one who's going to maintain the code is fine with whatever naming
> is used so be it.

No.  That's how we got into the coding style mess we're in in the first 
place.

There's no benefit to going through and changing existing code but new 
code needs to be consistent with the vast majority of code in the rest 
of the tree.  It's about overall code base consistency and maintainability.

Regards,

Anthony Liguori

>
> [..snip..]
>

  reply	other threads:[~2011-08-31 16:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  1:05 [Qemu-devel] [PATCH] Add support for r6040 NIC bifferos
2011-08-31  1:17 ` Anthony Liguori
2011-08-31  1:30   ` malc
2011-08-31  1:59     ` Anthony Liguori
2011-08-31 13:17       ` malc
2011-08-31 13:30         ` Anthony Liguori
2011-08-31 13:39           ` malc
2011-08-31 13:40             ` Anthony Liguori
2011-08-31 13:51               ` malc
2011-08-31 14:29                 ` Anthony Liguori
2011-08-31 14:35                   ` malc
2011-08-31 16:06                     ` Anthony Liguori [this message]
2011-08-31 16:24                       ` malc
2011-08-31 18:35                         ` Blue Swirl
2011-08-31 18:37                           ` malc
2011-08-31 17:59                       ` Edgar E. Iglesias
2011-08-31 18:46                         ` Blue Swirl
2011-08-31 18:58                           ` Edgar E. Iglesias
2011-08-31 18:48                         ` Anthony Liguori
2011-08-31 19:12                           ` Edgar E. Iglesias
2011-08-31 19:18                             ` Edgar E. Iglesias
2011-08-31 19:23                             ` Anthony Liguori
2011-08-31 19:52                               ` Blue Swirl
2011-08-31 18:30                       ` Blue Swirl
2011-08-31 21:23                         ` bifferos
2011-09-01  7:39                         ` Markus Armbruster
2011-09-01 21:49                           ` Anthony Liguori
2011-09-03  9:44                             ` Blue Swirl
2011-09-01 10:42                       ` Gerd Hoffmann
2011-08-31 13:35         ` bifferos
2011-08-31 20:03     ` [Qemu-devel] [PATCH v2] " bifferos
2011-09-01  8:43 ` [Qemu-devel] [PATCH] " Avi Kivity
2011-09-01 20:02   ` bifferos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5E5BF3.50801@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=av1474@comtv.ru \
    --cc=bifferos@yahoo.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.