All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Pavel Ivanov <paivanof@gmail.com>,
	Seth Forshee <seth.forshee@canonical.com>
Cc: linux-fsdevel@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@tuxera.com>
Subject: Re: Kernel 3.1.0-rc4 oops when connecting iPod
Date: Thu, 8 Sep 2011 04:13:01 +0100 (BST)	[thread overview]
Message-ID: <1315451581.92826.YahooMailClassic@web29509.mail.ird.yahoo.com> (raw)
In-Reply-To: <20110907175952.GC23829@thinkpad-t410>

--- On Wed, 7/9/11, Seth Forshee <seth.forshee@canonical.com> wrote:

> Yes, that was definitely just an oversight. Has anyone
> provided a patch
> yet? If not I've pasted a patch below. Seems like a fix
> should be
> applied ASAP.
> 
> 
> From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17
> 00:00:00 2001
> From: Seth Forshee <seth.forshee@canonical.com>
> Date: Wed, 7 Sep 2011 10:38:35 -0700
> Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in
> hfsplus_fill_super() error path
> 
> Commit 6596528 (hfsplus: ensure bio requests are not
> smaller than
> the hardware sectors) changed the pointers used for volume
> header
> allocations but failed to change the pointer freed in the
> error
> path of hfsplus_fill_super(). This patch fixes the
> problem.
> 
> Reported-by: Pavel Ivanov <paivanof@gmail.com>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> Cc: <stable@kernel.org>

Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>

Please go ahead and submit the patch.

> ---
>  fs/hfsplus/super.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
> index c106ca2..cadbb8c 100644
> --- a/fs/hfsplus/super.c
> +++ b/fs/hfsplus/super.c
> @@ -525,8 +525,8 @@ out_close_cat_tree:
>  out_close_ext_tree:
>      hfs_btree_close(sbi->ext_tree);
>  out_free_vhdr:
> -    kfree(sbi->s_vhdr);
> -    kfree(sbi->s_backup_vhdr);
> +    kfree(sbi->s_vhdr_buf);
> +    kfree(sbi->s_backup_vhdr_buf);
>  out_unload_nls:
>      unload_nls(sbi->nls);
>      unload_nls(nls);
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Pavel Ivanov <paivanof@gmail.com>,
	Seth Forshee <seth.forshee@canonical.com>
Cc: linux-fsdevel@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@tuxera.com>
Subject: Re: Kernel 3.1.0-rc4 oops when connecting iPod
Date: Thu, 8 Sep 2011 04:13:01 +0100 (BST)	[thread overview]
Message-ID: <1315451581.92826.YahooMailClassic@web29509.mail.ird.yahoo.com> (raw)
In-Reply-To: <20110907175952.GC23829@thinkpad-t410>

--- On Wed, 7/9/11, Seth Forshee <seth.forshee@canonical.com> wrote:

> Yes, that was definitely just an oversight. Has anyone
> provided a patch
> yet? If not I've pasted a patch below. Seems like a fix
> should be
> applied ASAP.
> 
> 
> From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17
> 00:00:00 2001
> From: Seth Forshee <seth.forshee@canonical.com>
> Date: Wed, 7 Sep 2011 10:38:35 -0700
> Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in
> hfsplus_fill_super() error path
> 
> Commit 6596528 (hfsplus: ensure bio requests are not
> smaller than
> the hardware sectors) changed the pointers used for volume
> header
> allocations but failed to change the pointer freed in the
> error
> path of hfsplus_fill_super(). This patch fixes the
> problem.
> 
> Reported-by: Pavel Ivanov <paivanof@gmail.com>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> Cc: <stable@kernel.org>

Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>

Please go ahead and submit the patch.

> ---
>  fs/hfsplus/super.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c
> index c106ca2..cadbb8c 100644
> --- a/fs/hfsplus/super.c
> +++ b/fs/hfsplus/super.c
> @@ -525,8 +525,8 @@ out_close_cat_tree:
>  out_close_ext_tree:
>      hfs_btree_close(sbi->ext_tree);
>  out_free_vhdr:
> -    kfree(sbi->s_vhdr);
> -    kfree(sbi->s_backup_vhdr);
> +    kfree(sbi->s_vhdr_buf);
> +    kfree(sbi->s_backup_vhdr_buf);
>  out_unload_nls:
>      unload_nls(sbi->nls);
>      unload_nls(nls);
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-09-08  3:13 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-03  3:08 Kernel 3.1.0-rc4 oops when connecting iPod Pavel Ivanov
2011-09-03  3:59 ` Hin-Tak Leung
2011-09-03  3:59   ` Hin-Tak Leung
2011-09-03  4:37   ` Pavel Ivanov
2011-09-03  6:57     ` Hin-Tak Leung
2011-09-03 20:52       ` Pavel Ivanov
2011-09-03 20:52         ` Pavel Ivanov
2011-09-03 23:35         ` Hin-Tak Leung
2011-09-03 23:35           ` Hin-Tak Leung
2011-09-03 23:59           ` Pavel Ivanov
2011-09-03 23:59             ` Pavel Ivanov
2011-09-04  0:37             ` Hin-Tak Leung
2011-09-06  4:35               ` Pavel Ivanov
2011-09-06  4:35                 ` Pavel Ivanov
2011-09-06  5:12                 ` Hin-Tak Leung
2011-09-06  5:12                   ` Hin-Tak Leung
2011-09-06 15:09                   ` Pavel Ivanov
2011-09-06 15:09                     ` Pavel Ivanov
2011-09-11  3:52                     ` Pavel Ivanov
2011-09-11  3:52                       ` Pavel Ivanov
2011-09-11 13:46                       ` Hin-Tak Leung
2011-09-11 13:46                         ` Hin-Tak Leung
2011-09-11 14:14                         ` Christoph Hellwig
2011-09-11 14:12                       ` Christoph Hellwig
2011-09-12 14:34                       ` Christoph Hellwig
2011-09-12 15:19                         ` Pavel Ivanov
2011-09-12 15:19                           ` Pavel Ivanov
2011-09-12 15:31                           ` Christoph Hellwig
2011-09-13  2:20                             ` Pavel Ivanov
2011-09-13  2:20                               ` Pavel Ivanov
2011-09-14 17:42                               ` Christoph Hellwig
2011-09-15 14:35                                 ` Christoph Hellwig
2011-09-12 15:57                           ` Hin-Tak Leung
2011-09-07 17:59                 ` Seth Forshee
2011-09-07 17:59                   ` Seth Forshee
2011-09-08  3:13                   ` Hin-Tak Leung [this message]
2011-09-08  3:13                     ` Hin-Tak Leung
2011-09-08 16:23                     ` Seth Forshee
2011-09-09 12:48                       ` Christoph Hellwig
2011-09-11  3:32                       ` Pavel Ivanov
2011-09-11  3:32                         ` Pavel Ivanov
2011-09-11 14:10                         ` Christoph Hellwig
2011-09-12 14:00                           ` Pavel Ivanov
2011-09-12 15:27                             ` [PATCH] hfsplus: Fix kfree of wrong vhdr pointers Seth Forshee
2011-09-12 15:28                               ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315451581.92826.YahooMailClassic@web29509.mail.ird.yahoo.com \
    --to=htl10@users.sourceforge.net \
    --cc=hch@tuxera.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paivanof@gmail.com \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.