From: Rob Herring <robherring2@gmail.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
shawn.guo@freescale.com, Kukjin Kim <kgene.kim@samsung.com>,
Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>,
Barry Song <baohua.song@csr.com>,
Linus Walleij <linus.ml.walleij@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 2/9] irq: check domain hwirq range for DT translate
Date: Wed, 14 Dec 2011 09:28:51 -0600 [thread overview]
Message-ID: <1323876538-20406-3-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1323876538-20406-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <rob.herring@calxeda.com>
A DT node may have more than 1 domain associated with it, so make sure
the hwirq number is within range when doing DT translation.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/irqdomain.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 200ce83..ae6441e 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -135,6 +135,9 @@ int irq_domain_simple_dt_translate(struct irq_domain *d,
return -EINVAL;
if (intsize < 1)
return -EINVAL;
+ if ((intspec[0] < d->hwirq_base) ||
+ (intspec[0] >= d->hwirq_base + d->nr_irq))
+ return -EINVAL;
*out_hwirq = intspec[0];
*out_type = IRQ_TYPE_NONE;
--
1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Linus Walleij
<linus.ml.walleij-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Barry Song <baohua.song-kQvG35nSl+M@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Subject: [PATCH 2/9] irq: check domain hwirq range for DT translate
Date: Wed, 14 Dec 2011 09:28:51 -0600 [thread overview]
Message-ID: <1323876538-20406-3-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1323876538-20406-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
A DT node may have more than 1 domain associated with it, so make sure
the hwirq number is within range when doing DT translation.
Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
---
kernel/irq/irqdomain.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 200ce83..ae6441e 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -135,6 +135,9 @@ int irq_domain_simple_dt_translate(struct irq_domain *d,
return -EINVAL;
if (intsize < 1)
return -EINVAL;
+ if ((intspec[0] < d->hwirq_base) ||
+ (intspec[0] >= d->hwirq_base + d->nr_irq))
+ return -EINVAL;
*out_hwirq = intspec[0];
*out_type = IRQ_TYPE_NONE;
--
1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] irq: check domain hwirq range for DT translate
Date: Wed, 14 Dec 2011 09:28:51 -0600 [thread overview]
Message-ID: <1323876538-20406-3-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1323876538-20406-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <rob.herring@calxeda.com>
A DT node may have more than 1 domain associated with it, so make sure
the hwirq number is within range when doing DT translation.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/irqdomain.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 200ce83..ae6441e 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -135,6 +135,9 @@ int irq_domain_simple_dt_translate(struct irq_domain *d,
return -EINVAL;
if (intsize < 1)
return -EINVAL;
+ if ((intspec[0] < d->hwirq_base) ||
+ (intspec[0] >= d->hwirq_base + d->nr_irq))
+ return -EINVAL;
*out_hwirq = intspec[0];
*out_type = IRQ_TYPE_NONE;
--
1.7.5.4
next prev parent reply other threads:[~2011-12-14 15:29 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 15:28 [PATCH 0/9] irq domain for gen irq chip and pl061 DT irq support Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` [PATCH 1/9] dt: add empty of_get_node/of_put_node functions Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 16:02 ` Grant Likely
2011-12-14 16:02 ` Grant Likely
2011-12-14 15:28 ` Rob Herring [this message]
2011-12-14 15:28 ` [PATCH 2/9] irq: check domain hwirq range for DT translate Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 16:08 ` Grant Likely
2011-12-14 16:08 ` Grant Likely
2011-12-15 5:23 ` Shawn Guo
2011-12-15 5:23 ` Shawn Guo
2011-12-15 5:23 ` Shawn Guo
2011-12-19 12:41 ` Cousson, Benoit
2011-12-19 12:41 ` Cousson, Benoit
2011-12-19 12:41 ` Cousson, Benoit
2011-12-19 14:23 ` Rob Herring
2011-12-19 14:23 ` Rob Herring
2011-12-19 15:21 ` Cousson, Benoit
2011-12-19 15:21 ` Cousson, Benoit
2011-12-19 15:21 ` Cousson, Benoit
2011-12-14 15:28 ` [PATCH 3/9] irq: convert generic-chip to use irq_domain Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:14 ` Grant Likely
2011-12-14 21:14 ` Grant Likely
2011-12-14 21:23 ` Rob Herring
2011-12-14 21:23 ` Rob Herring
2011-12-14 21:26 ` Grant Likely
2011-12-14 21:26 ` Grant Likely
2011-12-14 21:26 ` Grant Likely
2011-12-14 23:29 ` Rob Herring
2011-12-14 23:29 ` Rob Herring
2011-12-15 5:25 ` Shawn Guo
2011-12-15 5:25 ` Shawn Guo
2011-12-15 5:25 ` Shawn Guo
2011-12-15 5:55 ` Shawn Guo
2011-12-15 5:55 ` Shawn Guo
2011-12-15 5:55 ` Shawn Guo
2011-12-15 13:39 ` Rob Herring
2011-12-15 13:39 ` Rob Herring
2011-12-15 13:56 ` Rob Herring
2011-12-15 13:56 ` Rob Herring
2011-12-15 13:56 ` Rob Herring
2011-12-15 14:15 ` Shawn Guo
2011-12-15 14:15 ` Shawn Guo
2011-12-15 14:15 ` Shawn Guo
2011-12-15 14:46 ` Shawn Guo
2011-12-15 14:46 ` Shawn Guo
2011-12-15 14:46 ` Shawn Guo
2011-12-15 15:55 ` Grant Likely
2011-12-15 15:55 ` Grant Likely
2011-12-15 15:55 ` Grant Likely
2011-12-15 16:17 ` Rob Herring
2011-12-15 16:17 ` Rob Herring
2011-12-15 16:39 ` Grant Likely
2011-12-15 16:39 ` Grant Likely
2011-12-15 16:39 ` Grant Likely
2011-12-15 14:08 ` Shawn Guo
2011-12-15 14:08 ` Shawn Guo
2011-12-15 14:08 ` Shawn Guo
2011-12-15 14:01 ` Rob Herring
2011-12-15 14:01 ` Rob Herring
2011-12-15 14:01 ` Rob Herring
2011-12-14 15:28 ` [PATCH 4/9] gpio: pl061: use chained_irq_* functions in irq handler Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:15 ` Grant Likely
2011-12-14 21:15 ` Grant Likely
2011-12-14 15:28 ` [PATCH 5/9] gpio: pl061: convert to use 0 for no irq Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:16 ` Grant Likely
2011-12-14 21:16 ` Grant Likely
2011-12-14 15:28 ` [PATCH 6/9] ARM: realview: convert pl061 no irq to 0 instead of -1 Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:16 ` Grant Likely
2011-12-14 21:16 ` Grant Likely
2011-12-14 15:28 ` [PATCH 7/9] gpio: pl061: convert to use generic irq chip Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:17 ` Grant Likely
2011-12-14 21:17 ` Grant Likely
2011-12-19 20:52 ` [PATCH v2] " Rob Herring
2011-12-19 20:52 ` Rob Herring
2011-12-24 23:26 ` Linus Walleij
2011-12-24 23:26 ` Linus Walleij
2011-12-24 23:26 ` Linus Walleij
2012-01-02 8:54 ` Grant Likely
2012-01-02 8:54 ` Grant Likely
2012-01-02 8:54 ` Grant Likely
2012-01-02 16:54 ` Rob Herring
2012-01-02 16:54 ` Rob Herring
2012-01-02 16:54 ` Rob Herring
2011-12-14 15:28 ` [PATCH 8/9] gpio: pl061: enable interrupts with DT style binding Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:39 ` Grant Likely
2011-12-14 21:39 ` Grant Likely
2011-12-14 21:39 ` Grant Likely
2011-12-19 20:54 ` [PATCH v2] " Rob Herring
2011-12-19 20:54 ` Rob Herring
2011-12-14 15:28 ` [PATCH 9/9] ARM: highbank: add interrupt properties to gpio nodes Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 15:28 ` Rob Herring
2011-12-14 21:39 ` Grant Likely
2011-12-14 21:39 ` Grant Likely
2011-12-14 21:39 ` Grant Likely
2011-12-14 15:41 ` [PATCH 0/9] irq domain for gen irq chip and pl061 DT irq support Rob Herring
2011-12-14 15:41 ` Rob Herring
2011-12-14 15:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323876538-20406-3-git-send-email-robherring2@gmail.com \
--to=robherring2@gmail.com \
--cc=baohua.song@csr.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=khilman@ti.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@freescale.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.