From: Grant Likely <grant.likely@secretlab.ca> To: Rob Herring <robherring2@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, shawn.guo@freescale.com, Kukjin Kim <kgene.kim@samsung.com>, Kevin Hilman <khilman@ti.com>, Tony Lindgren <tony@atomide.com>, Barry Song <baohua.song@csr.com>, Linus Walleij <linus.ml.walleij@gmail.com>, Rob Herring <rob.herring@calxeda.com> Subject: Re: [PATCH 4/9] gpio: pl061: use chained_irq_* functions in irq handler Date: Wed, 14 Dec 2011 14:15:19 -0700 [thread overview] Message-ID: <CACxGe6uAEUXe=7B5c0yDdRWpMx-_d=dwc5wofh3FYaUN=EZQQg@mail.gmail.com> (raw) In-Reply-To: <1323876538-20406-5-git-send-email-robherring2@gmail.com> On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring <robherring2@gmail.com> wrote: > From: Rob Herring <rob.herring@calxeda.com> > > Use chained_irq_enter/exit helper functions instead of direct pointer > accesses. This is needed for generic irq chip conversion. > > Signed-off-by: Rob Herring <rob.herring@calxeda.com> > Cc: Grant Likely <grant.likely@secretlab.ca> Acked-by: Grant Likely <grant.likely@secretlab.ca> > Cc: Linus Walleij <linus.ml.walleij@gmail.com> > --- > drivers/gpio/gpio-pl061.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c > index 4102f63..0f718f9 100644 > --- a/drivers/gpio/gpio-pl061.c > +++ b/drivers/gpio/gpio-pl061.c > @@ -23,6 +23,7 @@ > #include <linux/amba/bus.h> > #include <linux/amba/pl061.h> > #include <linux/slab.h> > +#include <asm/mach/irq.h> > > #define GPIODIR 0x400 > #define GPIOIS 0x404 > @@ -211,8 +212,9 @@ static void pl061_irq_handler(unsigned irq, struct irq_desc *desc) > struct list_head *chip_list = irq_get_handler_data(irq); > struct list_head *ptr; > struct pl061_gpio *chip; > + struct irq_chip *irqchip = irq_desc_get_chip(desc); > > - desc->irq_data.chip->irq_ack(&desc->irq_data); > + chained_irq_enter(irqchip, desc); > list_for_each(ptr, chip_list) { > unsigned long pending; > int offset; > @@ -227,7 +229,7 @@ static void pl061_irq_handler(unsigned irq, struct irq_desc *desc) > for_each_set_bit(offset, &pending, PL061_GPIO_NR) > generic_handle_irq(pl061_to_irq(&chip->gc, offset)); > } > - desc->irq_data.chip->irq_unmask(&desc->irq_data); > + chained_irq_exit(irqchip, desc); > } > > static int pl061_probe(struct amba_device *dev, const struct amba_id *id) > -- > 1.7.5.4 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: grant.likely@secretlab.ca (Grant Likely) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/9] gpio: pl061: use chained_irq_* functions in irq handler Date: Wed, 14 Dec 2011 14:15:19 -0700 [thread overview] Message-ID: <CACxGe6uAEUXe=7B5c0yDdRWpMx-_d=dwc5wofh3FYaUN=EZQQg@mail.gmail.com> (raw) In-Reply-To: <1323876538-20406-5-git-send-email-robherring2@gmail.com> On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring <robherring2@gmail.com> wrote: > From: Rob Herring <rob.herring@calxeda.com> > > Use chained_irq_enter/exit helper functions instead of direct pointer > accesses. This is needed for generic irq chip conversion. > > Signed-off-by: Rob Herring <rob.herring@calxeda.com> > Cc: Grant Likely <grant.likely@secretlab.ca> Acked-by: Grant Likely <grant.likely@secretlab.ca> > Cc: Linus Walleij <linus.ml.walleij@gmail.com> > --- > ?drivers/gpio/gpio-pl061.c | ? ?6 ++++-- > ?1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c > index 4102f63..0f718f9 100644 > --- a/drivers/gpio/gpio-pl061.c > +++ b/drivers/gpio/gpio-pl061.c > @@ -23,6 +23,7 @@ > ?#include <linux/amba/bus.h> > ?#include <linux/amba/pl061.h> > ?#include <linux/slab.h> > +#include <asm/mach/irq.h> > > ?#define GPIODIR 0x400 > ?#define GPIOIS ?0x404 > @@ -211,8 +212,9 @@ static void pl061_irq_handler(unsigned irq, struct irq_desc *desc) > ? ? ? ?struct list_head *chip_list = irq_get_handler_data(irq); > ? ? ? ?struct list_head *ptr; > ? ? ? ?struct pl061_gpio *chip; > + ? ? ? struct irq_chip *irqchip = irq_desc_get_chip(desc); > > - ? ? ? desc->irq_data.chip->irq_ack(&desc->irq_data); > + ? ? ? chained_irq_enter(irqchip, desc); > ? ? ? ?list_for_each(ptr, chip_list) { > ? ? ? ? ? ? ? ?unsigned long pending; > ? ? ? ? ? ? ? ?int offset; > @@ -227,7 +229,7 @@ static void pl061_irq_handler(unsigned irq, struct irq_desc *desc) > ? ? ? ? ? ? ? ?for_each_set_bit(offset, &pending, PL061_GPIO_NR) > ? ? ? ? ? ? ? ? ? ? ? ?generic_handle_irq(pl061_to_irq(&chip->gc, offset)); > ? ? ? ?} > - ? ? ? desc->irq_data.chip->irq_unmask(&desc->irq_data); > + ? ? ? chained_irq_exit(irqchip, desc); > ?} > > ?static int pl061_probe(struct amba_device *dev, const struct amba_id *id) > -- > 1.7.5.4 > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2011-12-14 21:15 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-14 15:28 [PATCH 0/9] irq domain for gen irq chip and pl061 DT irq support Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` [PATCH 1/9] dt: add empty of_get_node/of_put_node functions Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 16:02 ` Grant Likely 2011-12-14 16:02 ` Grant Likely 2011-12-14 15:28 ` [PATCH 2/9] irq: check domain hwirq range for DT translate Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 16:08 ` Grant Likely 2011-12-14 16:08 ` Grant Likely 2011-12-15 5:23 ` Shawn Guo 2011-12-15 5:23 ` Shawn Guo 2011-12-15 5:23 ` Shawn Guo 2011-12-19 12:41 ` Cousson, Benoit 2011-12-19 12:41 ` Cousson, Benoit 2011-12-19 12:41 ` Cousson, Benoit 2011-12-19 14:23 ` Rob Herring 2011-12-19 14:23 ` Rob Herring 2011-12-19 15:21 ` Cousson, Benoit 2011-12-19 15:21 ` Cousson, Benoit 2011-12-19 15:21 ` Cousson, Benoit 2011-12-14 15:28 ` [PATCH 3/9] irq: convert generic-chip to use irq_domain Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:14 ` Grant Likely 2011-12-14 21:14 ` Grant Likely 2011-12-14 21:23 ` Rob Herring 2011-12-14 21:23 ` Rob Herring 2011-12-14 21:26 ` Grant Likely 2011-12-14 21:26 ` Grant Likely 2011-12-14 21:26 ` Grant Likely 2011-12-14 23:29 ` Rob Herring 2011-12-14 23:29 ` Rob Herring 2011-12-15 5:25 ` Shawn Guo 2011-12-15 5:25 ` Shawn Guo 2011-12-15 5:25 ` Shawn Guo 2011-12-15 5:55 ` Shawn Guo 2011-12-15 5:55 ` Shawn Guo 2011-12-15 5:55 ` Shawn Guo 2011-12-15 13:39 ` Rob Herring 2011-12-15 13:39 ` Rob Herring 2011-12-15 13:56 ` Rob Herring 2011-12-15 13:56 ` Rob Herring 2011-12-15 13:56 ` Rob Herring 2011-12-15 14:15 ` Shawn Guo 2011-12-15 14:15 ` Shawn Guo 2011-12-15 14:15 ` Shawn Guo 2011-12-15 14:46 ` Shawn Guo 2011-12-15 14:46 ` Shawn Guo 2011-12-15 14:46 ` Shawn Guo 2011-12-15 15:55 ` Grant Likely 2011-12-15 15:55 ` Grant Likely 2011-12-15 15:55 ` Grant Likely 2011-12-15 16:17 ` Rob Herring 2011-12-15 16:17 ` Rob Herring 2011-12-15 16:39 ` Grant Likely 2011-12-15 16:39 ` Grant Likely 2011-12-15 16:39 ` Grant Likely 2011-12-15 14:08 ` Shawn Guo 2011-12-15 14:08 ` Shawn Guo 2011-12-15 14:08 ` Shawn Guo 2011-12-15 14:01 ` Rob Herring 2011-12-15 14:01 ` Rob Herring 2011-12-15 14:01 ` Rob Herring 2011-12-14 15:28 ` [PATCH 4/9] gpio: pl061: use chained_irq_* functions in irq handler Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:15 ` Grant Likely [this message] 2011-12-14 21:15 ` Grant Likely 2011-12-14 15:28 ` [PATCH 5/9] gpio: pl061: convert to use 0 for no irq Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:16 ` Grant Likely 2011-12-14 21:16 ` Grant Likely 2011-12-14 15:28 ` [PATCH 6/9] ARM: realview: convert pl061 no irq to 0 instead of -1 Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:16 ` Grant Likely 2011-12-14 21:16 ` Grant Likely 2011-12-14 15:28 ` [PATCH 7/9] gpio: pl061: convert to use generic irq chip Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:17 ` Grant Likely 2011-12-14 21:17 ` Grant Likely 2011-12-19 20:52 ` [PATCH v2] " Rob Herring 2011-12-19 20:52 ` Rob Herring 2011-12-24 23:26 ` Linus Walleij 2011-12-24 23:26 ` Linus Walleij 2011-12-24 23:26 ` Linus Walleij 2012-01-02 8:54 ` Grant Likely 2012-01-02 8:54 ` Grant Likely 2012-01-02 8:54 ` Grant Likely 2012-01-02 16:54 ` Rob Herring 2012-01-02 16:54 ` Rob Herring 2012-01-02 16:54 ` Rob Herring 2011-12-14 15:28 ` [PATCH 8/9] gpio: pl061: enable interrupts with DT style binding Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:39 ` Grant Likely 2011-12-14 21:39 ` Grant Likely 2011-12-14 21:39 ` Grant Likely 2011-12-19 20:54 ` [PATCH v2] " Rob Herring 2011-12-19 20:54 ` Rob Herring 2011-12-14 15:28 ` [PATCH 9/9] ARM: highbank: add interrupt properties to gpio nodes Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 15:28 ` Rob Herring 2011-12-14 21:39 ` Grant Likely 2011-12-14 21:39 ` Grant Likely 2011-12-14 21:39 ` Grant Likely 2011-12-14 15:41 ` [PATCH 0/9] irq domain for gen irq chip and pl061 DT irq support Rob Herring 2011-12-14 15:41 ` Rob Herring 2011-12-14 15:41 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACxGe6uAEUXe=7B5c0yDdRWpMx-_d=dwc5wofh3FYaUN=EZQQg@mail.gmail.com' \ --to=grant.likely@secretlab.ca \ --cc=baohua.song@csr.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=kgene.kim@samsung.com \ --cc=khilman@ti.com \ --cc=linus.ml.walleij@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rob.herring@calxeda.com \ --cc=robherring2@gmail.com \ --cc=shawn.guo@freescale.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.