All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: "Roger Pau Monné" <roger.pau@entel.upc.edu>
Cc: William Pitcock <nenolod@dereferenced.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 3 of 5] blktap2: fix vhd compilation under uclibc
Date: Mon, 19 Dec 2011 13:43:02 +0000	[thread overview]
Message-ID: <1324302182.9236.51.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <CAPLaKK6NhoXTiaFWb9aTcuapaqtNVcKo==7=xXP8wf5N66kFUw@mail.gmail.com>

On Mon, 2011-12-19 at 13:30 +0000, Roger Pau Monné wrote:
> 2011/12/19 Ian Campbell <Ian.Campbell@citrix.com>:
> > On Mon, 2011-12-19 at 12:30 +0000, Roger Pau Monné wrote:
> >> What's strange is that libvhd (which uses iconv) compiles and links
> >> fine,
> >
> > libvhd needs -liconv but it will compile and link without it fine. It is
> > only when you try to link something against that library that the
> > problem will manifest itself.
> >
> >>  but vhd-util that uses libvhd complains about undefined
> >> references to iconv, when vhd-util doesn't use iconv.
> >
> > Right.
> >
> > Ian.
> 
> I have a expression that checks for libiconv, but it will only detect
> it if ldconfig is present, if the system doesn't have ldconfig
> (NetBSD), libiconv will not be detected even if it is present:
> 
> which ldconfig 2>&1 >/dev/null && (ldconfig -p | grep -q libiconv &&
> echo 'y' || echo 'n') || echo 'n'

Urgh, surely there's a better way!

Perhaps grepping for LIBICONV_PLUG or libiconv_open or something unique
in iconv.h would be better?

BTW did you try defining LIBICONV_PLUG?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

  reply	other threads:[~2011-12-19 13:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 12:48 [PATCH 0 of 5] build: various fixes for building with uclibc Roger Pau Monne
2011-12-18 12:48 ` [PATCH 1 of 5] blktap: remove HAVE_BYTESWAP_H checking, since it's defined by qemu Roger Pau Monne
2011-12-19  9:48   ` Ian Campbell
2011-12-19  9:57     ` William Pitcock
2011-12-19  9:58     ` Roger Pau Monné
2011-12-19 10:08       ` Ian Campbell
2011-12-19 11:26         ` Roger Pau Monné
2011-12-19 11:27           ` Ian Campbell
2011-12-19 11:28             ` Roger Pau Monné
2011-12-19 11:38               ` Ian Campbell
2011-12-19 11:46                 ` Roger Pau Monné
2011-12-19 11:49                   ` Ian Campbell
2011-12-19 12:04                     ` Roger Pau Monné
2011-12-21  9:40                       ` Roger Pau Monné
2011-12-18 12:48 ` [PATCH 2 of 5] build: detect uclibc Roger Pau Monne
2011-12-19 10:08   ` William Pitcock
2011-12-20 18:02   ` Ian Jackson
2011-12-20 18:24     ` Roger Pau Monné
2011-12-20 18:25       ` Ian Jackson
2011-12-18 12:48 ` [PATCH 3 of 5] blktap2: fix vhd compilation under uclibc Roger Pau Monne
2011-12-19 10:05   ` Ian Campbell
2011-12-19 10:07   ` William Pitcock
2011-12-19 12:30     ` Roger Pau Monné
2011-12-19 13:26       ` Ian Campbell
2011-12-19 13:30         ` Roger Pau Monné
2011-12-19 13:43           ` Ian Campbell [this message]
2011-12-19 14:43             ` Roger Pau Monné
2011-12-20 17:55               ` Roger Pau Monné
2011-12-21 10:01                 ` Ian Campbell
2011-12-21 10:15                   ` Roger Pau Monné
2011-12-21 10:28                     ` Ian Campbell
2011-12-18 12:48 ` [PATCH 4 of 5] blktap2: remove HAVE_BYTESWAP_H checking, since it's defined by qemu Roger Pau Monne
2011-12-18 12:48 ` [PATCH 5 of 5] libxl: fix link issue on uclibc when using yajl Roger Pau Monne
2011-12-19  9:54   ` Ian Campbell
2011-12-19 10:01     ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324302182.9236.51.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=nenolod@dereferenced.org \
    --cc=roger.pau@entel.upc.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.