Re: [PATCH 3 of 5] blktap2: fix vhd compilation under uclibc

[William Pitcock <nenolod@dereferenced.org>]

Hi,

On Sun, Dec 18, 2011 at 6:48 AM, Roger Pau Monne
<roger.pau@entel.upc.edu> wrote:
> # HG changeset patch
> # User Roger Pau Monne <roger.pau@entel.upc.edu>
> # Date 1324171782 -3600
> # Node ID c0d5aa328f1ab24aad5880e720852b6dc8ffd4fb
> # Parent  c54c326d6fdf26d311c872479b769b3a8cd560cf
> blktap2: fix vhd compilation under uclibc
>
> blktap2 was not compiled succesfully under uclibc, with the following
> error:

This description is wrong; it is a linktime symbol binding error, not
a compilation error.

>
> gcc     -o vhd-util vhd-util.o -Llib -lvhd
> lib/libvhd.so: undefined reference to `libiconv_open'
> lib/libvhd.so: undefined reference to `libiconv_close'
> lib/libvhd.so: undefined reference to `libiconv'
>
> This patchs add the flag -liconv when blktap2/vhd is compiled on
> uclibc.
>
> Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>
>
> diff -r c54c326d6fdf -r c0d5aa328f1a tools/blktap2/drivers/Makefile
> --- a/tools/blktap2/drivers/Makefile    Sun Dec 18 02:29:42 2011 +0100
> +++ b/tools/blktap2/drivers/Makefile    Sun Dec 18 02:29:42 2011 +0100
> @@ -24,6 +24,10 @@ endif
>
>  VHDLIBS    := -L$(LIBVHDDIR) -lvhd
>
> +ifeq ($(CONFIG_UCLIBC),y)
> +VHDLIBS    += -liconv
> +endif

I don't like this really.  I think it is wrong to imply that
$(CONFIG_UCLIBC) needs -liconv, as it is possible to build uClibc with
iconv support.  The real check here should be if we are running with
GNU libiconv I think.  Which makes me wonder why CONFIG_UCLIBC is
necessary at all.

> +
>  REMUS-OBJS  := block-remus.o
>  REMUS-OBJS  += hashtable.o
>  REMUS-OBJS  += hashtable_itr.o
> diff -r c54c326d6fdf -r c0d5aa328f1a tools/blktap2/vhd/Makefile
> --- a/tools/blktap2/vhd/Makefile        Sun Dec 18 02:29:42 2011 +0100
> +++ b/tools/blktap2/vhd/Makefile        Sun Dec 18 02:29:42 2011 +0100
> @@ -23,6 +23,10 @@ endif
>
>  LIBS              := -Llib -lvhd
>
> +ifeq ($(CONFIG_UCLIBC),y)
> +LIBS              += -liconv
> +endif
> +
>  all: subdirs-all build
>
>  build: $(IBIN)
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel