All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@entel.upc.edu>
To: xen-devel@lists.xensource.com
Subject: [PATCH 1 of 5] blktap: remove HAVE_BYTESWAP_H checking, since it's defined by qemu
Date: Sun, 18 Dec 2011 13:48:21 +0100	[thread overview]
Message-ID: <eed78eb655c40b0ac9af.1324212501@alpine.localdomain> (raw)
In-Reply-To: <patchbomb.1324212500@alpine.localdomain>

# HG changeset patch
# User Roger Pau Monne <roger.pau@entel.upc.edu>
# Date 1324171782 -3600
# Node ID eed78eb655c40b0ac9af1b14c1cc03204f696b0b
# Parent  b783e76e63a99c9d87fca4974492f60af99a2e7a
blktap: remove HAVE_BYTESWAP_H checking, since it's defined by qemu

blktap was using defines set by qemu, even when the qemu config file
is not included. Remove this checkings, and instead check if the file
has been included before defining the necessary macros.

The output error is:

In file included from block-qcow.c:37:0:
bswap.h:23:0: error: "bswap_16" redefined [-Werror]
/usr/include/byteswap.h:30:0: note: this is the location of the
previous definition
bswap.h:31:0: error: "bswap_32" redefined [-Werror]
/usr/include/byteswap.h:33:0: note: this is the location of the
previous definition
bswap.h:41:0: error: "bswap_64" redefined [-Werror]
/usr/include/byteswap.h:37:0: note: this is the location of the
previous definition
cc1: all warnings being treated as errors

Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>

diff -r b783e76e63a9 -r eed78eb655c4 tools/blktap/drivers/bswap.h
--- a/tools/blktap/drivers/bswap.h	Sun Dec 18 02:29:42 2011 +0100
+++ b/tools/blktap/drivers/bswap.h	Sun Dec 18 02:29:42 2011 +0100
@@ -15,9 +15,7 @@
 #define bswap_64(x) swap64(x)
 #else
 
-#ifdef HAVE_BYTESWAP_H
-#include <byteswap.h>
-#else
+#ifndef _BYTESWAP_H
 
 #define bswap_16(x) \
 ({ \
@@ -51,7 +49,7 @@
 		(uint64_t)(((uint64_t)(__x) & (uint64_t)0xff00000000000000ULL) >> 56) )); \
 })
 
-#endif /* !HAVE_BYTESWAP_H */
+#endif /* !_BYTESWAP_H */
 
 static inline uint16_t bswap16(uint16_t x)
 {

  reply	other threads:[~2011-12-18 12:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 12:48 [PATCH 0 of 5] build: various fixes for building with uclibc Roger Pau Monne
2011-12-18 12:48 ` Roger Pau Monne [this message]
2011-12-19  9:48   ` [PATCH 1 of 5] blktap: remove HAVE_BYTESWAP_H checking, since it's defined by qemu Ian Campbell
2011-12-19  9:57     ` William Pitcock
2011-12-19  9:58     ` Roger Pau Monné
2011-12-19 10:08       ` Ian Campbell
2011-12-19 11:26         ` Roger Pau Monné
2011-12-19 11:27           ` Ian Campbell
2011-12-19 11:28             ` Roger Pau Monné
2011-12-19 11:38               ` Ian Campbell
2011-12-19 11:46                 ` Roger Pau Monné
2011-12-19 11:49                   ` Ian Campbell
2011-12-19 12:04                     ` Roger Pau Monné
2011-12-21  9:40                       ` Roger Pau Monné
2011-12-18 12:48 ` [PATCH 2 of 5] build: detect uclibc Roger Pau Monne
2011-12-19 10:08   ` William Pitcock
2011-12-20 18:02   ` Ian Jackson
2011-12-20 18:24     ` Roger Pau Monné
2011-12-20 18:25       ` Ian Jackson
2011-12-18 12:48 ` [PATCH 3 of 5] blktap2: fix vhd compilation under uclibc Roger Pau Monne
2011-12-19 10:05   ` Ian Campbell
2011-12-19 10:07   ` William Pitcock
2011-12-19 12:30     ` Roger Pau Monné
2011-12-19 13:26       ` Ian Campbell
2011-12-19 13:30         ` Roger Pau Monné
2011-12-19 13:43           ` Ian Campbell
2011-12-19 14:43             ` Roger Pau Monné
2011-12-20 17:55               ` Roger Pau Monné
2011-12-21 10:01                 ` Ian Campbell
2011-12-21 10:15                   ` Roger Pau Monné
2011-12-21 10:28                     ` Ian Campbell
2011-12-18 12:48 ` [PATCH 4 of 5] blktap2: remove HAVE_BYTESWAP_H checking, since it's defined by qemu Roger Pau Monne
2011-12-18 12:48 ` [PATCH 5 of 5] libxl: fix link issue on uclibc when using yajl Roger Pau Monne
2011-12-19  9:54   ` Ian Campbell
2011-12-19 10:01     ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eed78eb655c40b0ac9af.1324212501@alpine.localdomain \
    --to=roger.pau@entel.upc.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.