From: Steven Price <steven.price@arm.com> To: "Clément Péron" <peron.clem@gmail.com> Cc: Rob Herring <robh@kernel.org>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>, Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support Date: Thu, 7 May 2020 15:30:24 +0100 [thread overview] Message-ID: <13285d84-5a5e-c695-2a8b-7ca50c976b90@arm.com> (raw) In-Reply-To: <CAJiuCcfrMhu5Mi7YZTttw2k+hGui0GFAmOhPh_9fv4Te27M0+A@mail.gmail.com> On 02/05/2020 23:07, Clément Péron wrote: > Hi Steven, > > On Tue, 14 Apr 2020 at 15:10, Steven Price <steven.price@arm.com> wrote: >> >> Hi Clément, >> >> On 13/04/2020 18:28, Clément Péron wrote: >>> Hi Steven, >>> > > <snip> > >> Getting a backtrace from the two occurrences, I see one added from: >> >> (debugfs_create_dir) from [<c04633f8>] (create_regulator+0xe0/0x220) >> (create_regulator) from [<c04681d8>] (_regulator_get+0x168/0x204) >> (_regulator_get) from [<c04682e0>] (regulator_bulk_get+0x64/0xf4) >> (regulator_bulk_get) from [<c04696f0>] >> (devm_regulator_bulk_get+0x40/0x74) >> (devm_regulator_bulk_get) from [<bf00af44>] >> (panfrost_device_init+0x1b4/0x48c [panfrost]) >> (panfrost_device_init [panfrost]) from [<bf00a4d4>] >> (panfrost_probe+0x94/0x184 [panfrost]) >> (panfrost_probe [panfrost]) from [<c04ee694>] >> (platform_drv_probe+0x48/0x94) >> >> And the other: >> >> (debugfs_create_dir) from [<c04633f8>] (create_regulator+0xe0/0x220) >> (create_regulator) from [<c04681d8>] (_regulator_get+0x168/0x204) >> (_regulator_get) from [<c05c1280>] (dev_pm_opp_set_regulators+0x6c/0x184) >> (dev_pm_opp_set_regulators) from [<bf00b4ac>] >> (panfrost_devfreq_init+0x38/0x1ac [panfrost]) >> (panfrost_devfreq_init [panfrost]) from [<bf00a508>] >> (panfrost_probe+0xc8/0x184 [panfrost]) >> (panfrost_probe [panfrost]) from [<c04ee694>] >> (platform_drv_probe+0x48/0x94) >> >> Both are created at /regulator/vdd_gpu > > I'm preparing a new version with some clean from lima devfreq. > My working branch : > https://github.com/clementperon/linux/commits/panfrost_devfreq I had a look at that branch and gave it a quick spin on my Firefly RK3288 and didn't notice any issues. > Two strange things I observe: > - After 30sec the regulator is released by OPP ??? > [ 33.757627] vdd-gpu: disabling > Introduce the regulator support in this commit: > https://github.com/clementperon/linux/commit/be310c37b82010e293b7f129ccdcb711a2abb2ce I can't see anything wrong with this commit, but equally in my DTS I have a "regulator-always-on" for vdd_gpu. My initial thought was that this could be runtime PM of the GPU - but I can't see how panfrost_device_suspend() would end up turning off the regulator. So unless there's some way that the regulator itself suspends (but it should know it's in use) I've no clue why this would be happening. Since you've got a reproduction - can you get a backtrace where the regulator is getting disabled? > - The Cooling map is not probe correctly : > [ 2.545756] panfrost 1800000.gpu: [drm:panfrost_devfreq_init > [panfrost]] Failed to register cooling device > Introduce in this commit : > https://github.com/clementperon/linux/commit/0252c38fd55ad78366ac4b1714e285c88db34557 > > Do you have an hint about what I'm missing ? Sorry, my knowledge of the cooling framework is very limited. What you've got looks plausible, but I'm afraid I can't really help beyond that! As before - can you try adding some printk()s in e.g. of_devfreq_cooling_register_power() and find out where it is bailing out? Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com> To: "Clément Péron" <peron.clem@gmail.com> Cc: Nishanth Menon <nm@ti.com>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <vireshk@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support Date: Thu, 7 May 2020 15:30:24 +0100 [thread overview] Message-ID: <13285d84-5a5e-c695-2a8b-7ca50c976b90@arm.com> (raw) In-Reply-To: <CAJiuCcfrMhu5Mi7YZTttw2k+hGui0GFAmOhPh_9fv4Te27M0+A@mail.gmail.com> On 02/05/2020 23:07, Clément Péron wrote: > Hi Steven, > > On Tue, 14 Apr 2020 at 15:10, Steven Price <steven.price@arm.com> wrote: >> >> Hi Clément, >> >> On 13/04/2020 18:28, Clément Péron wrote: >>> Hi Steven, >>> > > <snip> > >> Getting a backtrace from the two occurrences, I see one added from: >> >> (debugfs_create_dir) from [<c04633f8>] (create_regulator+0xe0/0x220) >> (create_regulator) from [<c04681d8>] (_regulator_get+0x168/0x204) >> (_regulator_get) from [<c04682e0>] (regulator_bulk_get+0x64/0xf4) >> (regulator_bulk_get) from [<c04696f0>] >> (devm_regulator_bulk_get+0x40/0x74) >> (devm_regulator_bulk_get) from [<bf00af44>] >> (panfrost_device_init+0x1b4/0x48c [panfrost]) >> (panfrost_device_init [panfrost]) from [<bf00a4d4>] >> (panfrost_probe+0x94/0x184 [panfrost]) >> (panfrost_probe [panfrost]) from [<c04ee694>] >> (platform_drv_probe+0x48/0x94) >> >> And the other: >> >> (debugfs_create_dir) from [<c04633f8>] (create_regulator+0xe0/0x220) >> (create_regulator) from [<c04681d8>] (_regulator_get+0x168/0x204) >> (_regulator_get) from [<c05c1280>] (dev_pm_opp_set_regulators+0x6c/0x184) >> (dev_pm_opp_set_regulators) from [<bf00b4ac>] >> (panfrost_devfreq_init+0x38/0x1ac [panfrost]) >> (panfrost_devfreq_init [panfrost]) from [<bf00a508>] >> (panfrost_probe+0xc8/0x184 [panfrost]) >> (panfrost_probe [panfrost]) from [<c04ee694>] >> (platform_drv_probe+0x48/0x94) >> >> Both are created at /regulator/vdd_gpu > > I'm preparing a new version with some clean from lima devfreq. > My working branch : > https://github.com/clementperon/linux/commits/panfrost_devfreq I had a look at that branch and gave it a quick spin on my Firefly RK3288 and didn't notice any issues. > Two strange things I observe: > - After 30sec the regulator is released by OPP ??? > [ 33.757627] vdd-gpu: disabling > Introduce the regulator support in this commit: > https://github.com/clementperon/linux/commit/be310c37b82010e293b7f129ccdcb711a2abb2ce I can't see anything wrong with this commit, but equally in my DTS I have a "regulator-always-on" for vdd_gpu. My initial thought was that this could be runtime PM of the GPU - but I can't see how panfrost_device_suspend() would end up turning off the regulator. So unless there's some way that the regulator itself suspends (but it should know it's in use) I've no clue why this would be happening. Since you've got a reproduction - can you get a backtrace where the regulator is getting disabled? > - The Cooling map is not probe correctly : > [ 2.545756] panfrost 1800000.gpu: [drm:panfrost_devfreq_init > [panfrost]] Failed to register cooling device > Introduce in this commit : > https://github.com/clementperon/linux/commit/0252c38fd55ad78366ac4b1714e285c88db34557 > > Do you have an hint about what I'm missing ? Sorry, my knowledge of the cooling framework is very limited. What you've got looks plausible, but I'm afraid I can't really help beyond that! As before - can you try adding some printk()s in e.g. of_devfreq_cooling_register_power() and find out where it is bailing out? Steve _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-07 14:31 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-11 20:06 [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Clément Péron 2020-04-11 20:06 ` Clément Péron 2020-04-11 20:06 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Clément Péron 2020-04-11 20:06 ` Clément Péron 2020-04-13 11:33 ` Clément Péron 2020-04-13 11:33 ` Clément Péron 2020-04-13 13:18 ` Steven Price 2020-04-13 13:18 ` Steven Price 2020-04-13 14:18 ` Clément Péron 2020-04-13 14:18 ` Clément Péron 2020-04-13 14:31 ` Clément Péron 2020-04-13 14:31 ` Clément Péron 2020-04-13 15:55 ` Steven Price 2020-04-13 15:55 ` Steven Price 2020-04-13 16:35 ` Clément Péron 2020-04-13 16:35 ` Clément Péron 2020-04-13 17:28 ` Clément Péron 2020-04-13 17:28 ` Clément Péron 2020-04-14 13:10 ` Steven Price 2020-04-14 13:10 ` Steven Price 2020-04-14 18:20 ` Clément Péron 2020-04-14 18:20 ` Clément Péron 2020-04-14 18:55 ` Mark Brown 2020-04-14 18:55 ` Mark Brown 2020-04-14 19:16 ` Clément Péron 2020-04-14 19:16 ` Clément Péron 2020-04-16 13:42 ` Multiple regulators for one device [was drm/panfrost: add devfreq regulator support] Steven Price 2020-04-16 13:42 ` Steven Price 2020-04-16 14:04 ` Mark Brown 2020-04-16 14:04 ` Mark Brown 2020-04-17 11:10 ` Robin Murphy 2020-04-17 11:10 ` Robin Murphy 2020-04-17 12:33 ` Clément Péron 2020-04-17 12:33 ` Clément Péron 2020-04-19 9:25 ` Clément Péron 2020-04-19 9:25 ` Clément Péron 2020-04-20 12:32 ` Mark Brown 2020-04-20 12:32 ` Mark Brown 2020-04-16 13:44 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Mark Brown 2020-04-16 13:44 ` Mark Brown 2020-05-02 22:07 ` Clément Péron 2020-05-02 22:07 ` Clément Péron 2020-05-07 14:30 ` Steven Price [this message] 2020-05-07 14:30 ` Steven Price 2020-05-09 16:28 ` Clément Péron 2020-05-09 16:28 ` Clément Péron 2020-05-09 19:40 ` Clément Péron 2020-05-09 19:40 ` Clément Péron 2020-04-14 13:09 ` Robin Murphy 2020-04-14 13:09 ` Robin Murphy 2020-04-13 13:07 ` [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Steven Price 2020-04-13 13:07 ` Steven Price
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=13285d84-5a5e-c695-2a8b-7ca50c976b90@arm.com \ --to=steven.price@arm.com \ --cc=alyssa.rosenzweig@collabora.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nm@ti.com \ --cc=peron.clem@gmail.com \ --cc=robh@kernel.org \ --cc=sboyd@kernel.org \ --cc=tomeu.vizoso@collabora.com \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.