From: Mark Brown <broonie@kernel.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Steven Price <steven.price@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support
Date: Tue, 14 Apr 2020 19:55:23 +0100 [thread overview]
Message-ID: <20200414185523.GO5412@sirena.org.uk> (raw)
In-Reply-To: <CAJiuCccF3tmbmMWNh0nC5WRJ1_iPdj6f1oH1zYMSue_pFrXsPQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Tue, Apr 14, 2020 at 08:20:23PM +0200, Clément Péron wrote:
> Hi Liam and Mark,
You might want to flag stuff like this in the subject line, I very
nearly deleted this without opening it since most of the email I get
about panfrost appears to be coming from me having sent patches rather
than being relevant.
> We are having an issue with Panfrost driver registering two times the
> same regulator and giving an error when trying to create the debugfs
> folder.
> Could you clarify if it is allowed for a device to register two times
> the same regulator?
> I check Documentation/power/regulator/regulator.rst but this point is
> not specified.
We don't actively prevent it and I can't think what other than debugfs
might run into problems (and that's just a warning) but it does seem
like a weird thing to want to do and like it's pointing to some
confusion in your code with two different parts of the device
controlling the same supply independently. What's the use case here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Nishanth Menon <nm@ti.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Steven Price <steven.price@arm.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support
Date: Tue, 14 Apr 2020 19:55:23 +0100 [thread overview]
Message-ID: <20200414185523.GO5412@sirena.org.uk> (raw)
In-Reply-To: <CAJiuCccF3tmbmMWNh0nC5WRJ1_iPdj6f1oH1zYMSue_pFrXsPQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1011 bytes --]
On Tue, Apr 14, 2020 at 08:20:23PM +0200, Clément Péron wrote:
> Hi Liam and Mark,
You might want to flag stuff like this in the subject line, I very
nearly deleted this without opening it since most of the email I get
about panfrost appears to be coming from me having sent patches rather
than being relevant.
> We are having an issue with Panfrost driver registering two times the
> same regulator and giving an error when trying to create the debugfs
> folder.
> Could you clarify if it is allowed for a device to register two times
> the same regulator?
> I check Documentation/power/regulator/regulator.rst but this point is
> not specified.
We don't actively prevent it and I can't think what other than debugfs
might run into problems (and that's just a warning) but it does seem
like a weird thing to want to do and like it's pointing to some
confusion in your code with two different parts of the device
controlling the same supply independently. What's the use case here?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-14 18:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 20:06 [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Clément Péron
2020-04-11 20:06 ` Clément Péron
2020-04-11 20:06 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Clément Péron
2020-04-11 20:06 ` Clément Péron
2020-04-13 11:33 ` Clément Péron
2020-04-13 11:33 ` Clément Péron
2020-04-13 13:18 ` Steven Price
2020-04-13 13:18 ` Steven Price
2020-04-13 14:18 ` Clément Péron
2020-04-13 14:18 ` Clément Péron
2020-04-13 14:31 ` Clément Péron
2020-04-13 14:31 ` Clément Péron
2020-04-13 15:55 ` Steven Price
2020-04-13 15:55 ` Steven Price
2020-04-13 16:35 ` Clément Péron
2020-04-13 16:35 ` Clément Péron
2020-04-13 17:28 ` Clément Péron
2020-04-13 17:28 ` Clément Péron
2020-04-14 13:10 ` Steven Price
2020-04-14 13:10 ` Steven Price
2020-04-14 18:20 ` Clément Péron
2020-04-14 18:20 ` Clément Péron
2020-04-14 18:55 ` Mark Brown [this message]
2020-04-14 18:55 ` Mark Brown
2020-04-14 19:16 ` Clément Péron
2020-04-14 19:16 ` Clément Péron
2020-04-16 13:42 ` Multiple regulators for one device [was drm/panfrost: add devfreq regulator support] Steven Price
2020-04-16 13:42 ` Steven Price
2020-04-16 14:04 ` Mark Brown
2020-04-16 14:04 ` Mark Brown
2020-04-17 11:10 ` Robin Murphy
2020-04-17 11:10 ` Robin Murphy
2020-04-17 12:33 ` Clément Péron
2020-04-17 12:33 ` Clément Péron
2020-04-19 9:25 ` Clément Péron
2020-04-19 9:25 ` Clément Péron
2020-04-20 12:32 ` Mark Brown
2020-04-20 12:32 ` Mark Brown
2020-04-16 13:44 ` [PATCH 2/2] drm/panfrost: add devfreq regulator support Mark Brown
2020-04-16 13:44 ` Mark Brown
2020-05-02 22:07 ` Clément Péron
2020-05-02 22:07 ` Clément Péron
2020-05-07 14:30 ` Steven Price
2020-05-07 14:30 ` Steven Price
2020-05-09 16:28 ` Clément Péron
2020-05-09 16:28 ` Clément Péron
2020-05-09 19:40 ` Clément Péron
2020-05-09 19:40 ` Clément Péron
2020-04-14 13:09 ` Robin Murphy
2020-04-14 13:09 ` Robin Murphy
2020-04-13 13:07 ` [PATCH 1/2] drm/panfrost: missing remove opp table in case of failure Steven Price
2020-04-13 13:07 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414185523.GO5412@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.