* [PATCH] NFS: Make keys writable on the idmap keyring.
@ 2012-02-07 13:02 Steve Dickson
2012-02-07 23:29 ` James Morris
2012-02-08 10:33 ` [Keyrings] " David Howells
0 siblings, 2 replies; 4+ messages in thread
From: Steve Dickson @ 2012-02-07 13:02 UTC (permalink / raw)
To: James Morris; +Cc: Linux Keyring Mailing list, Linux NFS Mailing list
To take advantage of the "Allow special keyrings to be
cleared" keyring patch the NFS keyring has to be writeable.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
fs/nfs/idmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
index a1bbf77..1d88cdb 100644
--- a/fs/nfs/idmap.c
+++ b/fs/nfs/idmap.c
@@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen,
}
rcu_read_lock();
- rkey->perm |= KEY_USR_VIEW;
+ rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE;
ret = key_validate(rkey);
if (ret < 0)
--
1.7.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] NFS: Make keys writable on the idmap keyring.
2012-02-07 13:02 [PATCH] NFS: Make keys writable on the idmap keyring Steve Dickson
@ 2012-02-07 23:29 ` James Morris
2012-02-08 16:34 ` Steve Dickson
2012-02-08 10:33 ` [Keyrings] " David Howells
1 sibling, 1 reply; 4+ messages in thread
From: James Morris @ 2012-02-07 23:29 UTC (permalink / raw)
To: Steve Dickson; +Cc: Linux Keyring Mailing list, Linux NFS Mailing list
Should this go in via the NFS tree? I can put it into the security tree
otherwise.
On Tue, 7 Feb 2012, Steve Dickson wrote:
> To take advantage of the "Allow special keyrings to be
> cleared" keyring patch the NFS keyring has to be writeable.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> fs/nfs/idmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
> index a1bbf77..1d88cdb 100644
> --- a/fs/nfs/idmap.c
> +++ b/fs/nfs/idmap.c
> @@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen,
> }
>
> rcu_read_lock();
> - rkey->perm |= KEY_USR_VIEW;
> + rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE;
>
> ret = key_validate(rkey);
> if (ret < 0)
> --
> 1.7.7.5
>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Keyrings] [PATCH] NFS: Make keys writable on the idmap keyring.
2012-02-07 13:02 [PATCH] NFS: Make keys writable on the idmap keyring Steve Dickson
2012-02-07 23:29 ` James Morris
@ 2012-02-08 10:33 ` David Howells
1 sibling, 0 replies; 4+ messages in thread
From: David Howells @ 2012-02-08 10:33 UTC (permalink / raw)
To: Steve Dickson
Cc: dhowells, James Morris, Linux Keyring Mailing list,
Linux NFS Mailing list
Steve Dickson <steved@redhat.com> wrote:
> To take advantage of the "Allow special keyrings to be
> cleared" keyring patch the NFS keyring has to be writeable.
That's not true.
I'll push the "Allow special keyrings to be cleared" keyring patch to James
now.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] NFS: Make keys writable on the idmap keyring.
2012-02-07 23:29 ` James Morris
@ 2012-02-08 16:34 ` Steve Dickson
0 siblings, 0 replies; 4+ messages in thread
From: Steve Dickson @ 2012-02-08 16:34 UTC (permalink / raw)
To: James Morris; +Cc: Linux Keyring Mailing list, Linux NFS Mailing list
I'm indifferent... as long as it gets in...
Personally I thought it should been be part of David's
"KEYS: Allow special keyrings to be cleared" patch
since NFS can not use that feature unless the
key is writable...
steved.
On 02/07/2012 06:29 PM, James Morris wrote:
> Should this go in via the NFS tree? I can put it into the security tree
> otherwise.
>
>
> On Tue, 7 Feb 2012, Steve Dickson wrote:
>
>> To take advantage of the "Allow special keyrings to be
>> cleared" keyring patch the NFS keyring has to be writeable.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> ---
>> fs/nfs/idmap.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c
>> index a1bbf77..1d88cdb 100644
>> --- a/fs/nfs/idmap.c
>> +++ b/fs/nfs/idmap.c
>> @@ -269,7 +269,7 @@ static ssize_t nfs_idmap_request_key(const char *name, size_t namelen,
>> }
>>
>> rcu_read_lock();
>> - rkey->perm |= KEY_USR_VIEW;
>> + rkey->perm |= KEY_USR_VIEW|KEY_USR_WRITE;
>>
>> ret = key_validate(rkey);
>> if (ret < 0)
>> --
>> 1.7.7.5
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-08 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-07 13:02 [PATCH] NFS: Make keys writable on the idmap keyring Steve Dickson
2012-02-07 23:29 ` James Morris
2012-02-08 16:34 ` Steve Dickson
2012-02-08 10:33 ` [Keyrings] " David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.