From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
ross.schm.dev@gmail.com, marcocesati@gmail.com,
saurav.girepunje@gmail.com, insafonov@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement
Date: Fri, 15 Oct 2021 11:15:14 +0200 [thread overview]
Message-ID: <13289545.LovHZTAFgE@localhost.localdomain> (raw)
In-Reply-To: <YWhBQF4yUH0/r53A@Sauravs-MacBook-Air.local>
On Thursday, October 14, 2021 4:40:00 PM CEST Saurav Girepunje wrote:
> Remove goto statement where function simply return value without doing
> any cleanup action.
>
> Simplify the return using goto label to avoid unneeded 'if' condition
> check.
>
> Remove the unneeded and redundant check of variable on goto.
>
> Remove the assignment of NULL on local variable.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>
> ChangeLog V3:
>
> -Remove goto statement where function simply return value
> without doing any cleanup action.
> -Remove the assignment of NULL on local variable.
> -Replace the goto statement added after the memcpy on V2.
> with return 0 statement.
>
> ChangeLog V2:
>
> -Add goto out after the memcpy for no error case return with
> ret only. On V1 doing free, which was not required for no error
> case.
You still don't explain why you changed v1. You had freed resources on
success path. That was not allowed because you introduced a change in the
logic and a huge bug. Therefore, in v2, you are not merely changing something
that "was not required". Instead you are changing something that is not
permitted.
Thanks,
Fabio
next prev parent reply other threads:[~2021-10-15 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 14:40 [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-14 14:49 ` Greg KH
2021-10-22 17:11 ` Saurav Girepunje
2021-10-14 14:57 ` Dan Carpenter
2021-10-22 17:14 ` Saurav Girepunje
2021-10-15 9:15 ` Fabio M. De Francesco [this message]
2021-10-22 17:18 ` Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13289545.LovHZTAFgE@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.