All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
	ross.schm.dev@gmail.com, marcocesati@gmail.com,
	insafonov@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement
Date: Thu, 14 Oct 2021 17:57:26 +0300	[thread overview]
Message-ID: <20211014145726.GO8429@kadam> (raw)
In-Reply-To: <YWhBQF4yUH0/r53A@Sauravs-MacBook-Air.local>

On Thu, Oct 14, 2021 at 08:10:00PM +0530, Saurav Girepunje wrote:
>  .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 29 ++++++++-----------
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> index 0868f56e2979..217b86bfb722 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> @@ -2281,19 +2281,16 @@ static int rtw_cfg80211_add_monitor_if(struct adapter *padapter, char *name, str
>  	struct rtw_wdev_priv *pwdev_priv = adapter_wdev_data(padapter);
> 
>  	if (!name) {
> -		ret = -EINVAL;
> -		goto out;
> +		return -EINVAL;
>  	}

You need to delete the curly braces, otherwise your patch will introduce
a checkpatch warning.  Same below as well.

regards,
dan carpenter


  parent reply	other threads:[~2021-10-14 14:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 14:40 [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement Saurav Girepunje
2021-10-14 14:49 ` Greg KH
2021-10-22 17:11   ` Saurav Girepunje
2021-10-14 14:57 ` Dan Carpenter [this message]
2021-10-22 17:14   ` Saurav Girepunje
2021-10-15  9:15 ` Fabio M. De Francesco
2021-10-22 17:18   ` Saurav Girepunje

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014145726.GO8429@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=marcocesati@gmail.com \
    --cc=ross.schm.dev@gmail.com \
    --cc=saurav.girepunje@gmail.com \
    --cc=saurav.girepunje@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.