Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement

From: Greg KH <gregkh@linuxfoundation.org>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com,
	marcocesati@gmail.com, insafonov@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	saurav.girepunje@hotmail.com
Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return statement
Date: Thu, 14 Oct 2021 16:49:19 +0200	[thread overview]
Message-ID: <YWhDb5/ZDUUs9gb7@kroah.com> (raw)
In-Reply-To: <YWhBQF4yUH0/r53A@Sauravs-MacBook-Air.local>

On Thu, Oct 14, 2021 at 08:10:00PM +0530, Saurav Girepunje wrote:
> Remove goto statement where function simply return value without doing
> any cleanup action.
> 
> Simplify the return using goto label to avoid unneeded 'if' condition
> check.
> 
> Remove the unneeded and redundant check of variable on goto.
> 
> Remove the assignment of NULL on local variable.

You are saying _what_ you are doing here, but not _why_ you are doing
this.  For example, this last sentance does not make sense, why would
you want to do such a thing (hint, I know, but you need to explain it in
the changelog...)

It's getting better, but the changelog still needs work.  Often times
that's the hardest part of writing a kernel patch.

thanks,

greg k-h