All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhengwang Ruan <ruan.zhengwang@gmail.com>
To: gregkh@linuxfoundation.org, arve@android.com,
	chris+android@zenthought.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used
Date: Wed,  7 Mar 2012 10:36:58 +0800	[thread overview]
Message-ID: <1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com> (raw)
In-Reply-To: <1331087818-9942-1-git-send-email-ruan.zhengwang@gmail.com>

GCC warns 'buffer' and 'buffer_size' are used with being uninitialized, and
'buffer' is used as returned value, and 'buffer_size' is initialized using
uninitialized_var to clear warning.

Signed-off-by: Zhengwang Ruan <ruan.zhengwang@gmail.com>
---
v2: added a subsystem prefix to the subject
---
 drivers/staging/android/binder.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 4350425..6caebeb 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -716,8 +716,8 @@ static struct binder_buffer *binder_alloc_buf(struct binder_proc *proc,
 					      size_t offsets_size, int is_async)
 {
 	struct rb_node *n = proc->free_buffers.rb_node;
-	struct binder_buffer *buffer;
-	size_t buffer_size;
+	struct binder_buffer *buffer = NULL;
+	size_t uninitialized_var(buffer_size);
 	struct rb_node *best_fit = NULL;
 	void *has_page_addr;
 	void *end_page_addr;
-- 
1.6.0.4


WARNING: multiple messages have this Message-ID (diff)
From: Zhengwang Ruan <ruan.zhengwang@gmail.com>
To: gregkh@linuxfoundation.org, arve@android.com,
	chris+android@zenthought.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used
Date: Wed, 07 Mar 2012 02:36:58 +0000	[thread overview]
Message-ID: <1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com> (raw)
In-Reply-To: <1331087818-9942-1-git-send-email-ruan.zhengwang@gmail.com>

GCC warns 'buffer' and 'buffer_size' are used with being uninitialized, and
'buffer' is used as returned value, and 'buffer_size' is initialized using
uninitialized_var to clear warning.

Signed-off-by: Zhengwang Ruan <ruan.zhengwang@gmail.com>
---
v2: added a subsystem prefix to the subject
---
 drivers/staging/android/binder.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 4350425..6caebeb 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -716,8 +716,8 @@ static struct binder_buffer *binder_alloc_buf(struct binder_proc *proc,
 					      size_t offsets_size, int is_async)
 {
 	struct rb_node *n = proc->free_buffers.rb_node;
-	struct binder_buffer *buffer;
-	size_t buffer_size;
+	struct binder_buffer *buffer = NULL;
+	size_t uninitialized_var(buffer_size);
 	struct rb_node *best_fit = NULL;
 	void *has_page_addr;
 	void *end_page_addr;
-- 
1.6.0.4


  reply	other threads:[~2012-03-07  2:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07  2:36 [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Zhengwang Ruan
2012-03-07  2:36 ` Zhengwang Ruan
2012-03-07  2:36 ` Zhengwang Ruan [this message]
2012-03-07  2:36   ` [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used Zhengwang Ruan
2012-03-07  4:01   ` Arve Hjønnevåg
2012-03-07  4:01     ` Arve Hjønnevåg
2012-03-07  4:58     ` Zhengwang Ruan
2012-03-07  4:58       ` Zhengwang Ruan
2012-03-07  5:46   ` Greg KH
2012-03-07  5:46     ` Greg KH
2012-03-07  6:16     ` Zhengwang Ruan
2012-03-07  6:16       ` Zhengwang Ruan
2012-03-07  5:58   ` Dan Carpenter
2012-03-07  6:00     ` Dan Carpenter
2012-03-07  6:01     ` Zhengwang Ruan
2012-03-07  6:01       ` Zhengwang Ruan
2012-03-07  6:20       ` Dan Carpenter
2012-03-07  6:20         ` Dan Carpenter
2012-03-07  6:25         ` Zhengwang Ruan
2012-03-07  6:25           ` Zhengwang Ruan
  -- strict thread matches above, loose matches on Subject: below --
2012-03-07  2:49 [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool ruan.zhengwang
2012-03-07  2:49 ` ruan.zhengwang
2012-03-07  2:49 ` [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used ruan.zhengwang
2012-03-07  2:49   ` ruan.zhengwang
2012-02-27 10:17 Zhengwang Ruan
2012-02-27 10:48 ` Dan Carpenter
2012-02-27 10:17 [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Zhengwang Ruan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com \
    --to=ruan.zhengwang@gmail.com \
    --cc=arve@android.com \
    --cc=chris+android@zenthought.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.