From: <ruan.zhengwang@gmail.com> To: <gregkh@linuxfoundation.org>, <arve@android.com>, <chris+android@zenthought.org> Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org> Subject: [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Date: Wed, 7 Mar 2012 10:49:09 +0800 [thread overview] Message-ID: <1331088550-15632-1-git-send-email-ruan.zhengwang@gmail.com> (raw) From: Zhengwang Ruan <ruan.zhengwang@gmail.com> GCC warns that module_param_named() indirectly returns a bool type value which is different from 'int' type binder_debug_no_lock declared. Change it to bool because it is a internal switch for debugging. Signed-off-by: Zhengwang Ruan <ruan.zhengwang@gmail.com> --- v2: added a subsystem prefix to the subject --- drivers/staging/android/binder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index f0b7e66..4350425 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -103,7 +103,7 @@ static uint32_t binder_debug_mask = BINDER_DEBUG_USER_ERROR | BINDER_DEBUG_FAILED_TRANSACTION | BINDER_DEBUG_DEAD_TRANSACTION; module_param_named(debug_mask, binder_debug_mask, uint, S_IWUSR | S_IRUGO); -static int binder_debug_no_lock; +static bool binder_debug_no_lock; module_param_named(proc_no_lock, binder_debug_no_lock, bool, S_IWUSR | S_IRUGO); static DECLARE_WAIT_QUEUE_HEAD(binder_user_error_wait); -- 1.6.0.4
WARNING: multiple messages have this Message-ID (diff)
From: <ruan.zhengwang@gmail.com> To: gregkh@linuxfoundation.org, arve@android.com, chris+android@zenthought.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Date: Wed, 07 Mar 2012 02:49:09 +0000 [thread overview] Message-ID: <1331088550-15632-1-git-send-email-ruan.zhengwang@gmail.com> (raw) In-Reply-To: <1330337871-27830-1-git-send-email-ruan.zhengwang@gmail.com> From: Zhengwang Ruan <ruan.zhengwang@gmail.com> GCC warns that module_param_named() indirectly returns a bool type value which is different from 'int' type binder_debug_no_lock declared. Change it to bool because it is a internal switch for debugging. Signed-off-by: Zhengwang Ruan <ruan.zhengwang@gmail.com> --- v2: added a subsystem prefix to the subject --- drivers/staging/android/binder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index f0b7e66..4350425 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -103,7 +103,7 @@ static uint32_t binder_debug_mask = BINDER_DEBUG_USER_ERROR | BINDER_DEBUG_FAILED_TRANSACTION | BINDER_DEBUG_DEAD_TRANSACTION; module_param_named(debug_mask, binder_debug_mask, uint, S_IWUSR | S_IRUGO); -static int binder_debug_no_lock; +static bool binder_debug_no_lock; module_param_named(proc_no_lock, binder_debug_no_lock, bool, S_IWUSR | S_IRUGO); static DECLARE_WAIT_QUEUE_HEAD(binder_user_error_wait); -- 1.6.0.4
next reply other threads:[~2012-03-07 2:49 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-03-07 2:49 ruan.zhengwang [this message] 2012-03-07 2:49 ` [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool ruan.zhengwang 2012-03-07 2:49 ` [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used ruan.zhengwang 2012-03-07 2:49 ` ruan.zhengwang -- strict thread matches above, loose matches on Subject: below -- 2012-03-07 2:36 [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Zhengwang Ruan 2012-03-07 2:36 ` Zhengwang Ruan 2012-03-07 2:36 ` [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used Zhengwang Ruan 2012-03-07 2:36 ` Zhengwang Ruan 2012-03-07 4:01 ` Arve Hjønnevåg 2012-03-07 4:01 ` Arve Hjønnevåg 2012-03-07 4:58 ` Zhengwang Ruan 2012-03-07 4:58 ` Zhengwang Ruan 2012-03-07 5:46 ` Greg KH 2012-03-07 5:46 ` Greg KH 2012-03-07 6:16 ` Zhengwang Ruan 2012-03-07 6:16 ` Zhengwang Ruan 2012-03-07 5:58 ` Dan Carpenter 2012-03-07 6:00 ` Dan Carpenter 2012-03-07 6:01 ` Zhengwang Ruan 2012-03-07 6:01 ` Zhengwang Ruan 2012-03-07 6:20 ` Dan Carpenter 2012-03-07 6:20 ` Dan Carpenter 2012-03-07 6:25 ` Zhengwang Ruan 2012-03-07 6:25 ` Zhengwang Ruan 2012-02-27 10:17 [PATCH 1/2 v2] Staging:android: Change type for binder_debug_no_lock switch to bool Zhengwang Ruan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1331088550-15632-1-git-send-email-ruan.zhengwang@gmail.com \ --to=ruan.zhengwang@gmail.com \ --cc=arve@android.com \ --cc=chris+android@zenthought.org \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.