* [PATCH] ASoC: core: Return -ENOTSUPP instead of -EINVAL if mute is not supported
@ 2012-04-13 18:22 Mark Brown
2012-04-16 15:00 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2012-04-13 18:22 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
This helps us ignore errors in callers if the operation failed due to not
being available as opposed to an error.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/soc-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 1ff0161..b957e68 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -3090,7 +3090,7 @@ int snd_soc_dai_digital_mute(struct snd_soc_dai *dai, int mute)
if (dai->driver && dai->driver->ops->digital_mute)
return dai->driver->ops->digital_mute(dai, mute);
else
- return -EINVAL;
+ return -ENOTSUPP;
}
EXPORT_SYMBOL_GPL(snd_soc_dai_digital_mute);
--
1.7.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: core: Return -ENOTSUPP instead of -EINVAL if mute is not supported
2012-04-13 18:22 [PATCH] ASoC: core: Return -ENOTSUPP instead of -EINVAL if mute is not supported Mark Brown
@ 2012-04-16 15:00 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2012-04-16 15:00 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, patches
On Fri, 2012-04-13 at 19:22 +0100, Mark Brown wrote:
> This helps us ignore errors in callers if the operation failed due to not
> being available as opposed to an error.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/soc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 1ff0161..b957e68 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -3090,7 +3090,7 @@ int snd_soc_dai_digital_mute(struct snd_soc_dai *dai, int mute)
> if (dai->driver && dai->driver->ops->digital_mute)
> return dai->driver->ops->digital_mute(dai, mute);
> else
> - return -EINVAL;
> + return -ENOTSUPP;
> }
> EXPORT_SYMBOL_GPL(snd_soc_dai_digital_mute);
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-16 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-13 18:22 [PATCH] ASoC: core: Return -ENOTSUPP instead of -EINVAL if mute is not supported Mark Brown
2012-04-16 15:00 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.