All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Peter Staubach <pstaubach@exagrid.com>
Cc: Steve Dickson <SteveD@redhat.com>,
	Jeff Layton <jlayton@redhat.com>,
	Malahal Naineni <malahal@us.ibm.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"miklos@szeredi.hu" <miklos@szeredi.hu>,
	"viro@ZenIV.linux.org.uk" <viro@ZenIV.linux.org.uk>,
	"hch@infradead.org" <hch@infradead.org>,
	"michael.brantley@deshaw.com" <michael.brantley@deshaw.com>
Subject: Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call
Date: Fri, 13 Apr 2012 20:57:59 -0400	[thread overview]
Message-ID: <1334365079.25130.21.camel@lade.trondhjem.org> (raw)
In-Reply-To: <2F609A9B-B44B-4CEA-BF35-D6BEDA729363@exagrid.com>

On Fri, 2012-04-13 at 13:34 -0400, Peter Staubach wrote:
> I still think that returning ESTALE to the application is just exposing a short coming in the implementation.  From a path based system like stat(), the application should see either ENOENT or some sort valid return.
> 
> I also look at the looping from the other side.  While possible, of course, I'd like to see someone construct a situation where it really happens.  By this, I don't mean a thought experiment, but a real running situation.
> 
> We already have evidence, in the form of the Solaris NFS client, that infinite looping does not happen in nature.

Could we turn that statistic around? Has the Solaris client ever seen a
loop of more than, say, 5 or 6 retries?

I'm just trying to limit the scope of the problem...

Cheers
  Trond


  parent reply	other threads:[~2012-04-14  1:14 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 11:25 [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call Jeff Layton
2012-04-13 11:25 ` Jeff Layton
2012-04-13 12:02 ` Jim Rees
2012-04-13 12:02   ` Jim Rees
2012-04-13 12:09   ` Jeff Layton
2012-04-13 12:09     ` Jeff Layton
2012-04-13 15:05 ` Malahal Naineni
2012-04-13 15:42   ` Jeff Layton
2012-04-13 16:07     ` Steve Dickson
2012-04-13 17:10       ` Jeff Layton
2012-04-13 17:10         ` Jeff Layton
2012-04-13 17:34       ` Peter Staubach
2012-04-13 17:34         ` Peter Staubach
2012-04-13 23:00         ` Jeff Layton
2012-04-13 23:00           ` Jeff Layton
2012-04-14  0:57         ` Trond Myklebust [this message]
2012-04-15 19:03     ` Bernd Schubert
2012-04-15 19:27       ` J. Bruce Fields
2012-04-15 19:27         ` J. Bruce Fields
2012-04-16 14:23         ` Bernd Schubert
2012-04-15 19:57       ` Chuck Lever
2012-04-15 19:57         ` Chuck Lever
2012-04-16 11:23         ` Jeff Layton
2012-04-17 11:53         ` Steve Dickson
2012-04-16 11:36       ` Jeff Layton
2012-04-16 11:36         ` Jeff Layton
2012-04-16 12:54         ` Peter Staubach
2012-04-16 12:54           ` Peter Staubach
2012-04-16 16:04           ` Jeff Layton
2012-04-16 14:44         ` Bernd Schubert
2012-04-16 17:46           ` Jeff Layton
2012-04-16 17:46             ` Jeff Layton
2012-04-16 19:33             ` Myklebust, Trond
2012-04-16 19:33               ` Myklebust, Trond
2012-04-16 19:33               ` Myklebust, Trond
2012-04-16 19:43               ` Jeff Layton
2012-04-16 20:25                 ` Myklebust, Trond
2012-04-16 20:25                   ` Myklebust, Trond
2012-04-16 20:25                   ` Myklebust, Trond
2012-04-16 23:05                   ` Jeff Layton
2012-04-17 11:46                     ` Steve Dickson
2012-04-17 11:46                       ` Steve Dickson
2012-04-17 13:36                       ` Jeff Layton
2012-04-17 13:36                         ` Jeff Layton
2012-04-17 14:14                         ` Steve Dickson
2012-04-17 14:14                           ` Steve Dickson
2012-04-17 14:27                           ` Miklos Szeredi
2012-04-17 15:02                             ` Jeff Layton
2012-04-17 15:50                               ` Miklos Szeredi
2012-04-17 15:50                                 ` Miklos Szeredi
2012-04-17 16:03                                 ` Jeff Layton
2012-04-17 16:03                                   ` Jeff Layton
2012-04-17 15:59                               ` Steve Dickson
2012-04-17 15:59                                 ` Steve Dickson
2012-04-17 13:12                     ` Miklos Szeredi
2012-04-17 13:32                       ` Jeff Layton
2012-04-17 14:03                         ` Miklos Szeredi
2012-04-17 14:22                           ` Jeff Layton
2012-04-17 14:22                             ` Jeff Layton
2012-04-17 14:04                         ` Myklebust, Trond
2012-04-17 14:04                           ` Myklebust, Trond
2012-04-17 14:04                           ` Myklebust, Trond
2012-04-17 14:20                           ` Jeff Layton
2012-04-17 15:45                             ` J. Bruce Fields
2012-04-17 15:45                               ` J. Bruce Fields
2012-04-17 16:02                               ` Miklos Szeredi
2012-04-17 16:02                                 ` Miklos Szeredi
2012-04-17 13:39                     ` Peter Staubach
2012-04-17 14:08                       ` Myklebust, Trond
2012-04-17 14:08                         ` Myklebust, Trond
2012-04-17 14:08                         ` Myklebust, Trond
2012-04-17 14:48                         ` Peter Staubach
2012-04-17 14:48                           ` Peter Staubach
2012-04-17 14:48                           ` Peter Staubach
2012-04-18 15:16                           ` Jeff Layton
2012-04-18 15:16                             ` Jeff Layton
2012-04-16 19:43             ` Scott Lovenberg
2012-04-16 19:43               ` Scott Lovenberg
2012-04-16 16:55 ` [PATCH RFC v2] " Jeff Layton
2012-04-18 11:52 ` [PATCH RFC v3] vfs: make fstatat retry once " Jeff Layton
2012-04-18 11:52   ` Jeff Layton
2012-04-20 14:40   ` Jeff Layton
2012-04-20 20:18     ` Steve Dickson
2012-04-20 20:18       ` Steve Dickson
2012-04-20 20:37       ` Malahal Naineni
2012-04-20 20:37         ` Malahal Naineni
2012-04-20 21:13         ` Jeff Layton
2012-04-22  5:40           ` Miklos Szeredi
2012-04-23 12:00             ` Jeff Layton
2012-04-23 12:00               ` Jeff Layton
2012-04-23 13:00               ` J. Bruce Fields
2012-04-23 13:00                 ` J. Bruce Fields
2012-04-23 13:12                 ` Jeff Layton
2012-04-23 13:12                   ` Jeff Layton
2012-04-23 13:34                   ` J. Bruce Fields
2012-04-23 13:34                     ` J. Bruce Fields
2012-04-23 13:50                     ` Jeff Layton
2012-04-23 13:50                       ` Jeff Layton
2012-04-23 13:54                       ` J. Bruce Fields
2012-04-23 14:51                         ` Miklos Szeredi
2012-04-23 15:02                           ` Chuck Lever
2012-04-23 15:02                             ` Chuck Lever
2012-04-23 15:23                             ` Miklos Szeredi
2012-04-23 17:45                               ` Peter Staubach
2012-04-23 15:16                           ` Jeff Layton
2012-04-23 15:16                             ` Jeff Layton
2012-04-23 15:28                             ` Miklos Szeredi
2012-04-23 18:59                               ` Jeff Layton
2012-04-20 21:13       ` Jeff Layton
2012-04-20 21:13         ` Jeff Layton
2012-04-23 14:55         ` Steve Dickson
2012-04-23 14:55           ` Steve Dickson
2012-04-23 15:32           ` Jeff Layton
2012-04-23 15:32             ` Jeff Layton
2012-04-23 18:06             ` Steve Dickson
2012-04-23 18:06               ` Steve Dickson
2012-04-23 18:33               ` Jeff Layton
2012-04-23 20:38               ` Peter Staubach
2012-04-23 20:38                 ` Peter Staubach
2012-04-24 14:50                 ` Jeff Layton
2012-04-24 15:54                   ` Miklos Szeredi
2012-04-24 15:54                     ` Miklos Szeredi
2012-04-24 16:34                     ` Jeff Layton
2012-04-25  9:41                       ` Miklos Szeredi
2012-04-25  9:41                         ` Miklos Szeredi
2012-04-25 12:04                         ` Jeff Layton
2012-04-25 12:04                           ` Jeff Layton
2012-04-23 17:43           ` Peter Staubach
2012-04-23 17:43             ` Peter Staubach
2012-04-23 19:06           ` Malahal Naineni
2012-04-23 19:06             ` Malahal Naineni
2012-04-22  4:16     ` Ric Wheeler
2012-04-22  4:16       ` Ric Wheeler
2012-04-23 11:20       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334365079.25130.21.camel@lade.trondhjem.org \
    --to=trond.myklebust@fys.uio.no \
    --cc=SteveD@redhat.com \
    --cc=hch@infradead.org \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=malahal@us.ibm.com \
    --cc=michael.brantley@deshaw.com \
    --cc=miklos@szeredi.hu \
    --cc=pstaubach@exagrid.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.