All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sha Zhengju <handai.szj@gmail.com>
To: linux-mm@kvack.org, cgroups@vger.kernel.org
Cc: kamezawa.hiroyu@jp.fujitsu.com, gthelen@google.com,
	yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz,
	linux-kernel@vger.kernel.org, Sha Zhengju <handai.szj@taobao.com>
Subject: [PATCH 7/7] memcg: print more detailed info while memcg oom happening
Date: Thu, 28 Jun 2012 19:06:49 +0800	[thread overview]
Message-ID: <1340881609-5935-1-git-send-email-handai.szj@taobao.com> (raw)
In-Reply-To: <1340880885-5427-1-git-send-email-handai.szj@taobao.com>

From: Sha Zhengju <handai.szj@taobao.com>

While memcg oom happening, the dump info is limited, so add this
to provide memcg page stat.

Signed-off-by: Sha Zhengju <handai.szj@taobao.com>
---
 mm/memcontrol.c |   42 ++++++++++++++++++++++++++++++++++--------
 1 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 8493119..3ed41e9 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -101,6 +101,14 @@ static const char * const mem_cgroup_events_names[] = {
 	"pgmajfault",
 };
 
+static const char * const mem_cgroup_lru_names[] = {
+	"inactive_anon",
+	"active_anon",
+	"inactive_file",
+	"active_file",
+	"unevictable",
+};
+
 /*
  * Per memcg event counter is incremented at every pagein/pageout. With THP,
  * it will be incremated by the number of pages. This counter is used for
@@ -1358,6 +1366,30 @@ static void move_unlock_mem_cgroup(struct mem_cgroup *memcg,
 	spin_unlock_irqrestore(&memcg->move_lock, *flags);
 }
 
+#define K(x) ((x) << (PAGE_SHIFT-10))
+static void mem_cgroup_print_oom_stat(struct mem_cgroup *memcg)
+{
+	int i;
+
+	printk(KERN_INFO "Memory cgroup stat:\n");
+	for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) {
+		if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account)
+			continue;
+		printk(KERN_CONT "%s:%ldKB ", mem_cgroup_stat_names[i],
+			   K(mem_cgroup_read_stat(memcg, i)));
+	}
+
+	for (i = 0; i < MEM_CGROUP_EVENTS_NSTATS; i++)
+		printk(KERN_CONT "%s:%lu ", mem_cgroup_events_names[i],
+			   mem_cgroup_read_events(memcg, i));
+
+	for (i = 0; i < NR_LRU_LISTS; i++)
+		printk(KERN_CONT "%s:%luKB ", mem_cgroup_lru_names[i],
+			   K(mem_cgroup_nr_lru_pages(memcg, BIT(i))));
+	printk(KERN_CONT "\n");
+
+}
+
 /**
  * mem_cgroup_print_oom_info: Called from OOM with tasklist_lock held in read mode.
  * @memcg: The memory cgroup that went over limit
@@ -1422,6 +1454,8 @@ done:
 		res_counter_read_u64(&memcg->memsw, RES_USAGE) >> 10,
 		res_counter_read_u64(&memcg->memsw, RES_LIMIT) >> 10,
 		res_counter_read_u64(&memcg->memsw, RES_FAILCNT));
+
+	mem_cgroup_print_oom_stat(memcg);
 }
 
 /*
@@ -4043,14 +4077,6 @@ static int mem_control_numa_stat_show(struct cgroup *cont, struct cftype *cft,
 }
 #endif /* CONFIG_NUMA */
 
-static const char * const mem_cgroup_lru_names[] = {
-	"inactive_anon",
-	"active_anon",
-	"inactive_file",
-	"active_file",
-	"unevictable",
-};
-
 static inline void mem_cgroup_lru_names_not_uptodate(void)
 {
 	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
-- 
1.7.1


WARNING: multiple messages have this Message-ID (diff)
From: Sha Zhengju <handai.szj@gmail.com>
To: linux-mm@kvack.org, cgroups@vger.kernel.org
Cc: kamezawa.hiroyu@jp.fujitsu.com, gthelen@google.com,
	yinghan@google.com, akpm@linux-foundation.org, mhocko@suse.cz,
	linux-kernel@vger.kernel.org, Sha Zhengju <handai.szj@taobao.com>
Subject: [PATCH 7/7] memcg: print more detailed info while memcg oom happening
Date: Thu, 28 Jun 2012 19:06:49 +0800	[thread overview]
Message-ID: <1340881609-5935-1-git-send-email-handai.szj@taobao.com> (raw)
In-Reply-To: <1340880885-5427-1-git-send-email-handai.szj@taobao.com>

From: Sha Zhengju <handai.szj@taobao.com>

While memcg oom happening, the dump info is limited, so add this
to provide memcg page stat.

Signed-off-by: Sha Zhengju <handai.szj@taobao.com>
---
 mm/memcontrol.c |   42 ++++++++++++++++++++++++++++++++++--------
 1 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 8493119..3ed41e9 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -101,6 +101,14 @@ static const char * const mem_cgroup_events_names[] = {
 	"pgmajfault",
 };
 
+static const char * const mem_cgroup_lru_names[] = {
+	"inactive_anon",
+	"active_anon",
+	"inactive_file",
+	"active_file",
+	"unevictable",
+};
+
 /*
  * Per memcg event counter is incremented at every pagein/pageout. With THP,
  * it will be incremated by the number of pages. This counter is used for
@@ -1358,6 +1366,30 @@ static void move_unlock_mem_cgroup(struct mem_cgroup *memcg,
 	spin_unlock_irqrestore(&memcg->move_lock, *flags);
 }
 
+#define K(x) ((x) << (PAGE_SHIFT-10))
+static void mem_cgroup_print_oom_stat(struct mem_cgroup *memcg)
+{
+	int i;
+
+	printk(KERN_INFO "Memory cgroup stat:\n");
+	for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) {
+		if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account)
+			continue;
+		printk(KERN_CONT "%s:%ldKB ", mem_cgroup_stat_names[i],
+			   K(mem_cgroup_read_stat(memcg, i)));
+	}
+
+	for (i = 0; i < MEM_CGROUP_EVENTS_NSTATS; i++)
+		printk(KERN_CONT "%s:%lu ", mem_cgroup_events_names[i],
+			   mem_cgroup_read_events(memcg, i));
+
+	for (i = 0; i < NR_LRU_LISTS; i++)
+		printk(KERN_CONT "%s:%luKB ", mem_cgroup_lru_names[i],
+			   K(mem_cgroup_nr_lru_pages(memcg, BIT(i))));
+	printk(KERN_CONT "\n");
+
+}
+
 /**
  * mem_cgroup_print_oom_info: Called from OOM with tasklist_lock held in read mode.
  * @memcg: The memory cgroup that went over limit
@@ -1422,6 +1454,8 @@ done:
 		res_counter_read_u64(&memcg->memsw, RES_USAGE) >> 10,
 		res_counter_read_u64(&memcg->memsw, RES_LIMIT) >> 10,
 		res_counter_read_u64(&memcg->memsw, RES_FAILCNT));
+
+	mem_cgroup_print_oom_stat(memcg);
 }
 
 /*
@@ -4043,14 +4077,6 @@ static int mem_control_numa_stat_show(struct cgroup *cont, struct cftype *cft,
 }
 #endif /* CONFIG_NUMA */
 
-static const char * const mem_cgroup_lru_names[] = {
-	"inactive_anon",
-	"active_anon",
-	"inactive_file",
-	"active_file",
-	"unevictable",
-};
-
 static inline void mem_cgroup_lru_names_not_uptodate(void)
 {
 	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sha Zhengju <handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
	gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	mhocko-AlSwsSmVLrQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 7/7] memcg: print more detailed info while memcg oom happening
Date: Thu, 28 Jun 2012 19:06:49 +0800	[thread overview]
Message-ID: <1340881609-5935-1-git-send-email-handai.szj@taobao.com> (raw)
In-Reply-To: <1340880885-5427-1-git-send-email-handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>

From: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>

While memcg oom happening, the dump info is limited, so add this
to provide memcg page stat.

Signed-off-by: Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>
---
 mm/memcontrol.c |   42 ++++++++++++++++++++++++++++++++++--------
 1 files changed, 34 insertions(+), 8 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 8493119..3ed41e9 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -101,6 +101,14 @@ static const char * const mem_cgroup_events_names[] = {
 	"pgmajfault",
 };
 
+static const char * const mem_cgroup_lru_names[] = {
+	"inactive_anon",
+	"active_anon",
+	"inactive_file",
+	"active_file",
+	"unevictable",
+};
+
 /*
  * Per memcg event counter is incremented at every pagein/pageout. With THP,
  * it will be incremated by the number of pages. This counter is used for
@@ -1358,6 +1366,30 @@ static void move_unlock_mem_cgroup(struct mem_cgroup *memcg,
 	spin_unlock_irqrestore(&memcg->move_lock, *flags);
 }
 
+#define K(x) ((x) << (PAGE_SHIFT-10))
+static void mem_cgroup_print_oom_stat(struct mem_cgroup *memcg)
+{
+	int i;
+
+	printk(KERN_INFO "Memory cgroup stat:\n");
+	for (i = 0; i < MEM_CGROUP_STAT_NSTATS; i++) {
+		if (i == MEM_CGROUP_STAT_SWAP && !do_swap_account)
+			continue;
+		printk(KERN_CONT "%s:%ldKB ", mem_cgroup_stat_names[i],
+			   K(mem_cgroup_read_stat(memcg, i)));
+	}
+
+	for (i = 0; i < MEM_CGROUP_EVENTS_NSTATS; i++)
+		printk(KERN_CONT "%s:%lu ", mem_cgroup_events_names[i],
+			   mem_cgroup_read_events(memcg, i));
+
+	for (i = 0; i < NR_LRU_LISTS; i++)
+		printk(KERN_CONT "%s:%luKB ", mem_cgroup_lru_names[i],
+			   K(mem_cgroup_nr_lru_pages(memcg, BIT(i))));
+	printk(KERN_CONT "\n");
+
+}
+
 /**
  * mem_cgroup_print_oom_info: Called from OOM with tasklist_lock held in read mode.
  * @memcg: The memory cgroup that went over limit
@@ -1422,6 +1454,8 @@ done:
 		res_counter_read_u64(&memcg->memsw, RES_USAGE) >> 10,
 		res_counter_read_u64(&memcg->memsw, RES_LIMIT) >> 10,
 		res_counter_read_u64(&memcg->memsw, RES_FAILCNT));
+
+	mem_cgroup_print_oom_stat(memcg);
 }
 
 /*
@@ -4043,14 +4077,6 @@ static int mem_control_numa_stat_show(struct cgroup *cont, struct cftype *cft,
 }
 #endif /* CONFIG_NUMA */
 
-static const char * const mem_cgroup_lru_names[] = {
-	"inactive_anon",
-	"active_anon",
-	"inactive_file",
-	"active_file",
-	"unevictable",
-};
-
 static inline void mem_cgroup_lru_names_not_uptodate(void)
 {
 	BUILD_BUG_ON(ARRAY_SIZE(mem_cgroup_lru_names) != NR_LRU_LISTS);
-- 
1.7.1

  parent reply	other threads:[~2012-06-28 11:07 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 10:54 [PATCH 0/7] Per-cgroup page stat accounting Sha Zhengju
2012-06-28 10:54 ` Sha Zhengju
2012-06-28 10:54 ` Sha Zhengju
2012-06-28 10:57 ` [PATCH 1/7] memcg: update cgroup memory document Sha Zhengju
2012-06-28 10:57   ` Sha Zhengju
2012-06-28 10:57   ` Sha Zhengju
2012-07-02  7:00   ` Kamezawa Hiroyuki
2012-07-02  7:00     ` Kamezawa Hiroyuki
2012-07-04 12:47   ` Michal Hocko
2012-07-04 12:47     ` Michal Hocko
2012-07-04 12:47     ` Michal Hocko
2012-07-07 13:45   ` Fengguang Wu
2012-07-07 13:45     ` Fengguang Wu
2012-07-07 13:45     ` Fengguang Wu
2012-06-28 10:58 ` [PATCH 2/7] memcg: remove MEMCG_NR_FILE_MAPPED Sha Zhengju
2012-06-28 10:58   ` Sha Zhengju
2012-07-02 10:44   ` Kamezawa Hiroyuki
2012-07-02 10:44     ` Kamezawa Hiroyuki
2012-07-02 10:44     ` Kamezawa Hiroyuki
2012-07-04 12:56   ` Michal Hocko
2012-07-04 12:56     ` Michal Hocko
2012-07-04 12:58     ` Michal Hocko
2012-07-04 12:58       ` Michal Hocko
2012-07-04 12:58       ` Michal Hocko
2012-07-07 13:48   ` Fengguang Wu
2012-07-07 13:48     ` Fengguang Wu
2012-07-09 21:01   ` Greg Thelen
2012-07-09 21:01     ` Greg Thelen
2012-07-09 21:01     ` Greg Thelen
2012-07-11  8:00     ` Sha Zhengju
2012-07-11  8:00       ` Sha Zhengju
2012-06-28 11:01 ` [PATCH 3/7] Make TestSetPageDirty and dirty page accounting in one func Sha Zhengju
2012-06-28 11:01   ` Sha Zhengju
2012-07-02 11:14   ` Kamezawa Hiroyuki
2012-07-02 11:14     ` Kamezawa Hiroyuki
2012-07-02 11:14     ` Kamezawa Hiroyuki
2012-07-07 14:42     ` Fengguang Wu
2012-07-07 14:42       ` Fengguang Wu
2012-07-04 14:23   ` Michal Hocko
2012-07-04 14:23     ` Michal Hocko
2012-06-28 11:03 ` [PATCH 4/7] Use vfs __set_page_dirty interface instead of doing it inside filesystem Sha Zhengju
2012-06-28 11:03   ` Sha Zhengju
2012-06-28 11:03   ` Sha Zhengju
2012-06-29  5:21   ` Sage Weil
2012-06-29  5:21     ` Sage Weil
2012-06-29  5:21     ` Sage Weil
2012-07-02  8:10     ` Sha Zhengju
2012-07-02  8:10       ` Sha Zhengju
2012-07-02 14:49       ` Sage Weil
2012-07-02 14:49         ` Sage Weil
2012-07-04  8:11         ` Sha Zhengju
2012-07-04  8:11           ` Sha Zhengju
2012-07-05 15:20           ` Sage Weil
2012-07-05 15:20             ` Sage Weil
2012-07-05 15:40             ` Sha Zhengju
2012-07-05 15:40               ` Sha Zhengju
2012-07-04 14:27   ` Michal Hocko
2012-07-04 14:27     ` Michal Hocko
2012-06-28 11:04 ` [PATCH 5/7] memcg: add per cgroup dirty pages accounting Sha Zhengju
2012-06-28 11:04   ` Sha Zhengju
2012-06-28 11:04   ` Sha Zhengju
2012-07-03  5:57   ` Kamezawa Hiroyuki
2012-07-03  5:57     ` Kamezawa Hiroyuki
2012-07-08 14:45     ` Fengguang Wu
2012-07-08 14:45       ` Fengguang Wu
2012-07-04 16:11   ` Michal Hocko
2012-07-04 16:11     ` Michal Hocko
2012-07-04 16:11     ` Michal Hocko
2012-07-09 21:02   ` Greg Thelen
2012-07-09 21:02     ` Greg Thelen
2012-07-11  9:32     ` Sha Zhengju
2012-07-11  9:32       ` Sha Zhengju
2012-07-19  6:33       ` Kamezawa Hiroyuki
2012-07-19  6:33         ` Kamezawa Hiroyuki
2012-07-19  6:33         ` Kamezawa Hiroyuki
2012-06-28 11:05 ` [PATCH 6/7] memcg: add per cgroup writeback " Sha Zhengju
2012-06-28 11:05   ` Sha Zhengju
2012-07-03  6:31   ` Kamezawa Hiroyuki
2012-07-03  6:31     ` Kamezawa Hiroyuki
2012-07-04  8:24     ` Sha Zhengju
2012-07-04  8:24       ` Sha Zhengju
2012-07-08 14:44     ` Fengguang Wu
2012-07-08 14:44       ` Fengguang Wu
2012-07-08 23:01       ` Johannes Weiner
2012-07-08 23:01         ` Johannes Weiner
2012-07-09  1:37         ` Fengguang Wu
2012-07-09  1:37           ` Fengguang Wu
2012-07-09  1:37           ` Fengguang Wu
2012-07-04 16:15   ` Michal Hocko
2012-07-04 16:15     ` Michal Hocko
2012-06-28 11:06 ` Sha Zhengju
2012-06-28 11:06   ` Sha Zhengju
2012-06-28 11:06   ` Sha Zhengju
2012-07-08 14:53   ` Fengguang Wu
2012-07-08 14:53     ` Fengguang Wu
2012-07-08 14:53     ` Fengguang Wu
2012-07-09  3:36     ` Sha Zhengju
2012-07-09  3:36       ` Sha Zhengju
2012-07-09  3:36       ` Sha Zhengju
2012-07-09  4:14       ` Fengguang Wu
2012-07-09  4:14         ` Fengguang Wu
2012-07-09  4:14         ` Fengguang Wu
2012-07-09  4:18         ` Kamezawa Hiroyuki
2012-07-09  4:18           ` Kamezawa Hiroyuki
2012-07-09  5:22           ` Sha Zhengju
2012-07-09  5:22             ` Sha Zhengju
2012-07-09  5:22             ` Sha Zhengju
2012-07-09  5:28             ` Fengguang Wu
2012-07-09  5:28               ` Fengguang Wu
2012-07-09  5:28               ` Fengguang Wu
2012-07-09  5:19         ` Sha Zhengju
2012-07-09  5:19           ` Sha Zhengju
2012-07-09  5:25           ` Fengguang Wu
2012-07-09  5:25             ` Fengguang Wu
2012-07-09 21:02   ` Greg Thelen
2012-07-09 21:02     ` Greg Thelen
2012-06-28 11:06 ` Sha Zhengju [this message]
2012-06-28 11:06   ` [PATCH 7/7] memcg: print more detailed info while memcg oom happening Sha Zhengju
2012-06-28 11:06   ` Sha Zhengju
2012-07-04  8:25   ` Sha Zhengju
2012-07-04  8:25     ` Sha Zhengju
2012-07-04  8:25     ` Sha Zhengju
2012-07-04  8:29   ` Kamezawa Hiroyuki
2012-07-04  8:29     ` Kamezawa Hiroyuki
2012-07-04 11:20     ` Sha Zhengju
2012-07-04 11:20       ` Sha Zhengju
2012-07-04 11:20       ` Sha Zhengju
2012-06-29  8:23 ` [PATCH 0/7] Per-cgroup page stat accounting Kamezawa Hiroyuki
2012-06-29  8:23   ` Kamezawa Hiroyuki
2012-07-02  7:51   ` Sha Zhengju
2012-07-02  7:51     ` Sha Zhengju
2012-07-02  7:51     ` Sha Zhengju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340881609-5935-1-git-send-email-handai.szj@taobao.com \
    --to=handai.szj@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=gthelen@google.com \
    --cc=handai.szj@taobao.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.