From: Paolo Bonzini <pbonzini@redhat.com> To: linux-kernel@vger.kernel.org Cc: snitzer@redhat.com, david@fromorbit.com, dm-devel@redhat.com, xfs@oss.sgi.com, hch@lst.de, martin.petersen@oracle.com, axboe@kernel.dk Subject: [PATCH v2 0/3] block: improvements for discard alignment Date: Mon, 2 Jul 2012 15:20:22 +0200 [thread overview] Message-ID: <1341235225-27551-1-git-send-email-pbonzini@redhat.com> (raw) When a disk has a large discard_granularity, discards are not split with optimal alignment; the pessimization gets bigger as discard_granularity and max_discard_sectors become closer. Take the limit case of discard_granularity == max_discard_sectors == 64. Then, if a request is submitted for 256 sectors 2..257 it will be split like this: 2..65, 66..129, 130..193, 194..257. None of these requests is aligned, so in fact you might end up with no discarded logical blocks at all. With this patch, the split will be 2..63, 64..127, 128..191, 192..255, 256..257. The patches also take the discard_alignment into consideration. For ease of debugging, patch 1 adds a sysfs entry for discard_alignment. Patch 2 adjusts the computation of the granularity-adjusted max_discard_sectors so that it prepares for the new code in patch 3, which 3 actually adjusts the split. v1->v2: added patch 1, fixed line length Paolo Bonzini (3): block: add sysfs entry for discard_alignment block: reorganize rounding of max_discard_sectors block: split discard into aligned requests block/blk-lib.c | 41 ++++++++++++++++++++++++++++------------- block/blk-sysfs.c | 11 +++++++++++ 2 files changed, 39 insertions(+), 13 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: linux-kernel@vger.kernel.org Cc: axboe@kernel.dk, snitzer@redhat.com, martin.petersen@oracle.com, xfs@oss.sgi.com, dm-devel@redhat.com, hch@lst.de Subject: [PATCH v2 0/3] block: improvements for discard alignment Date: Mon, 2 Jul 2012 15:20:22 +0200 [thread overview] Message-ID: <1341235225-27551-1-git-send-email-pbonzini@redhat.com> (raw) When a disk has a large discard_granularity, discards are not split with optimal alignment; the pessimization gets bigger as discard_granularity and max_discard_sectors become closer. Take the limit case of discard_granularity == max_discard_sectors == 64. Then, if a request is submitted for 256 sectors 2..257 it will be split like this: 2..65, 66..129, 130..193, 194..257. None of these requests is aligned, so in fact you might end up with no discarded logical blocks at all. With this patch, the split will be 2..63, 64..127, 128..191, 192..255, 256..257. The patches also take the discard_alignment into consideration. For ease of debugging, patch 1 adds a sysfs entry for discard_alignment. Patch 2 adjusts the computation of the granularity-adjusted max_discard_sectors so that it prepares for the new code in patch 3, which 3 actually adjusts the split. v1->v2: added patch 1, fixed line length Paolo Bonzini (3): block: add sysfs entry for discard_alignment block: reorganize rounding of max_discard_sectors block: split discard into aligned requests block/blk-lib.c | 41 ++++++++++++++++++++++++++++------------- block/blk-sysfs.c | 11 +++++++++++ 2 files changed, 39 insertions(+), 13 deletions(-) _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-07-02 13:20 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-02 13:20 Paolo Bonzini [this message] 2012-07-02 13:20 ` [PATCH v2 0/3] block: improvements for discard alignment Paolo Bonzini 2012-07-02 13:20 ` [PATCH v2 1/3] block: add sysfs entry for discard_alignment Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini 2012-07-03 2:34 ` [dm-devel] " Vivek Goyal 2012-07-03 2:34 ` Vivek Goyal 2012-07-03 3:59 ` Mike Snitzer 2012-07-03 3:59 ` Mike Snitzer 2012-07-03 11:51 ` [dm-devel] " Paolo Bonzini 2012-07-03 11:51 ` Paolo Bonzini 2012-07-03 14:00 ` Vivek Goyal 2012-07-03 14:00 ` Vivek Goyal 2012-07-03 14:21 ` Paolo Bonzini 2012-07-03 14:21 ` Paolo Bonzini 2012-07-03 14:39 ` Vivek Goyal 2012-07-03 14:39 ` Vivek Goyal 2012-07-03 14:40 ` Paolo Bonzini 2012-07-03 14:40 ` Paolo Bonzini 2012-07-03 14:45 ` Vivek Goyal 2012-07-03 14:45 ` Vivek Goyal 2012-07-02 13:20 ` [PATCH v2 2/3] block: reorganize rounding of max_discard_sectors Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini 2012-07-03 2:49 ` [dm-devel] " Vivek Goyal 2012-07-03 2:49 ` Vivek Goyal 2012-07-03 11:47 ` Paolo Bonzini 2012-07-03 11:47 ` Paolo Bonzini 2012-07-02 13:20 ` [PATCH v2 3/3] block: split discard into aligned requests Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1341235225-27551-1-git-send-email-pbonzini@redhat.com \ --to=pbonzini@redhat.com \ --cc=axboe@kernel.dk \ --cc=david@fromorbit.com \ --cc=dm-devel@redhat.com \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=snitzer@redhat.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.