From: Paolo Bonzini <pbonzini@redhat.com> To: linux-kernel@vger.kernel.org Cc: snitzer@redhat.com, david@fromorbit.com, dm-devel@redhat.com, xfs@oss.sgi.com, hch@lst.de, martin.petersen@oracle.com, axboe@kernel.dk Subject: [PATCH v2 1/3] block: add sysfs entry for discard_alignment Date: Mon, 2 Jul 2012 15:20:23 +0200 [thread overview] Message-ID: <1341235225-27551-2-git-send-email-pbonzini@redhat.com> (raw) In-Reply-To: <1341235225-27551-1-git-send-email-pbonzini@redhat.com> The next patches will actually use the alignment, expose it in sysfs for ease of debugging. Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- block/blk-sysfs.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index aa41b47..95e919c 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -146,6 +146,11 @@ static ssize_t queue_io_opt_show(struct request_queue *q, char *page) return queue_var_show(queue_io_opt(q), page); } +static ssize_t queue_discard_alignment_show(struct request_queue *q, char *page) +{ + return queue_var_show(q->limits.discard_alignment, page); +} + static ssize_t queue_discard_granularity_show(struct request_queue *q, char *page) { return queue_var_show(q->limits.discard_granularity, page); @@ -343,6 +348,11 @@ static struct queue_sysfs_entry queue_io_opt_entry = { .show = queue_io_opt_show, }; +static struct queue_sysfs_entry queue_discard_alignment_entry = { + .attr = {.name = "discard_alignment", .mode = S_IRUGO }, + .show = queue_discard_alignment_show, +}; + static struct queue_sysfs_entry queue_discard_granularity_entry = { .attr = {.name = "discard_granularity", .mode = S_IRUGO }, .show = queue_discard_granularity_show, @@ -403,6 +413,7 @@ static struct attribute *default_attrs[] = { &queue_io_min_entry.attr, &queue_io_opt_entry.attr, &queue_discard_granularity_entry.attr, + &queue_discard_alignment_entry.attr, &queue_discard_max_entry.attr, &queue_discard_zeroes_data_entry.attr, &queue_nonrot_entry.attr, -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: linux-kernel@vger.kernel.org Cc: axboe@kernel.dk, snitzer@redhat.com, martin.petersen@oracle.com, xfs@oss.sgi.com, dm-devel@redhat.com, hch@lst.de Subject: [PATCH v2 1/3] block: add sysfs entry for discard_alignment Date: Mon, 2 Jul 2012 15:20:23 +0200 [thread overview] Message-ID: <1341235225-27551-2-git-send-email-pbonzini@redhat.com> (raw) In-Reply-To: <1341235225-27551-1-git-send-email-pbonzini@redhat.com> The next patches will actually use the alignment, expose it in sysfs for ease of debugging. Cc: Jens Axboe <axboe@kernel.dk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- block/blk-sysfs.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index aa41b47..95e919c 100644 --- a/block/blk-sysfs.c +++ b/block/blk-sysfs.c @@ -146,6 +146,11 @@ static ssize_t queue_io_opt_show(struct request_queue *q, char *page) return queue_var_show(queue_io_opt(q), page); } +static ssize_t queue_discard_alignment_show(struct request_queue *q, char *page) +{ + return queue_var_show(q->limits.discard_alignment, page); +} + static ssize_t queue_discard_granularity_show(struct request_queue *q, char *page) { return queue_var_show(q->limits.discard_granularity, page); @@ -343,6 +348,11 @@ static struct queue_sysfs_entry queue_io_opt_entry = { .show = queue_io_opt_show, }; +static struct queue_sysfs_entry queue_discard_alignment_entry = { + .attr = {.name = "discard_alignment", .mode = S_IRUGO }, + .show = queue_discard_alignment_show, +}; + static struct queue_sysfs_entry queue_discard_granularity_entry = { .attr = {.name = "discard_granularity", .mode = S_IRUGO }, .show = queue_discard_granularity_show, @@ -403,6 +413,7 @@ static struct attribute *default_attrs[] = { &queue_io_min_entry.attr, &queue_io_opt_entry.attr, &queue_discard_granularity_entry.attr, + &queue_discard_alignment_entry.attr, &queue_discard_max_entry.attr, &queue_discard_zeroes_data_entry.attr, &queue_nonrot_entry.attr, -- 1.7.1 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-02 13:20 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-02 13:20 [PATCH v2 0/3] block: improvements for discard alignment Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini [this message] 2012-07-02 13:20 ` [PATCH v2 1/3] block: add sysfs entry for discard_alignment Paolo Bonzini 2012-07-03 2:34 ` [dm-devel] " Vivek Goyal 2012-07-03 2:34 ` Vivek Goyal 2012-07-03 3:59 ` Mike Snitzer 2012-07-03 3:59 ` Mike Snitzer 2012-07-03 11:51 ` [dm-devel] " Paolo Bonzini 2012-07-03 11:51 ` Paolo Bonzini 2012-07-03 14:00 ` Vivek Goyal 2012-07-03 14:00 ` Vivek Goyal 2012-07-03 14:21 ` Paolo Bonzini 2012-07-03 14:21 ` Paolo Bonzini 2012-07-03 14:39 ` Vivek Goyal 2012-07-03 14:39 ` Vivek Goyal 2012-07-03 14:40 ` Paolo Bonzini 2012-07-03 14:40 ` Paolo Bonzini 2012-07-03 14:45 ` Vivek Goyal 2012-07-03 14:45 ` Vivek Goyal 2012-07-02 13:20 ` [PATCH v2 2/3] block: reorganize rounding of max_discard_sectors Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini 2012-07-03 2:49 ` [dm-devel] " Vivek Goyal 2012-07-03 2:49 ` Vivek Goyal 2012-07-03 11:47 ` Paolo Bonzini 2012-07-03 11:47 ` Paolo Bonzini 2012-07-02 13:20 ` [PATCH v2 3/3] block: split discard into aligned requests Paolo Bonzini 2012-07-02 13:20 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1341235225-27551-2-git-send-email-pbonzini@redhat.com \ --to=pbonzini@redhat.com \ --cc=axboe@kernel.dk \ --cc=david@fromorbit.com \ --cc=dm-devel@redhat.com \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=snitzer@redhat.com \ --cc=xfs@oss.sgi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.