All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Vladimir Kondratiev <vkondrat_qca@qca.qualcomm.com>
Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
	"John W . Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org,
	"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH 60g v2 0/5] Infrastructure for 60g (802.11ad)
Date: Mon, 02 Jul 2012 17:08:05 +0200	[thread overview]
Message-ID: <1341241685.19642.15.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <5202151.WBzXQarS2v@lx-vladimir>

On Mon, 2012-07-02 at 18:01 +0300, Vladimir Kondratiev wrote:

> So, now I'll focus on the last patch - bitrate calculation.
> 
> My plan is:
> 
> - add new element like NL80211_RATE_INFO_BITRATE_HT with u32 data
> - change nl80211_put_sta_rate() to fill both
>   NL80211_RATE_INFO_BITRATE (with u16 value)
>   and NL80211_RATE_INFO_BITRATE_HT (with u32 value)
> - when bitrate not fit into u16, put 0 for u16 value and fill only u32

I think you should leave out the BITRATE value completely, not fill it
with 0.

> This opens migration path for the drivers and user space tools to the
> new u32 representation without breaking existing code.

Other than that, yes, good plan.

johannes


  reply	other threads:[~2012-07-02 15:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02  6:32 [PATCH 60g v2 0/5] Infrastructure for 60g (802.11ad) Vladimir Kondratiev
2012-07-02  6:32 ` [PATCH 60g v2 1/5] wireless: add 802.11ad (60gHz band) Vladimir Kondratiev
2012-07-02 14:22   ` Arik Nemtsov
2012-07-02 15:12     ` Johannes Berg
2012-07-02 15:15       ` Arik Nemtsov
2012-07-02  6:32 ` [PATCH 60g v2 2/5] wireless: rate check logic for 60g Vladimir Kondratiev
2012-07-02 13:02   ` Johannes Berg
2012-07-02  6:32 ` [PATCH 60g v2 3/5] wireless: regulatory " Vladimir Kondratiev
2012-07-02  6:32 ` [PATCH 60g v2 4/5] wireless: 60g protocol constants Vladimir Kondratiev
2012-07-02  6:32 ` [PATCH 60g v2 5/5] wireless: bitrate calculation for 60g Vladimir Kondratiev
2012-07-02 12:54   ` Johannes Berg
2012-07-02 12:54 ` [PATCH 60g v2 0/5] Infrastructure for 60g (802.11ad) Johannes Berg
2012-07-02 12:58   ` Johannes Berg
2012-07-02 15:01     ` Vladimir Kondratiev
2012-07-02 15:08       ` Johannes Berg [this message]
2012-07-03  4:15         ` Julian Calaby
2012-07-03  6:50           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341241685.19642.15.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=qca_vkondrat@qca.qualcomm.com \
    --cc=rodrigue@qca.qualcomm.com \
    --cc=vkondrat_qca@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.