All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arik Nemtsov <anamtsov@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
	"John W . Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org,
	"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH 60g v2 1/5] wireless: add 802.11ad (60gHz band)
Date: Mon, 2 Jul 2012 18:15:58 +0300	[thread overview]
Message-ID: <CA+XVXfebumem+DMgsmUSd7vr7ZaK+x-S2gxzu8BAhB-KoXTr6Q@mail.gmail.com> (raw)
In-Reply-To: <1341241929.19642.17.camel@jlt3.sipsolutions.net>

On Mon, Jul 2, 2012 at 6:12 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Mon, 2012-07-02 at 17:22 +0300, Arik Nemtsov wrote:
>
>> enum ieee80211_band {
>>       IEEE80211_BAND_2GHZ = NL80211_BAND_2GHZ,
>>       IEEE80211_BAND_5GHZ = NL80211_BAND_5GHZ,
>>
>>       /* keep last */
>>       IEEE80211_NUM_BANDS
>> };
>>
>> If the 60Ghz band goes here as well, IEEE80211_NUM_BANDS will be
>> incremented.
>
> Yes, this happened.
>
>> I'm guessing this can be problematic for a lot of drivers
>> that use this value more or less blindly (and pass indices to FW etc).
>> At least the wlcore driver will be impacted.
>>
>> So this probably should be added, but maybe keep IEEE80211_NUM_BANDS
>> the same for legacy reasons?
>
> Can't do that, it's used for array sizing etc.
>
> It looks like your driver may crash as it accesses bands[x] for all
> possible values of x ... might want to fix that soon as I've applied
> these patches :)

Yes. That's the alternative :)

  reply	other threads:[~2012-07-02 15:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-02  6:32 [PATCH 60g v2 0/5] Infrastructure for 60g (802.11ad) Vladimir Kondratiev
2012-07-02  6:32 ` [PATCH 60g v2 1/5] wireless: add 802.11ad (60gHz band) Vladimir Kondratiev
2012-07-02 14:22   ` Arik Nemtsov
2012-07-02 15:12     ` Johannes Berg
2012-07-02 15:15       ` Arik Nemtsov [this message]
2012-07-02  6:32 ` [PATCH 60g v2 2/5] wireless: rate check logic for 60g Vladimir Kondratiev
2012-07-02 13:02   ` Johannes Berg
2012-07-02  6:32 ` [PATCH 60g v2 3/5] wireless: regulatory " Vladimir Kondratiev
2012-07-02  6:32 ` [PATCH 60g v2 4/5] wireless: 60g protocol constants Vladimir Kondratiev
2012-07-02  6:32 ` [PATCH 60g v2 5/5] wireless: bitrate calculation for 60g Vladimir Kondratiev
2012-07-02 12:54   ` Johannes Berg
2012-07-02 12:54 ` [PATCH 60g v2 0/5] Infrastructure for 60g (802.11ad) Johannes Berg
2012-07-02 12:58   ` Johannes Berg
2012-07-02 15:01     ` Vladimir Kondratiev
2012-07-02 15:08       ` Johannes Berg
2012-07-03  4:15         ` Julian Calaby
2012-07-03  6:50           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+XVXfebumem+DMgsmUSd7vr7ZaK+x-S2gxzu8BAhB-KoXTr6Q@mail.gmail.com \
    --to=anamtsov@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=qca_vkondrat@qca.qualcomm.com \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.