From: Guennadi Liakhovetski <g.liakhovetski@gmx.de> To: Vinod Koul <vinod.koul@intel.com> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7 v2] dmaengine: shdma: (cosmetic) simplify a static function Date: Thu, 05 Jul 2012 10:29:37 +0000 [thread overview] Message-ID: <1341484183-10757-2-git-send-email-g.liakhovetski@gmx.de> (raw) In-Reply-To: <1341484183-10757-1-git-send-email-g.liakhovetski@gmx.de> dmae_find_slave() needs only the slave_id field from the slave object, no need to pass the pointer to the object, pass the slave_id directly. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- drivers/dma/sh/shdma.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/sh/shdma.c b/drivers/dma/sh/shdma.c index c393b35..f06906f 100644 --- a/drivers/dma/sh/shdma.c +++ b/drivers/dma/sh/shdma.c @@ -304,18 +304,18 @@ static void sh_dmae_setup_xfer(struct shdma_chan *schan, } static const struct sh_dmae_slave_config *dmae_find_slave( - struct sh_dmae_chan *sh_chan, struct sh_dmae_slave *slave) + struct sh_dmae_chan *sh_chan, unsigned int slave_id) { struct sh_dmae_device *shdev = to_sh_dev(sh_chan); struct sh_dmae_pdata *pdata = shdev->pdata; const struct sh_dmae_slave_config *cfg; int i; - if (slave->shdma_slave.slave_id >= SH_DMA_SLAVE_NUMBER) + if (slave_id >= SH_DMA_SLAVE_NUMBER) return NULL; for (i = 0, cfg = pdata->slave; i < pdata->slave_num; i++, cfg++) - if (cfg->slave_id = slave->shdma_slave.slave_id) + if (cfg->slave_id = slave_id) return cfg; return NULL; @@ -328,7 +328,7 @@ static int sh_dmae_set_slave(struct shdma_chan *schan, shdma_chan); struct sh_dmae_slave *slave = container_of(sslave, struct sh_dmae_slave, shdma_slave); - const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, slave); + const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, sslave->slave_id); if (!cfg) return -ENODEV; -- 1.7.2.5
WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de> To: Vinod Koul <vinod.koul@intel.com> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7 v2] dmaengine: shdma: (cosmetic) simplify a static function Date: Thu, 5 Jul 2012 12:29:37 +0200 [thread overview] Message-ID: <1341484183-10757-2-git-send-email-g.liakhovetski@gmx.de> (raw) In-Reply-To: <1341484183-10757-1-git-send-email-g.liakhovetski@gmx.de> dmae_find_slave() needs only the slave_id field from the slave object, no need to pass the pointer to the object, pass the slave_id directly. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- drivers/dma/sh/shdma.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma/sh/shdma.c b/drivers/dma/sh/shdma.c index c393b35..f06906f 100644 --- a/drivers/dma/sh/shdma.c +++ b/drivers/dma/sh/shdma.c @@ -304,18 +304,18 @@ static void sh_dmae_setup_xfer(struct shdma_chan *schan, } static const struct sh_dmae_slave_config *dmae_find_slave( - struct sh_dmae_chan *sh_chan, struct sh_dmae_slave *slave) + struct sh_dmae_chan *sh_chan, unsigned int slave_id) { struct sh_dmae_device *shdev = to_sh_dev(sh_chan); struct sh_dmae_pdata *pdata = shdev->pdata; const struct sh_dmae_slave_config *cfg; int i; - if (slave->shdma_slave.slave_id >= SH_DMA_SLAVE_NUMBER) + if (slave_id >= SH_DMA_SLAVE_NUMBER) return NULL; for (i = 0, cfg = pdata->slave; i < pdata->slave_num; i++, cfg++) - if (cfg->slave_id == slave->shdma_slave.slave_id) + if (cfg->slave_id == slave_id) return cfg; return NULL; @@ -328,7 +328,7 @@ static int sh_dmae_set_slave(struct shdma_chan *schan, shdma_chan); struct sh_dmae_slave *slave = container_of(sslave, struct sh_dmae_slave, shdma_slave); - const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, slave); + const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, sslave->slave_id); if (!cfg) return -ENODEV; -- 1.7.2.5
next prev parent reply other threads:[~2012-07-05 10:29 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-05 10:29 [PATCH 0/7 v2] dma: sh: stop using .private Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski [this message] 2012-07-05 10:29 ` [PATCH 1/7 v2] dmaengine: shdma: (cosmetic) simplify a static function Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 2/7 v2] ASoC: siu: don't use DMA device for channel filtering Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 12:08 ` Mark Brown 2012-07-05 12:08 ` Mark Brown 2012-07-05 13:54 ` Guennadi Liakhovetski 2012-07-05 13:54 ` Guennadi Liakhovetski 2012-07-05 14:00 ` Mark Brown 2012-07-05 14:00 ` Mark Brown 2012-07-05 14:08 ` Guennadi Liakhovetski 2012-07-05 14:08 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 3/7 v2] sh: remove unused DMA device pointer from SIU platform data Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 4/7 v2] dmaengine: shdma: prepare to stop using struct dma_chan::private Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-16 6:07 ` Vinod Koul 2012-07-16 6:19 ` Vinod Koul 2012-07-16 6:37 ` Guennadi Liakhovetski 2012-07-16 6:37 ` Guennadi Liakhovetski 2012-07-16 6:53 ` Vinod Koul 2012-07-16 6:57 ` Vinod Koul 2012-07-16 7:13 ` Guennadi Liakhovetski 2012-07-16 7:13 ` Guennadi Liakhovetski 2012-07-16 8:28 ` Vinod Koul 2012-07-16 8:40 ` Vinod Koul 2012-07-16 8:47 ` Guennadi Liakhovetski 2012-07-16 8:47 ` Guennadi Liakhovetski 2012-07-16 9:37 ` Vinod Koul 2012-07-16 9:49 ` Vinod Koul 2012-07-16 10:01 ` Guennadi Liakhovetski 2012-07-16 10:01 ` Guennadi Liakhovetski 2012-07-16 10:24 ` Vinod Koul 2012-07-16 10:36 ` Vinod Koul 2012-07-16 10:55 ` Guennadi Liakhovetski 2012-07-16 10:55 ` Guennadi Liakhovetski 2012-07-16 11:12 ` Vinod Koul 2012-07-16 11:24 ` Vinod Koul 2012-07-16 12:47 ` Guennadi Liakhovetski 2012-07-16 12:47 ` Guennadi Liakhovetski 2012-07-18 3:14 ` Vinod Koul 2012-07-18 3:26 ` Vinod Koul 2012-07-18 8:34 ` Guennadi Liakhovetski 2012-07-18 8:34 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 6/7 v2] dma: sh: provide a migration path for slave drivers to stop using .private Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-16 6:19 ` Vinod Koul 2012-07-16 6:31 ` Vinod Koul 2012-07-16 6:31 ` Guennadi Liakhovetski 2012-07-16 6:31 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 7/7 v2] mmc: sh_mmcif: switch to the new DMA channel allocation and configuration Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-20 6:00 ` [PATCH 0/7 v2] dma: sh: stop using .private Vinod Koul 2012-07-20 6:12 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1341484183-10757-2-git-send-email-g.liakhovetski@gmx.de \ --to=g.liakhovetski@gmx.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.