From: Vinod Koul <vinod.koul@linux.intel.com> To: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility Date: Mon, 16 Jul 2012 09:49:32 +0000 [thread overview] Message-ID: <1342431452.1726.54.camel@vkoul-udesk3> (raw) In-Reply-To: <Pine.LNX.4.64.1207161040070.12302@axis700.grange> On Mon, 2012-07-16 at 10:47 +0200, Guennadi Liakhovetski wrote: > > I want to know what does ccr and mid_rid mean to dmac here? > > CHCR contains a few fields, some enable various interrupt sources, some > specify repeat- and renew-modes, others yet specify transfer size, source > and destination address-modes (incrementing, constant, decrementing), > others yet select a DMA client category (slave / memcpy / ...), and a > transfer flag. Some of these fields could be calculated, others are > pre-defined for various slaves, the exact layout of those fields can also > vary between SoCs. I do not understand how clients would provide these values. For pre-defined values, they should be dmac property why should client like spi or mmc have clue about it? For others like you mentioned, i guess they could be easily calculated, right? > MID_RID is actually a slave-selector, it contains a magic value, that > cannot be calculated. and again, how does client know this? -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@linux.intel.com> To: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Cc: Magnus Damm <magnus.damm@gmail.com>, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility Date: Mon, 16 Jul 2012 15:07:32 +0530 [thread overview] Message-ID: <1342431452.1726.54.camel@vkoul-udesk3> (raw) In-Reply-To: <Pine.LNX.4.64.1207161040070.12302@axis700.grange> On Mon, 2012-07-16 at 10:47 +0200, Guennadi Liakhovetski wrote: > > I want to know what does ccr and mid_rid mean to dmac here? > > CHCR contains a few fields, some enable various interrupt sources, some > specify repeat- and renew-modes, others yet specify transfer size, source > and destination address-modes (incrementing, constant, decrementing), > others yet select a DMA client category (slave / memcpy / ...), and a > transfer flag. Some of these fields could be calculated, others are > pre-defined for various slaves, the exact layout of those fields can also > vary between SoCs. I do not understand how clients would provide these values. For pre-defined values, they should be dmac property why should client like spi or mmc have clue about it? For others like you mentioned, i guess they could be easily calculated, right? > MID_RID is actually a slave-selector, it contains a magic value, that > cannot be calculated. and again, how does client know this? -- ~Vinod
next prev parent reply other threads:[~2012-07-16 9:49 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-05 10:29 [PATCH 0/7 v2] dma: sh: stop using .private Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 1/7 v2] dmaengine: shdma: (cosmetic) simplify a static function Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 2/7 v2] ASoC: siu: don't use DMA device for channel filtering Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 12:08 ` Mark Brown 2012-07-05 12:08 ` Mark Brown 2012-07-05 13:54 ` Guennadi Liakhovetski 2012-07-05 13:54 ` Guennadi Liakhovetski 2012-07-05 14:00 ` Mark Brown 2012-07-05 14:00 ` Mark Brown 2012-07-05 14:08 ` Guennadi Liakhovetski 2012-07-05 14:08 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 3/7 v2] sh: remove unused DMA device pointer from SIU platform data Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 4/7 v2] dmaengine: shdma: prepare to stop using struct dma_chan::private Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 5/7 v2] dma: sh: use an integer slave ID to improve API compatibility Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-16 6:07 ` Vinod Koul 2012-07-16 6:19 ` Vinod Koul 2012-07-16 6:37 ` Guennadi Liakhovetski 2012-07-16 6:37 ` Guennadi Liakhovetski 2012-07-16 6:53 ` Vinod Koul 2012-07-16 6:57 ` Vinod Koul 2012-07-16 7:13 ` Guennadi Liakhovetski 2012-07-16 7:13 ` Guennadi Liakhovetski 2012-07-16 8:28 ` Vinod Koul 2012-07-16 8:40 ` Vinod Koul 2012-07-16 8:47 ` Guennadi Liakhovetski 2012-07-16 8:47 ` Guennadi Liakhovetski 2012-07-16 9:37 ` Vinod Koul [this message] 2012-07-16 9:49 ` Vinod Koul 2012-07-16 10:01 ` Guennadi Liakhovetski 2012-07-16 10:01 ` Guennadi Liakhovetski 2012-07-16 10:24 ` Vinod Koul 2012-07-16 10:36 ` Vinod Koul 2012-07-16 10:55 ` Guennadi Liakhovetski 2012-07-16 10:55 ` Guennadi Liakhovetski 2012-07-16 11:12 ` Vinod Koul 2012-07-16 11:24 ` Vinod Koul 2012-07-16 12:47 ` Guennadi Liakhovetski 2012-07-16 12:47 ` Guennadi Liakhovetski 2012-07-18 3:14 ` Vinod Koul 2012-07-18 3:26 ` Vinod Koul 2012-07-18 8:34 ` Guennadi Liakhovetski 2012-07-18 8:34 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 6/7 v2] dma: sh: provide a migration path for slave drivers to stop using .private Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-16 6:19 ` Vinod Koul 2012-07-16 6:31 ` Vinod Koul 2012-07-16 6:31 ` Guennadi Liakhovetski 2012-07-16 6:31 ` Guennadi Liakhovetski 2012-07-05 10:29 ` [PATCH 7/7 v2] mmc: sh_mmcif: switch to the new DMA channel allocation and configuration Guennadi Liakhovetski 2012-07-05 10:29 ` Guennadi Liakhovetski 2012-07-20 6:00 ` [PATCH 0/7 v2] dma: sh: stop using .private Vinod Koul 2012-07-20 6:12 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1342431452.1726.54.camel@vkoul-udesk3 \ --to=vinod.koul@linux.intel.com \ --cc=g.liakhovetski@gmx.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.