From: Tero Kristo <t-kristo@ti.com> To: linux-omap@vger.kernel.org, paul@pwsan.com, khilman@ti.com Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle Date: Fri, 13 Jul 2012 17:19:45 +0300 [thread overview] Message-ID: <1342189185-5306-9-git-send-email-t-kristo@ti.com> (raw) In-Reply-To: <1342189185-5306-1-git-send-email-t-kristo@ti.com> Previously, PER clock domain was always enabled, as the usecounts for this domain incorrectly always showed positive value. On HW level though, the domain enters idle as it is set in HW supervised mode. Now, when the usecounts reflect real values, PER domain will be put to HWSUP sleep mode, which means its autodeps are deleted. Removing wakedeps for PER domain will cause multiple problems. First of all, coming back from idle, PER domain remains idle as the wakedeps have been disabled for the domain, and this causes a crash with the GPIO code, as the resume code attempts to access domain which is not active. Just enabling the interface clocks for the GPIO does not help, as they are autoidled and don't bring the domain out of idle. Secondly, there are multiple erratas for omap3, which say that the wakedeps should be enabled for the PER domain, see e.g. errata i582 for omap3630. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c index 6038adb..5658440 100644 --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c @@ -282,7 +282,7 @@ static struct clockdomain usbhost_clkdm = { static struct clockdomain per_clkdm = { .name = "per_clkdm", .pwrdm = { .name = "per_pwrdm" }, - .flags = CLKDM_CAN_HWSUP_SWSUP, + .flags = CLKDM_CAN_HWSUP_SWSUP | CLKDM_NO_AUTODEP_DISABLE, .dep_bit = OMAP3430_EN_PER_SHIFT, .wkdep_srcs = per_wkdeps, .sleepdep_srcs = per_sleepdeps, -- 1.7.4.1
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle Date: Fri, 13 Jul 2012 17:19:45 +0300 [thread overview] Message-ID: <1342189185-5306-9-git-send-email-t-kristo@ti.com> (raw) In-Reply-To: <1342189185-5306-1-git-send-email-t-kristo@ti.com> Previously, PER clock domain was always enabled, as the usecounts for this domain incorrectly always showed positive value. On HW level though, the domain enters idle as it is set in HW supervised mode. Now, when the usecounts reflect real values, PER domain will be put to HWSUP sleep mode, which means its autodeps are deleted. Removing wakedeps for PER domain will cause multiple problems. First of all, coming back from idle, PER domain remains idle as the wakedeps have been disabled for the domain, and this causes a crash with the GPIO code, as the resume code attempts to access domain which is not active. Just enabling the interface clocks for the GPIO does not help, as they are autoidled and don't bring the domain out of idle. Secondly, there are multiple erratas for omap3, which say that the wakedeps should be enabled for the PER domain, see e.g. errata i582 for omap3630. Signed-off-by: Tero Kristo <t-kristo@ti.com> --- arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c index 6038adb..5658440 100644 --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c @@ -282,7 +282,7 @@ static struct clockdomain usbhost_clkdm = { static struct clockdomain per_clkdm = { .name = "per_clkdm", .pwrdm = { .name = "per_pwrdm" }, - .flags = CLKDM_CAN_HWSUP_SWSUP, + .flags = CLKDM_CAN_HWSUP_SWSUP | CLKDM_NO_AUTODEP_DISABLE, .dep_bit = OMAP3430_EN_PER_SHIFT, .wkdep_srcs = per_wkdeps, .sleepdep_srcs = per_sleepdeps, -- 1.7.4.1
next prev parent reply other threads:[~2012-07-13 14:20 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-13 14:19 [PATCHv4 0/8] ARM: OMAP: pm: usecounting changes Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-13 14:19 ` [PATCHv4 1/8] ARM: OMAP: clk: add support for omap_clk_for_each Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 10:04 ` Rajendra Nayak 2012-07-16 10:04 ` Rajendra Nayak 2012-07-16 11:42 ` Tero Kristo 2012-07-16 11:42 ` Tero Kristo 2012-07-13 14:19 ` [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 10:15 ` Rajendra Nayak 2012-07-16 10:15 ` Rajendra Nayak 2012-07-27 19:14 ` Kevin Hilman 2012-07-27 19:14 ` Kevin Hilman 2012-08-06 23:31 ` Kevin Hilman 2012-08-06 23:31 ` Kevin Hilman 2012-09-07 9:23 ` Tero Kristo 2012-09-07 9:23 ` Tero Kristo 2012-07-13 14:19 ` [PATCHv4 3/8] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 10:23 ` Rajendra Nayak 2012-07-16 10:23 ` Rajendra Nayak 2012-07-24 20:58 ` Vishwanath Sripathy 2012-07-24 20:58 ` Vishwanath Sripathy 2012-07-25 8:07 ` Tero Kristo 2012-07-25 8:07 ` Tero Kristo 2012-07-13 14:19 ` [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 10:30 ` Rajendra Nayak 2012-07-16 10:30 ` Rajendra Nayak 2012-07-27 19:36 ` Kevin Hilman 2012-07-27 19:36 ` Kevin Hilman 2012-07-30 8:40 ` Tero Kristo 2012-07-30 8:40 ` Tero Kristo 2012-08-06 10:14 ` Jean Pihet 2012-08-06 10:14 ` Jean Pihet 2012-09-07 9:30 ` Tero Kristo 2012-09-07 9:30 ` Tero Kristo 2012-09-07 21:48 ` Kevin Hilman 2012-09-07 21:48 ` Kevin Hilman 2012-08-06 23:32 ` Kevin Hilman 2012-08-06 23:32 ` Kevin Hilman 2012-07-13 14:19 ` [PATCHv4 5/8] ARM: OMAP3: set autoidle flag for sdrc_ick Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 10:39 ` Rajendra Nayak 2012-07-16 10:39 ` Rajendra Nayak 2012-07-13 14:19 ` [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 10:50 ` Rajendra Nayak 2012-07-16 10:50 ` Rajendra Nayak 2012-07-16 11:45 ` Tero Kristo 2012-07-16 11:45 ` Tero Kristo 2012-07-16 12:14 ` Rajendra Nayak 2012-07-16 12:14 ` Rajendra Nayak 2012-07-27 19:55 ` Kevin Hilman 2012-07-27 19:55 ` Kevin Hilman 2012-07-30 8:36 ` Tero Kristo 2012-07-30 8:36 ` Tero Kristo 2012-07-13 14:19 ` [PATCHv4 7/8] ARM: OMAP: clockdomain: add support for preventing autodep delete Tero Kristo 2012-07-13 14:19 ` Tero Kristo 2012-07-16 11:00 ` Rajendra Nayak 2012-07-16 11:00 ` Rajendra Nayak 2012-07-17 14:56 ` Tero Kristo 2012-07-17 14:56 ` Tero Kristo 2012-07-17 21:31 ` Paul Walmsley 2012-07-17 21:31 ` Paul Walmsley 2012-07-18 7:15 ` Rajendra Nayak 2012-07-18 7:15 ` Rajendra Nayak 2012-07-18 8:05 ` Tero Kristo 2012-07-18 8:05 ` Tero Kristo 2012-07-18 9:04 ` Rajendra Nayak 2012-07-18 9:04 ` Rajendra Nayak 2012-07-18 9:16 ` Tero Kristo 2012-07-18 9:16 ` Tero Kristo 2012-07-27 20:12 ` Kevin Hilman 2012-07-27 20:12 ` Kevin Hilman 2012-07-13 14:19 ` Tero Kristo [this message] 2012-07-13 14:19 ` [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle Tero Kristo 2012-09-18 22:25 ` Paul Walmsley 2012-09-18 22:25 ` Paul Walmsley 2012-09-18 22:43 ` Paul Walmsley 2012-09-18 22:43 ` Paul Walmsley 2012-09-19 22:15 ` Kevin Hilman 2012-09-19 22:15 ` Kevin Hilman 2012-10-16 7:29 ` Paul Walmsley 2012-10-16 7:29 ` Paul Walmsley 2012-10-17 0:39 ` Kevin Hilman 2012-10-17 0:39 ` Kevin Hilman 2012-10-31 11:59 ` Tero Kristo 2012-10-31 11:59 ` Tero Kristo 2012-09-19 9:06 ` Tero Kristo 2012-09-19 9:06 ` Tero Kristo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1342189185-5306-9-git-send-email-t-kristo@ti.com \ --to=t-kristo@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.