From: Kevin Hilman <khilman@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking
Date: Fri, 27 Jul 2012 12:14:59 -0700 [thread overview]
Message-ID: <87k3xpj9sc.fsf@ti.com> (raw)
In-Reply-To: <1342189185-5306-3-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 13 Jul 2012 17:19:39 +0300")
Tero Kristo <t-kristo@ti.com> writes:
> This patch fixes the usecount tracking for omap3+, previously the
> usecount numbers were rather bogus and were not really useful for
> any purpose. Now usecount numbers track the number of really active
> clients on each domain. This patch also adds support for usecount
> tracking on powerdomain level and autoidle flag for clocks that
> are hardware controlled and should be skipped in usecount
> calculations.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Kevin Hilman <khilman@ti.com>
Minor nit: please avoid using BUG_ON() which will panic the whole
kernel. Proper error detection is preferred, but your usage, a
WARN_ON() should suffice.
Otherwise,
Reviewed-by: Kevin Hilman <khilman@ti.com>
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking
Date: Fri, 27 Jul 2012 12:14:59 -0700 [thread overview]
Message-ID: <87k3xpj9sc.fsf@ti.com> (raw)
In-Reply-To: <1342189185-5306-3-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Fri, 13 Jul 2012 17:19:39 +0300")
Tero Kristo <t-kristo@ti.com> writes:
> This patch fixes the usecount tracking for omap3+, previously the
> usecount numbers were rather bogus and were not really useful for
> any purpose. Now usecount numbers track the number of really active
> clients on each domain. This patch also adds support for usecount
> tracking on powerdomain level and autoidle flag for clocks that
> are hardware controlled and should be skipped in usecount
> calculations.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Kevin Hilman <khilman@ti.com>
Minor nit: please avoid using BUG_ON() which will panic the whole
kernel. Proper error detection is preferred, but your usage, a
WARN_ON() should suffice.
Otherwise,
Reviewed-by: Kevin Hilman <khilman@ti.com>
Kevin
next prev parent reply other threads:[~2012-07-27 19:15 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 14:19 [PATCHv4 0/8] ARM: OMAP: pm: usecounting changes Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 1/8] ARM: OMAP: clk: add support for omap_clk_for_each Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:04 ` Rajendra Nayak
2012-07-16 10:04 ` Rajendra Nayak
2012-07-16 11:42 ` Tero Kristo
2012-07-16 11:42 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:15 ` Rajendra Nayak
2012-07-16 10:15 ` Rajendra Nayak
2012-07-27 19:14 ` Kevin Hilman [this message]
2012-07-27 19:14 ` Kevin Hilman
2012-08-06 23:31 ` Kevin Hilman
2012-08-06 23:31 ` Kevin Hilman
2012-09-07 9:23 ` Tero Kristo
2012-09-07 9:23 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 3/8] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:23 ` Rajendra Nayak
2012-07-16 10:23 ` Rajendra Nayak
2012-07-24 20:58 ` Vishwanath Sripathy
2012-07-24 20:58 ` Vishwanath Sripathy
2012-07-25 8:07 ` Tero Kristo
2012-07-25 8:07 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:30 ` Rajendra Nayak
2012-07-16 10:30 ` Rajendra Nayak
2012-07-27 19:36 ` Kevin Hilman
2012-07-27 19:36 ` Kevin Hilman
2012-07-30 8:40 ` Tero Kristo
2012-07-30 8:40 ` Tero Kristo
2012-08-06 10:14 ` Jean Pihet
2012-08-06 10:14 ` Jean Pihet
2012-09-07 9:30 ` Tero Kristo
2012-09-07 9:30 ` Tero Kristo
2012-09-07 21:48 ` Kevin Hilman
2012-09-07 21:48 ` Kevin Hilman
2012-08-06 23:32 ` Kevin Hilman
2012-08-06 23:32 ` Kevin Hilman
2012-07-13 14:19 ` [PATCHv4 5/8] ARM: OMAP3: set autoidle flag for sdrc_ick Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:39 ` Rajendra Nayak
2012-07-16 10:39 ` Rajendra Nayak
2012-07-13 14:19 ` [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:50 ` Rajendra Nayak
2012-07-16 10:50 ` Rajendra Nayak
2012-07-16 11:45 ` Tero Kristo
2012-07-16 11:45 ` Tero Kristo
2012-07-16 12:14 ` Rajendra Nayak
2012-07-16 12:14 ` Rajendra Nayak
2012-07-27 19:55 ` Kevin Hilman
2012-07-27 19:55 ` Kevin Hilman
2012-07-30 8:36 ` Tero Kristo
2012-07-30 8:36 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 7/8] ARM: OMAP: clockdomain: add support for preventing autodep delete Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 11:00 ` Rajendra Nayak
2012-07-16 11:00 ` Rajendra Nayak
2012-07-17 14:56 ` Tero Kristo
2012-07-17 14:56 ` Tero Kristo
2012-07-17 21:31 ` Paul Walmsley
2012-07-17 21:31 ` Paul Walmsley
2012-07-18 7:15 ` Rajendra Nayak
2012-07-18 7:15 ` Rajendra Nayak
2012-07-18 8:05 ` Tero Kristo
2012-07-18 8:05 ` Tero Kristo
2012-07-18 9:04 ` Rajendra Nayak
2012-07-18 9:04 ` Rajendra Nayak
2012-07-18 9:16 ` Tero Kristo
2012-07-18 9:16 ` Tero Kristo
2012-07-27 20:12 ` Kevin Hilman
2012-07-27 20:12 ` Kevin Hilman
2012-07-13 14:19 ` [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-09-18 22:25 ` Paul Walmsley
2012-09-18 22:25 ` Paul Walmsley
2012-09-18 22:43 ` Paul Walmsley
2012-09-18 22:43 ` Paul Walmsley
2012-09-19 22:15 ` Kevin Hilman
2012-09-19 22:15 ` Kevin Hilman
2012-10-16 7:29 ` Paul Walmsley
2012-10-16 7:29 ` Paul Walmsley
2012-10-17 0:39 ` Kevin Hilman
2012-10-17 0:39 ` Kevin Hilman
2012-10-31 11:59 ` Tero Kristo
2012-10-31 11:59 ` Tero Kristo
2012-09-19 9:06 ` Tero Kristo
2012-09-19 9:06 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3xpj9sc.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.