[PATCH 4/6] udf: remove un-needed variable from inode_getblk

[PATCH 4/6] udf: remove un-needed variable from inode_getblk

[Namjae Jeon]

From: Namjae Jeon <namjae.jeon@samsung.com>

The variable last_block is not needed.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
 fs/udf/inode.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 76a1f57..6fd9dc5 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -587,7 +587,6 @@ out:
 static sector_t inode_getblk(struct inode *inode, sector_t block,
 			     int *err, int *new)
 {
-	static sector_t last_block;
 	struct kernel_long_ad laarr[EXTENT_MERGE_SIZE];
 	struct extent_position prev_epos, cur_epos, next_epos;
 	int count = 0, startnum = 0, endnum = 0;
@@ -677,7 +676,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
 		return newblock;
 	}
 
-	last_block = block;
 	/* Are we beyond EOF? */
 	if (etype == -1) {
 		int ret;
@@ -719,7 +717,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
 			memset(&laarr[c].extLocation, 0x00,
 				sizeof(struct kernel_lb_addr));
 			count++;
-			endnum++;
 		}
 		endnum = c + 1;
 		lastblock = 1;
-- 
1.7.9.5

Re: [PATCH 4/6] udf: remove un-needed variable from inode_getblk

[Jan Kara]

On Wed 10-10-12 00:09:44, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> The variable last_block is not needed.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
  Thanks. I've merged the patch.

						Honza
> ---
>  fs/udf/inode.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 76a1f57..6fd9dc5 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -587,7 +587,6 @@ out:
>  static sector_t inode_getblk(struct inode *inode, sector_t block,
>  			     int *err, int *new)
>  {
> -	static sector_t last_block;
>  	struct kernel_long_ad laarr[EXTENT_MERGE_SIZE];
>  	struct extent_position prev_epos, cur_epos, next_epos;
>  	int count = 0, startnum = 0, endnum = 0;
> @@ -677,7 +676,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
>  		return newblock;
>  	}
>  
> -	last_block = block;
>  	/* Are we beyond EOF? */
>  	if (etype == -1) {
>  		int ret;
> @@ -719,7 +717,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
>  			memset(&laarr[c].extLocation, 0x00,
>  				sizeof(struct kernel_lb_addr));
>  			count++;
> -			endnum++;
>  		}
>  		endnum = c + 1;
>  		lastblock = 1;
> -- 
> 1.7.9.5
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR