* [PATCH 4/6] udf: remove un-needed variable from inode_getblk
@ 2012-10-09 15:09 Namjae Jeon
2012-10-11 18:11 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2012-10-09 15:09 UTC (permalink / raw)
To: jack; +Cc: linux-kernel, Namjae Jeon, Namjae Jeon, Ashish Sangwan
From: Namjae Jeon <namjae.jeon@samsung.com>
The variable last_block is not needed.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
fs/udf/inode.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 76a1f57..6fd9dc5 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -587,7 +587,6 @@ out:
static sector_t inode_getblk(struct inode *inode, sector_t block,
int *err, int *new)
{
- static sector_t last_block;
struct kernel_long_ad laarr[EXTENT_MERGE_SIZE];
struct extent_position prev_epos, cur_epos, next_epos;
int count = 0, startnum = 0, endnum = 0;
@@ -677,7 +676,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
return newblock;
}
- last_block = block;
/* Are we beyond EOF? */
if (etype == -1) {
int ret;
@@ -719,7 +717,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
memset(&laarr[c].extLocation, 0x00,
sizeof(struct kernel_lb_addr));
count++;
- endnum++;
}
endnum = c + 1;
lastblock = 1;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/6] udf: remove un-needed variable from inode_getblk
2012-10-09 15:09 [PATCH 4/6] udf: remove un-needed variable from inode_getblk Namjae Jeon
@ 2012-10-11 18:11 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2012-10-11 18:11 UTC (permalink / raw)
To: Namjae Jeon; +Cc: jack, linux-kernel, Namjae Jeon, Ashish Sangwan
On Wed 10-10-12 00:09:44, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> The variable last_block is not needed.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Thanks. I've merged the patch.
Honza
> ---
> fs/udf/inode.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 76a1f57..6fd9dc5 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -587,7 +587,6 @@ out:
> static sector_t inode_getblk(struct inode *inode, sector_t block,
> int *err, int *new)
> {
> - static sector_t last_block;
> struct kernel_long_ad laarr[EXTENT_MERGE_SIZE];
> struct extent_position prev_epos, cur_epos, next_epos;
> int count = 0, startnum = 0, endnum = 0;
> @@ -677,7 +676,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> return newblock;
> }
>
> - last_block = block;
> /* Are we beyond EOF? */
> if (etype == -1) {
> int ret;
> @@ -719,7 +717,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> memset(&laarr[c].extLocation, 0x00,
> sizeof(struct kernel_lb_addr));
> count++;
> - endnum++;
> }
> endnum = c + 1;
> lastblock = 1;
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-11 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 15:09 [PATCH 4/6] udf: remove un-needed variable from inode_getblk Namjae Jeon
2012-10-11 18:11 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.