From: Michal Hocko <mhocko@suse.cz> To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Johannes Weiner <hannes@cmpxchg.org>, Ying Han <yinghan@google.com>, Tejun Heo <htejun@gmail.com>, Glauber Costa <glommer@parallels.com>, Li Zefan <lizefan@huawei.com> Subject: [PATCH v3 7/7] cgroup: remove css_get_next Date: Thu, 3 Jan 2013 18:54:21 +0100 [thread overview] Message-ID: <1357235661-29564-8-git-send-email-mhocko@suse.cz> (raw) In-Reply-To: <1357235661-29564-1-git-send-email-mhocko@suse.cz> Now that we have generic and well ordered cgroup tree walkers there is no need to keep css_get_next in the place. Signed-off-by: Michal Hocko <mhocko@suse.cz> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- include/linux/cgroup.h | 7 ------- kernel/cgroup.c | 49 ------------------------------------------------ 2 files changed, 56 deletions(-) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 7d73905..a4d86b0 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -685,13 +685,6 @@ void free_css_id(struct cgroup_subsys *ss, struct cgroup_subsys_state *css); struct cgroup_subsys_state *css_lookup(struct cgroup_subsys *ss, int id); -/* - * Get a cgroup whose id is greater than or equal to id under tree of root. - * Returning a cgroup_subsys_state or NULL. - */ -struct cgroup_subsys_state *css_get_next(struct cgroup_subsys *ss, int id, - struct cgroup_subsys_state *root, int *foundid); - /* Returns true if root is ancestor of cg */ bool css_is_ancestor(struct cgroup_subsys_state *cg, const struct cgroup_subsys_state *root); diff --git a/kernel/cgroup.c b/kernel/cgroup.c index f34c41b..3013ec4 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -5384,55 +5384,6 @@ struct cgroup_subsys_state *css_lookup(struct cgroup_subsys *ss, int id) } EXPORT_SYMBOL_GPL(css_lookup); -/** - * css_get_next - lookup next cgroup under specified hierarchy. - * @ss: pointer to subsystem - * @id: current position of iteration. - * @root: pointer to css. search tree under this. - * @foundid: position of found object. - * - * Search next css under the specified hierarchy of rootid. Calling under - * rcu_read_lock() is necessary. Returns NULL if it reaches the end. - */ -struct cgroup_subsys_state * -css_get_next(struct cgroup_subsys *ss, int id, - struct cgroup_subsys_state *root, int *foundid) -{ - struct cgroup_subsys_state *ret = NULL; - struct css_id *tmp; - int tmpid; - int rootid = css_id(root); - int depth = css_depth(root); - - if (!rootid) - return NULL; - - BUG_ON(!ss->use_id); - WARN_ON_ONCE(!rcu_read_lock_held()); - - /* fill start point for scan */ - tmpid = id; - while (1) { - /* - * scan next entry from bitmap(tree), tmpid is updated after - * idr_get_next(). - */ - tmp = idr_get_next(&ss->idr, &tmpid); - if (!tmp) - break; - if (tmp->depth >= depth && tmp->stack[depth] == rootid) { - ret = rcu_dereference(tmp->css); - if (ret) { - *foundid = tmpid; - break; - } - } - /* continue to scan from next id */ - tmpid = tmpid + 1; - } - return ret; -} - /* * get corresponding css from file open on cgroupfs directory */ -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz> To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Johannes Weiner <hannes@cmpxchg.org>, Ying Han <yinghan@google.com>, Tejun Heo <htejun@gmail.com>, Glauber Costa <glommer@parallels.com>, Li Zefan <lizefan@huawei.com> Subject: [PATCH v3 7/7] cgroup: remove css_get_next Date: Thu, 3 Jan 2013 18:54:21 +0100 [thread overview] Message-ID: <1357235661-29564-8-git-send-email-mhocko@suse.cz> (raw) In-Reply-To: <1357235661-29564-1-git-send-email-mhocko@suse.cz> Now that we have generic and well ordered cgroup tree walkers there is no need to keep css_get_next in the place. Signed-off-by: Michal Hocko <mhocko@suse.cz> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- include/linux/cgroup.h | 7 ------- kernel/cgroup.c | 49 ------------------------------------------------ 2 files changed, 56 deletions(-) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index 7d73905..a4d86b0 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -685,13 +685,6 @@ void free_css_id(struct cgroup_subsys *ss, struct cgroup_subsys_state *css); struct cgroup_subsys_state *css_lookup(struct cgroup_subsys *ss, int id); -/* - * Get a cgroup whose id is greater than or equal to id under tree of root. - * Returning a cgroup_subsys_state or NULL. - */ -struct cgroup_subsys_state *css_get_next(struct cgroup_subsys *ss, int id, - struct cgroup_subsys_state *root, int *foundid); - /* Returns true if root is ancestor of cg */ bool css_is_ancestor(struct cgroup_subsys_state *cg, const struct cgroup_subsys_state *root); diff --git a/kernel/cgroup.c b/kernel/cgroup.c index f34c41b..3013ec4 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -5384,55 +5384,6 @@ struct cgroup_subsys_state *css_lookup(struct cgroup_subsys *ss, int id) } EXPORT_SYMBOL_GPL(css_lookup); -/** - * css_get_next - lookup next cgroup under specified hierarchy. - * @ss: pointer to subsystem - * @id: current position of iteration. - * @root: pointer to css. search tree under this. - * @foundid: position of found object. - * - * Search next css under the specified hierarchy of rootid. Calling under - * rcu_read_lock() is necessary. Returns NULL if it reaches the end. - */ -struct cgroup_subsys_state * -css_get_next(struct cgroup_subsys *ss, int id, - struct cgroup_subsys_state *root, int *foundid) -{ - struct cgroup_subsys_state *ret = NULL; - struct css_id *tmp; - int tmpid; - int rootid = css_id(root); - int depth = css_depth(root); - - if (!rootid) - return NULL; - - BUG_ON(!ss->use_id); - WARN_ON_ONCE(!rcu_read_lock_held()); - - /* fill start point for scan */ - tmpid = id; - while (1) { - /* - * scan next entry from bitmap(tree), tmpid is updated after - * idr_get_next(). - */ - tmp = idr_get_next(&ss->idr, &tmpid); - if (!tmp) - break; - if (tmp->depth >= depth && tmp->stack[depth] == rootid) { - ret = rcu_dereference(tmp->css); - if (ret) { - *foundid = tmpid; - break; - } - } - /* continue to scan from next id */ - tmpid = tmpid + 1; - } - return ret; -} - /* * get corresponding css from file open on cgroupfs directory */ -- 1.7.10.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-01-03 17:55 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-03 17:54 [PATCH v3 0/7] rework mem_cgroup iterator Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-03 17:54 ` [PATCH v3 1/7] memcg: synchronize per-zone iterator access by a spinlock Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-03 17:54 ` [PATCH v3 2/7] memcg: keep prev's css alive for the whole mem_cgroup_iter Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-03 17:54 ` [PATCH v3 3/7] memcg: rework mem_cgroup_iter to use cgroup iterators Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-03 17:54 ` [PATCH v3 4/7] memcg: remove memcg from the reclaim iterators Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-07 6:18 ` Kamezawa Hiroyuki 2013-01-07 6:18 ` Kamezawa Hiroyuki 2013-02-08 19:33 ` Johannes Weiner 2013-02-08 19:33 ` Johannes Weiner 2013-02-11 15:16 ` Michal Hocko 2013-02-11 15:16 ` Michal Hocko 2013-02-11 17:56 ` Johannes Weiner 2013-02-11 17:56 ` Johannes Weiner 2013-02-11 19:29 ` Michal Hocko 2013-02-11 19:29 ` Michal Hocko 2013-02-11 19:58 ` Johannes Weiner 2013-02-11 19:58 ` Johannes Weiner 2013-02-11 21:27 ` Michal Hocko 2013-02-11 21:27 ` Michal Hocko 2013-02-11 22:07 ` Michal Hocko 2013-02-11 22:07 ` Michal Hocko 2013-02-11 22:39 ` Johannes Weiner 2013-02-11 22:39 ` Johannes Weiner 2013-02-12 9:54 ` Michal Hocko 2013-02-12 9:54 ` Michal Hocko 2013-02-12 15:10 ` Johannes Weiner 2013-02-12 15:10 ` Johannes Weiner 2013-02-12 15:43 ` Michal Hocko 2013-02-12 15:43 ` Michal Hocko 2013-02-12 16:10 ` Paul E. McKenney 2013-02-12 16:10 ` Paul E. McKenney 2013-02-12 17:25 ` Johannes Weiner 2013-02-12 17:25 ` Johannes Weiner 2013-02-12 18:31 ` Paul E. McKenney 2013-02-12 18:31 ` Paul E. McKenney 2013-02-12 19:53 ` Johannes Weiner 2013-02-12 19:53 ` Johannes Weiner 2013-02-13 9:51 ` Michal Hocko 2013-02-13 9:51 ` Michal Hocko 2013-02-12 17:56 ` Michal Hocko 2013-02-12 17:56 ` Michal Hocko 2013-02-12 16:13 ` Michal Hocko 2013-02-12 16:13 ` Michal Hocko 2013-02-12 16:24 ` Michal Hocko 2013-02-12 16:24 ` Michal Hocko 2013-02-12 16:37 ` Michal Hocko 2013-02-12 16:37 ` Michal Hocko 2013-02-12 16:41 ` Johannes Weiner 2013-02-12 16:41 ` Johannes Weiner 2013-02-12 17:12 ` Michal Hocko 2013-02-12 17:12 ` Michal Hocko 2013-02-12 17:37 ` Johannes Weiner 2013-02-12 17:37 ` Johannes Weiner 2013-02-13 8:11 ` Glauber Costa 2013-02-13 8:11 ` Glauber Costa 2013-02-13 10:38 ` Michal Hocko 2013-02-13 10:38 ` Michal Hocko 2013-02-13 10:34 ` Michal Hocko 2013-02-13 10:34 ` Michal Hocko 2013-02-13 12:56 ` Michal Hocko 2013-02-13 12:56 ` Michal Hocko 2013-02-12 16:33 ` Johannes Weiner 2013-02-12 16:33 ` Johannes Weiner 2013-01-03 17:54 ` [PATCH v3 5/7] memcg: simplify mem_cgroup_iter Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-03 17:54 ` [PATCH v3 6/7] memcg: further " Michal Hocko 2013-01-03 17:54 ` Michal Hocko 2013-01-03 17:54 ` Michal Hocko [this message] 2013-01-03 17:54 ` [PATCH v3 7/7] cgroup: remove css_get_next Michal Hocko 2013-01-04 3:42 ` Li Zefan 2013-01-04 3:42 ` Li Zefan 2013-01-23 12:52 ` [PATCH v3 0/7] rework mem_cgroup iterator Michal Hocko 2013-01-23 12:52 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1357235661-29564-8-git-send-email-mhocko@suse.cz \ --to=mhocko@suse.cz \ --cc=glommer@parallels.com \ --cc=hannes@cmpxchg.org \ --cc=htejun@gmail.com \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=lizefan@huawei.com \ --cc=yinghan@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.