[PATCH] n_tty: Unthrottle tty when flushing read buffer

[PATCH] n_tty: Unthrottle tty when flushing read buffer

[Karthik Manamcheri]

When the tty input buffer is full and thereby throttled,
flushing/resetting the read buffer should unthrottle to allow more
data to be received.

Signed-off-by: Karthik Manamcheri <Karthik.Manamcheri@ni.com>
---
 drivers/tty/n_tty.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 19083efa2314660b25e0fb5bc793af6fb7e9af57..d5cea3bb01eaeec61b577de6c58a8000412c0c37 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -229,6 +229,8 @@ static void reset_buffer_flags(struct tty_struct *tty)
 	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
 	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
 	n_tty_set_room(tty);
+
+	check_unthrottle(tty);
 }
 
 /**
-- 
1.8.1.1

Re: [PATCH] n_tty: Unthrottle tty when flushing read buffer

[Peter Hurley]

[cc'ing Ilya Zykov]

Hi Karthik,

On Wed, 2013-01-23 at 16:36 -0600, Karthik Manamcheri wrote:
> When the tty input buffer is full and thereby throttled,
> flushing/resetting the read buffer should unthrottle to allow more
> data to be received.
> 
> Signed-off-by: Karthik Manamcheri <Karthik.Manamcheri@ni.com>
> ---
>  drivers/tty/n_tty.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 19083efa2314660b25e0fb5bc793af6fb7e9af57..d5cea3bb01eaeec61b577de6c58a8000412c0c37 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -229,6 +229,8 @@ static void reset_buffer_flags(struct tty_struct *tty)
>  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
>  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
>  	n_tty_set_room(tty);
> +
> +	check_unthrottle(tty);
>  }
>  
>  /**

Although it's not really my place to NAK, the maintainership was
recently transitioned, so NAK.  See this kernel thread
http://www.gossamer-threads.com/lists/linux/kernel/1636154?do=post_view_threaded#1636154
for why.

See if this patch
http://www.gossamer-threads.com/lists/linux/kernel/1660788
works for you instead.

Regards,
Peter Hurley

Re: [PATCH] n_tty: Unthrottle tty when flushing read buffer

[Ilya Zykov]

On 24.01.2013 2:36, Karthik Manamcheri wrote:
> When the tty input buffer is full and thereby throttled,
> flushing/resetting the read buffer should unthrottle to allow more
> data to be received.
> 
> Signed-off-by: Karthik Manamcheri <Karthik.Manamcheri@ni.com>
> ---
>  drivers/tty/n_tty.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 19083efa2314660b25e0fb5bc793af6fb7e9af57..d5cea3bb01eaeec61b577de6c58a8000412c0c37 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -229,6 +229,8 @@ static void reset_buffer_flags(struct tty_struct *tty)
>  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
>  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
>  	n_tty_set_room(tty);
> +
> +	check_unthrottle(tty);
>  }
>  
>  /**
> 

It's revert - tty: fix "IRQ45: nobody cared".
commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304

Please, read these for this subject:
https://lkml.org/lkml/2012/11/27/440
https://lkml.org/lkml/2012/11/21/568

https://lkml.org/lkml/2012/11/22/686

It's already fixed in the:
commit a1bf9584429d61b7096f93ae09325e1ba538e9e8
tty: Add driver unthrottle in ioctl(...,TCFLSH,..).

Re: [PATCH] n_tty: Unthrottle tty when flushing read buffer

[Greg Kroah-Hartman]

On Tue, Jan 29, 2013 at 02:17:26AM +0400, Ilya Zykov wrote:
> On 24.01.2013 2:36, Karthik Manamcheri wrote:
> > When the tty input buffer is full and thereby throttled,
> > flushing/resetting the read buffer should unthrottle to allow more
> > data to be received.
> > 
> > Signed-off-by: Karthik Manamcheri <Karthik.Manamcheri@ni.com>
> > ---
> >  drivers/tty/n_tty.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> > index 19083efa2314660b25e0fb5bc793af6fb7e9af57..d5cea3bb01eaeec61b577de6c58a8000412c0c37 100644
> > --- a/drivers/tty/n_tty.c
> > +++ b/drivers/tty/n_tty.c
> > @@ -229,6 +229,8 @@ static void reset_buffer_flags(struct tty_struct *tty)
> >  	ldata->canon_head = ldata->canon_data = ldata->erasing = 0;
> >  	bitmap_zero(ldata->read_flags, N_TTY_BUF_SIZE);
> >  	n_tty_set_room(tty);
> > +
> > +	check_unthrottle(tty);
> >  }
> >  
> >  /**
> > 
> 
> It's revert - tty: fix "IRQ45: nobody cared".
> commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304
> 
> Please, read these for this subject:
> https://lkml.org/lkml/2012/11/27/440
> https://lkml.org/lkml/2012/11/21/568
> 
> https://lkml.org/lkml/2012/11/22/686
> 
> It's already fixed in the:
> commit a1bf9584429d61b7096f93ae09325e1ba538e9e8
> tty: Add driver unthrottle in ioctl(...,TCFLSH,..).

Sorry about that, I'll go revert this now, my fault.

greg k-h