All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mason <slash.tmp@free.fr>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm <linux-pm@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Thibaud Cornic <thibaud_cornic@sigmadesigns.com>
Subject: Re: cpufreq: frequency scaling spec in DT node
Date: Thu, 29 Jun 2017 15:01:11 +0200	[thread overview]
Message-ID: <136334fe-c2a7-875b-91e0-329a0d7a2304@free.fr> (raw)
In-Reply-To: <538b1aa2-9298-6f21-392e-73d6559b581c@free.fr>

On 29/06/2017 13:41, Mason wrote:

> On 29/06/2017 12:04, Viresh Kumar wrote:
> 
>> There is one thing you can do to avoid adding OPP entries in the DT.
>> You can rather add them dynamically with help of: dev_pm_opp_add() and
>> cpufreq-dt will continue to work with that too.
> 
> In what driver should I call these... the clk driver?
> (drivers/clk/tegra/cvb.c seems to be doind that)

The problem I run into is that calling get_cpu_device(0) from the
clk driver returns NULL, because topology_init() has not run yet
(to initialize the cpu_sys_devices).

So the OPP table needs to be built *after* topology_init() but
*before* dt_cpufreq_probe().

subsys_initcall(topology_init);
device_initcall(cpufreq_dt_platdev_init);

I'm not sure how to proceed.

Regards.

WARNING: multiple messages have this Message-ID (diff)
From: slash.tmp@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: cpufreq: frequency scaling spec in DT node
Date: Thu, 29 Jun 2017 15:01:11 +0200	[thread overview]
Message-ID: <136334fe-c2a7-875b-91e0-329a0d7a2304@free.fr> (raw)
In-Reply-To: <538b1aa2-9298-6f21-392e-73d6559b581c@free.fr>

On 29/06/2017 13:41, Mason wrote:

> On 29/06/2017 12:04, Viresh Kumar wrote:
> 
>> There is one thing you can do to avoid adding OPP entries in the DT.
>> You can rather add them dynamically with help of: dev_pm_opp_add() and
>> cpufreq-dt will continue to work with that too.
> 
> In what driver should I call these... the clk driver?
> (drivers/clk/tegra/cvb.c seems to be doind that)

The problem I run into is that calling get_cpu_device(0) from the
clk driver returns NULL, because topology_init() has not run yet
(to initialize the cpu_sys_devices).

So the OPP table needs to be built *after* topology_init() but
*before* dt_cpufreq_probe().

subsys_initcall(topology_init);
device_initcall(cpufreq_dt_platdev_init);

I'm not sure how to proceed.

Regards.

  reply	other threads:[~2017-06-29 13:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29  9:48 cpufreq: frequency scaling spec in DT node Mason
2017-06-29  9:48 ` Mason
2017-06-29 10:04 ` Viresh Kumar
2017-06-29 10:04   ` Viresh Kumar
2017-06-29 11:41   ` Mason
2017-06-29 11:41     ` Mason
2017-06-29 13:01     ` Mason [this message]
2017-06-29 13:01       ` Mason
2017-06-29 14:35       ` Viresh Kumar
2017-06-29 14:35         ` Viresh Kumar
2017-06-29 14:34     ` Viresh Kumar
2017-06-29 14:34       ` Viresh Kumar
2017-07-11  9:27       ` Mason
2017-07-11  9:27         ` Mason
2017-07-11 10:25         ` Viresh Kumar
2017-07-11 10:25           ` Viresh Kumar
2017-07-11 11:09           ` Mason
2017-07-11 11:09             ` Mason
2017-07-11 11:56             ` Mason
2017-07-11 11:56               ` Mason
2017-07-12  3:41             ` Viresh Kumar
2017-07-12  3:41               ` Viresh Kumar
2017-07-12  9:58               ` Mason
2017-07-12  9:58                 ` Mason
2017-07-12 10:09                 ` Viresh Kumar
2017-07-12 10:09                   ` Viresh Kumar
2017-07-12 11:25                   ` Mason
2017-07-12 11:25                     ` Mason
2017-07-12 14:08                     ` Viresh Kumar
2017-07-12 14:08                       ` Viresh Kumar
2017-07-11 13:36         ` Mason
2017-07-11 13:36           ` Mason
2017-07-12  3:56           ` Viresh Kumar
2017-07-12  3:56             ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=136334fe-c2a7-875b-91e0-329a0d7a2304@free.fr \
    --to=slash.tmp@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=thibaud_cornic@sigmadesigns.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.