All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Prisk <linux@prisktech.co.nz>
To: Alex Courbot <acourbot@nvidia.com>
Cc: "romain.naour@openwide.fr" <romain.naour@openwide.fr>,
	"thierry.reding@avionic-design.de"
	<thierry.reding@avionic-design.de>,
	"philipp.zabel@gmail.com" <philipp.zabel@gmail.com>,
	"gxt@mprc.pku.edu.cn" <gxt@mprc.pku.edu.cn>,
	"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
	"laforge@openezx.org" <laforge@openezx.org>,
	"openezx-devel@lists.openezx.org"
	<openezx-devel@lists.openezx.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"lost.distance@yahoo.com" <lost.distance@yahoo.com>,
	"drwyrm@gmail.com" <drwyrm@gmail.com>,
	"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
	"haojian.zhuang@gmail.com" <haojian.zhuang@gmail.com>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	eric.
Subject: Re: [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight.
Date: Wed, 20 Mar 2013 20:13:08 +1300	[thread overview]
Message-ID: <1363763588.30752.7.camel@gitbox> (raw)
In-Reply-To: <51491DF0.10408@nvidia.com>

On Wed, 2013-03-20 at 11:24 +0900, Alex Courbot wrote:
> On 03/20/2013 11:14 AM, Shawn Guo wrote:
> > On Tue, Mar 19, 2013 at 11:59:24AM -0700, Andrew Chew wrote:
> >> Many backlights are enabled via GPIO.  We can generalize the GPIO to a
> >> fixed regulator.
> >>
> > I think we should push the series of "Runtime Interpreted Power
> > Sequences" moving forward, which should be useful this case and many
> > other cases as well.
> >
> > http://thread.gmane.org/gmane.linux.kernel/1395912
> 
> That's still the medium-term plan. But doing this correctly requires 
> some improvements to be done in the GPIO subsystem, which I am pushing 
> at the moment.
> 
> Eventually power sequences should handle this kind of scenario, but by 
> the meantime it cannot hurt to get the job done.
> 
> Alex.

I don't mind this patch personally, so take this query as more of a
'generalization' than a problem with this patch:


This patch changes the binding for an already used device (by addition
of a required property), which isn't so bad BUT, as Alex pointed out,
the binding will probably end up being changed again once power
sequencing is sorted out.

I realise it's still early days and things need to be tried-and-tested
first, but wasn't the point of the bindings that they should be
finalized (as best as possible anyway) the first time, so we don't have
to worry about incompatibilities between bindings and drivers?

Regards

Tony P

WARNING: multiple messages have this Message-ID (diff)
From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight.
Date: Wed, 20 Mar 2013 20:13:08 +1300	[thread overview]
Message-ID: <1363763588.30752.7.camel@gitbox> (raw)
In-Reply-To: <51491DF0.10408@nvidia.com>

On Wed, 2013-03-20 at 11:24 +0900, Alex Courbot wrote:
> On 03/20/2013 11:14 AM, Shawn Guo wrote:
> > On Tue, Mar 19, 2013 at 11:59:24AM -0700, Andrew Chew wrote:
> >> Many backlights are enabled via GPIO.  We can generalize the GPIO to a
> >> fixed regulator.
> >>
> > I think we should push the series of "Runtime Interpreted Power
> > Sequences" moving forward, which should be useful this case and many
> > other cases as well.
> >
> > http://thread.gmane.org/gmane.linux.kernel/1395912
> 
> That's still the medium-term plan. But doing this correctly requires 
> some improvements to be done in the GPIO subsystem, which I am pushing 
> at the moment.
> 
> Eventually power sequences should handle this kind of scenario, but by 
> the meantime it cannot hurt to get the job done.
> 
> Alex.

I don't mind this patch personally, so take this query as more of a
'generalization' than a problem with this patch:


This patch changes the binding for an already used device (by addition
of a required property), which isn't so bad BUT, as Alex pointed out,
the binding will probably end up being changed again once power
sequencing is sorted out.

I realise it's still early days and things need to be tried-and-tested
first, but wasn't the point of the bindings that they should be
finalized (as best as possible anyway) the first time, so we don't have
to worry about incompatibilities between bindings and drivers?

Regards

Tony P

  parent reply	other threads:[~2013-03-20  7:13 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 18:59 [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-19 18:59 ` Andrew Chew
     [not found] ` <1363719573-20926-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 18:59   ` [PATCH V4 1/9] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 2/9] ARM: S3C24XX: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 4/9] ARM: EXYNOS: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 5/9] unicore32: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 18:59   ` [PATCH V4 6/9] ARM: mxs: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-19 21:27     ` Marek Vasut
2013-03-19 21:27       ` Marek Vasut
2013-03-19 21:31       ` Andrew Chew
2013-03-19 21:31         ` Andrew Chew
2013-03-19 21:35         ` Marek Vasut
2013-03-19 21:35           ` Marek Vasut
     [not found]       ` <201303192227.21717.marex-ynQEQJNshbs@public.gmane.org>
2013-03-19 22:10         ` Stephen Warren
2013-03-19 22:10           ` Stephen Warren
2013-03-20  8:23           ` Mark Brown
2013-03-20  8:23             ` Mark Brown
     [not found]             ` <20130320082318.GA28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 14:03               ` Marek Vasut
2013-03-20 14:03                 ` Marek Vasut
2013-03-20  3:13     ` Shawn Guo
2013-03-20  3:13       ` Shawn Guo
2013-03-19 18:59   ` [PATCH V4 7/9] ARM: vt8500: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-20 18:18     ` [Bulk] " Tony Prisk
2013-03-20 18:18       ` Tony Prisk
2013-03-19 18:59   ` [PATCH V4 8/9] ARM: tegra: " Andrew Chew
2013-03-19 18:59     ` Andrew Chew
2013-03-21 20:01     ` Stephen Warren
2013-03-21 20:01       ` Stephen Warren
     [not found]     ` <1363719573-20926-9-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-22 10:29       ` Thierry Reding
2013-03-22 10:29         ` Thierry Reding
2013-03-19 18:59   ` [PATCH V4 9/9] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-19 18:59     ` Andrew Chew
     [not found]     ` <1363719573-20926-10-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 18:00       ` Stephen Warren
2013-03-20 18:00         ` Stephen Warren
     [not found]         ` <5149F92A.3070004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 22:19           ` Thierry Reding
2013-03-20 22:19             ` Thierry Reding
2013-03-19 18:59 ` [PATCH V4 3/9] ARM: pxa: Provide regulator to pwm-backlight Andrew Chew
2013-03-19 18:59   ` Andrew Chew
2013-03-20  2:14 ` [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Shawn Guo
2013-03-20  2:14   ` Shawn Guo
2013-03-20  2:24   ` Alex Courbot
2013-03-20  2:24     ` Alex Courbot
2013-03-20  3:08     ` Shawn Guo
2013-03-20  3:08       ` Shawn Guo
2013-03-20  7:13     ` Tony Prisk [this message]
2013-03-20  7:13       ` Tony Prisk
2013-03-22  1:57 ` Alex Courbot
2013-03-22  1:57   ` Alex Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363763588.30752.7.camel@gitbox \
    --to=linux@prisktech.co.nz \
    --cc=acourbot@nvidia.com \
    --cc=drwyrm@gmail.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=haojian.zhuang@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=laforge@openezx.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=lost.distance@yahoo.com \
    --cc=marek.vasut@gmail.com \
    --cc=openezx-devel@lists.openezx.org \
    --cc=philipp.zabel@gmail.com \
    --cc=robert.jarzmik@free.fr \
    --cc=romain.naour@openwide.fr \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.