From: Marek Vasut <marex@denx.de>
To: Andrew Chew <AChew@nvidia.com>
Cc: "romain.naour@openwide.fr" <romain.naour@openwide.fr>,
"thierry.reding@avionic-design.de"
<thierry.reding@avionic-design.de>,
"philipp.zabel@gmail.com" <philipp.zabel@gmail.com>,
"gxt@mprc.pku.edu.cn" <gxt@mprc.pku.edu.cn>,
"robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
"laforge@openezx.org" <laforge@openezx.org>,
"openezx-devel@lists.openezx.org"
<openezx-devel@lists.openezx.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"lost.distance@yahoo.com" <lost.distance@yahoo.com>,
"drwyrm@gmail.com" <drwyrm@gmail.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"haojian.zhuang@gmail.com" <haojian.zhuang@gmail.com>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
Alex Courbot <acourbot@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
linux-arm-kernel@lists.i
Subject: Re: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight
Date: Tue, 19 Mar 2013 22:35:05 +0100 [thread overview]
Message-ID: <201303192235.06137.marex@denx.de> (raw)
In-Reply-To: <643E69AA4436674C8F39DCC2C05F7638629CD2FDF4@HQMAIL03.nvidia.com>
Dear Andrew Chew,
> > Dear Andrew Chew,
> >
> > > The pwm-backlight driver now takes a mandatory regulator that is
> > > gotten during driver probe. Initialize a dummy regulator to satisfy
> > > this requirement.
> > >
> > > Signed-off-by: Andrew Chew <achew@nvidia.com>
> >
> > Do we really need a mandatory regulator? Why can't it be optional?
> >
> > Best regards,
> > Marek Vasut
>
> Because for those using board setup code (and not devicetree), it was
> not possible to distinguish between opting out of the regulator, and
> deferred probe, without adding something to the platform data that
> board setup code needed to fill in anyway.
Sure, but this adds a bit of overhead for the DT platforms, no?
Other than this curiosity, I have no problems with this stuff.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight
Date: Tue, 19 Mar 2013 22:35:05 +0100 [thread overview]
Message-ID: <201303192235.06137.marex@denx.de> (raw)
In-Reply-To: <643E69AA4436674C8F39DCC2C05F7638629CD2FDF4@HQMAIL03.nvidia.com>
Dear Andrew Chew,
> > Dear Andrew Chew,
> >
> > > The pwm-backlight driver now takes a mandatory regulator that is
> > > gotten during driver probe. Initialize a dummy regulator to satisfy
> > > this requirement.
> > >
> > > Signed-off-by: Andrew Chew <achew@nvidia.com>
> >
> > Do we really need a mandatory regulator? Why can't it be optional?
> >
> > Best regards,
> > Marek Vasut
>
> Because for those using board setup code (and not devicetree), it was
> not possible to distinguish between opting out of the regulator, and
> deferred probe, without adding something to the platform data that
> board setup code needed to fill in anyway.
Sure, but this adds a bit of overhead for the DT platforms, no?
Other than this curiosity, I have no problems with this stuff.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-03-19 21:35 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 18:59 [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Andrew Chew
2013-03-19 18:59 ` Andrew Chew
[not found] ` <1363719573-20926-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-19 18:59 ` [PATCH V4 1/9] ARM: OMAP: board-4430sdp: Provide regulator to pwm-backlight Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-19 18:59 ` [PATCH V4 2/9] ARM: S3C24XX: " Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-19 18:59 ` [PATCH V4 4/9] ARM: EXYNOS: " Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-19 18:59 ` [PATCH V4 5/9] unicore32: " Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-19 18:59 ` [PATCH V4 6/9] ARM: mxs: " Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-19 21:27 ` Marek Vasut
2013-03-19 21:27 ` Marek Vasut
2013-03-19 21:31 ` Andrew Chew
2013-03-19 21:31 ` Andrew Chew
2013-03-19 21:35 ` Marek Vasut [this message]
2013-03-19 21:35 ` Marek Vasut
[not found] ` <201303192227.21717.marex-ynQEQJNshbs@public.gmane.org>
2013-03-19 22:10 ` Stephen Warren
2013-03-19 22:10 ` Stephen Warren
2013-03-20 8:23 ` Mark Brown
2013-03-20 8:23 ` Mark Brown
[not found] ` <20130320082318.GA28775-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2013-03-20 14:03 ` Marek Vasut
2013-03-20 14:03 ` Marek Vasut
2013-03-20 3:13 ` Shawn Guo
2013-03-20 3:13 ` Shawn Guo
2013-03-19 18:59 ` [PATCH V4 7/9] ARM: vt8500: " Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-20 18:18 ` [Bulk] " Tony Prisk
2013-03-20 18:18 ` Tony Prisk
2013-03-19 18:59 ` [PATCH V4 8/9] ARM: tegra: " Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-21 20:01 ` Stephen Warren
2013-03-21 20:01 ` Stephen Warren
[not found] ` <1363719573-20926-9-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-22 10:29 ` Thierry Reding
2013-03-22 10:29 ` Thierry Reding
2013-03-19 18:59 ` [PATCH V4 9/9] pwm_bl: Add mandatory backlight enable regulator Andrew Chew
2013-03-19 18:59 ` Andrew Chew
[not found] ` <1363719573-20926-10-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-20 18:00 ` Stephen Warren
2013-03-20 18:00 ` Stephen Warren
[not found] ` <5149F92A.3070004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-20 22:19 ` Thierry Reding
2013-03-20 22:19 ` Thierry Reding
2013-03-19 18:59 ` [PATCH V4 3/9] ARM: pxa: Provide regulator to pwm-backlight Andrew Chew
2013-03-19 18:59 ` Andrew Chew
2013-03-20 2:14 ` [PATCH V4 0/9] Add mandatory regulator for all users of pwm-backlight Shawn Guo
2013-03-20 2:14 ` Shawn Guo
2013-03-20 2:24 ` Alex Courbot
2013-03-20 2:24 ` Alex Courbot
2013-03-20 3:08 ` Shawn Guo
2013-03-20 3:08 ` Shawn Guo
2013-03-20 7:13 ` Tony Prisk
2013-03-20 7:13 ` Tony Prisk
2013-03-22 1:57 ` Alex Courbot
2013-03-22 1:57 ` Alex Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303192235.06137.marex@denx.de \
--to=marex@denx.de \
--cc=AChew@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=drwyrm@gmail.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=haojian.zhuang@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=laforge@openezx.org \
--cc=linux-arm-kernel@lists.i \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lost.distance@yahoo.com \
--cc=openezx-devel@lists.openezx.org \
--cc=philipp.zabel@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=romain.naour@openwide.fr \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.